Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 08:13:10 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Lukasz Majewski <lukma@denx.de>,
        Eric Dumazet <edumazet@google.com>,
        Andrew Lunn <andrew@lunn.ch>, davem@davemloft.net,
        Woojung Huh <woojung.huh@microchip.com>,
        Vladimir Oltean <olteanv@gmail.com>, Tristram.Ha@microchip.com,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata
 (DS80000754C)
Message-ID: <ZPA9hmlew3mT2TVr@shell.armlinux.org.uk>
References: <20230830125224.1012459f@wsk>
 <20230830105941.GH31399@pengutronix.de>
 <20230830135151.683303db@wsk>
 <20230830121738.GJ31399@pengutronix.de>
 <ZO83htinyfAp4mWw@shell.armlinux.org.uk>
 <20230830130649.GK31399@pengutronix.de>
 <ZO9Ejx9G8laNRasu@shell.armlinux.org.uk>
 <20230830142650.GL31399@pengutronix.de>
 <20230830183818.1f42919b@wsk>
 <20230831044004.GA17603@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230831044004.GA17603@pengutronix.de>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Thu, Aug 31, 2023 at 06:40:04AM +0200, Oleksij Rempel wrote:
> Hi Lukasz,
> 
> On Wed, Aug 30, 2023 at 06:38:18PM +0200, Lukasz Majewski wrote:
> > Hi Oleksij,
>  
> > The implementation as you suggested seems to work :-)
> > 
> > The ksz_get_phy_flags() - where the MICREL_NO_EEE is set is executed
> > before ksz9477_config_init().
> > 
> > And then the eee_broken_modes are taken into account.
> > 
> > # ethtool --show-eee lan1
> > EEE Settings for lan1:
> >         EEE status: disabled
> >         Tx LPI: 0 (us)
> >         Supported EEE link modes:  100baseT/Full 
> >                                    1000baseT/Full 
> >         Advertised EEE link modes:  Not reported
> >         Link partner advertised EEE link modes:  Not reported
> > 
> > I will prepare tomorrow a proper patch.
> 
> can you please by the way remove this line:
> https://elixir.bootlin.com/linux/v6.5/source/drivers/net/phy/micrel.c#L1803
> 
> it is obsolet by eee_broken_modes.

... and if possible verify on the link partner side that indeed no
EEE modes are being advertised by the Micrel device.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!