Received: by 2002:a05:7412:3210:b0:e2:908c:2ebd with SMTP id eu16csp483904rdb; Thu, 31 Aug 2023 15:42:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHu/l9SovKTWIrzdItx2sQoX0orerUqcLNCMPRPkpl85Y9WMDG3gI2QD0IeWSCZErIL2WfV X-Received: by 2002:a17:902:b192:b0:1c0:c4be:62ca with SMTP id s18-20020a170902b19200b001c0c4be62camr994581plr.17.1693521776511; Thu, 31 Aug 2023 15:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693521776; cv=none; d=google.com; s=arc-20160816; b=VkAMIEuDcayc2ppA5gUsoyXvF926Zk+Ljcgs56lmDXUpTfzRsI8FBSKKUovue3MyCI +S224+N76BLzVt64a1b4nkOP904lbebiCZz5DAsyrAQR8rndyMn7VQExdxSdd54ITk+p xMTqHq5Mg1cw2asn5YihnL1U1U/s+ruhWtG98FS2mik4N8z7izCA6n1vvhPqfK2xr3Ox R3CK5QeUrmBzSEYypdsH+VjST5Q+etQAqd2os2APuVLY2xGBdzbfbwJZ/1Sl5FbksiVI Ko/rAYIJkx1Z+KbfIAbaSk7FujC01X82BapVohfXgVD/Ott1cO0q2Lm1XYAamN0RZDPf MAEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=87rDRDLfR8euU4/qnJmzlvetsR8kRKEsMHeU8+ysTOU=; fh=F2myal56kH2u+3WwQSFXOpBQjczMtlSW5M2zy1ypF6o=; b=uDEw56GMkJc1c99t+utKs9mU5VrvvhOWneYXSkFy7GXkmp867FEEjRQHqiqaRn4j8Z 4XLekpwa/pB7ZHq5BnIPpJ2DVKxSSZdWoynmrD18D93zx45Rj42FaD3mQgwYPsHJ4cs0 bCMqqqU4N5+MsM8Drf4Clr9d0Z0QnZ97CF8XuiiRo4BF9+geF0J+YrXSwrKf7Un6IUxi 5mkPvCxHS83VHmWa5Nevu9zbnKVXRTP6kEKW5rvntqyUbUabiE2hN08UkdMHeLTX1OYY dLWTJQAciKsFRKgmWzbrEUx7U5TAKXM/aTuoulcAHET2vM/rIOdg1SVCFMj5mClWkTAo 0OBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j13-20020a170903024d00b001bbab2e5a27si1881891plh.290.2023.08.31.15.42.52; Thu, 31 Aug 2023 15:42:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238073AbjHaIK3 (ORCPT + 25 others); Thu, 31 Aug 2023 04:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241403AbjHaIKY (ORCPT ); Thu, 31 Aug 2023 04:10:24 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B35E0E7F for ; Thu, 31 Aug 2023 01:10:06 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="174580076" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 31 Aug 2023 17:10:05 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id F07CA4010DFB; Thu, 31 Aug 2023 17:09:58 +0900 (JST) From: Biju Das To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Zhu Wang , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Thierry Reding , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Guillaume BRUN , Rob Herring , Sandor Yu , Sam Ravnborg , Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers Date: Thu, 31 Aug 2023 09:09:37 +0100 Message-Id: <20230831080938.47454-4-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das Reviewed-by: Douglas Anderson --- v5->v6: * Added Rb tag from Douglas Anderson. * Dropped conditionals from remaining drm/bridge drivers. v5: * Split from patch#2 --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- drivers/gpu/drm/bridge/panel.c | 2 -- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c index 6169db73d2fe..ad8241758896 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client) mutex_init(&anx78xx->lock); -#if IS_ENABLED(CONFIG_OF) anx78xx->bridge.of_node = client->dev.of_node; -#endif anx78xx->client = client; i2c_set_clientdata(client, anx78xx); diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 9316384b4474..7f41525f7a6e 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel, panel_bridge->panel = panel; panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs; -#ifdef CONFIG_OF panel_bridge->bridge.of_node = panel->dev->of_node; -#endif panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES; panel_bridge->bridge.type = connector_type; diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 6c1d79474505..52d91a0df85e 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, | DRM_BRIDGE_OP_HPD; hdmi->bridge.interlace_allowed = true; hdmi->bridge.ddc = hdmi->ddc; -#ifdef CONFIG_OF hdmi->bridge.of_node = pdev->dev.of_node; -#endif memset(&pdevinfo, 0, sizeof(pdevinfo)); pdevinfo.parent = dev; diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 04d4a1a10698..a8dd2a2e7c7b 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, dsi->bridge.driver_private = dsi; dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs; -#ifdef CONFIG_OF dsi->bridge.of_node = pdev->dev.of_node; -#endif return dsi; } -- 2.25.1