Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 16:33:31 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Zheng Yejian <zhengyejian1@huawei.com>
Cc:     Brian Foster <bfoster@redhat.com>,
        <linux-trace-kernel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: zero the pipe cpumask on alloc to avoid
 spurious -EBUSY
Message-ID: <20230831163331.6c90c963@rorschach.local.home>
In-Reply-To: <26f8fb43-6ea8-edc2-381d-3600fce261af@huawei.com>
References: <20230831125500.986862-1-bfoster@redhat.com>
        <26f8fb43-6ea8-edc2-381d-3600fce261af@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 31 Aug 2023 21:51:18 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> > Hi,
> > 
> > I ran into this problem just recently on one of my test VMs immediately
> > after updating to a v6.5 base. A revert of the aforementioned commit
> > addressed the problem. I'm not terribly familiar with the tracing code,
> > but on further inspection I noticed the cpumask doesn't appear to be
> > initialized anywhere. I suppose this could alternatively do a
> > cpumask_clear() or whatever after allocation, but either way this
> > addresses the problem for me.  
> 
> Yes, pipe_cpumask must be initialized.

Can I add a Reviewed-by tag from you?

> 
> > 
> > Please CC on replies as I'm not subscribed to the list. Thanks.

That's the default with Linux kernel lists.

-- Steve