Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 16:54:30 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        krzysztof.kozlowski+dt@linaro.org,
        Rob Herring <robh+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-hwmon@vger.kernel.org,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: hwmon: Add Infineon TDA38640
Message-ID: <20230831-defrost-rebalance-5efda5e5ff5c@spud>
References: <20230830103620.3611761-1-Naresh.Solanki@9elements.com>
 <20230830-waving-stinky-d510fefbbf82@spud>
 <CABqG17hvSYbsnYYGOQxVsiXsqLXFnovXvkhgc=pYR9osgF0-1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="O1fh9UNgJ3s4p8a/"
Content-Disposition: inline
In-Reply-To: <CABqG17hvSYbsnYYGOQxVsiXsqLXFnovXvkhgc=pYR9osgF0-1g@mail.gmail.com>
Precedence: bulk


--O1fh9UNgJ3s4p8a/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote:
> Hi
>=20
> On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote:
> > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote:

> > > +      Indicates that the chip ENABLE pin is at fixed level or left
> > > +      unconnected(has internal pull-down).
> >
> > Maybe you've already been over this, but if the pin is called "enable"
> > why not use the same wording in the property?
> EN & ENABLE is used interchangeably in the datasheet.

Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for
2.

> Just to keep property name short I use EN.

Consistency & readability trump brevity. Please pick one term, or point
out that this is called two things in the datasheet.


--O1fh9UNgJ3s4p8a/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZPC3tgAKCRB4tDGHoIJi
0vXlAP0RUs5Q+UPtuiUUIIYh8V3uiABYhs8EIOVx51t+Sc2UpgEA30+M0Z1uzNoF
VoEdVvlU2zzYPyg3LvNdK79mokJJsgw=
=wh5+
-----END PGP SIGNATURE-----

--O1fh9UNgJ3s4p8a/--