Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 13:35:50 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     zev@bewilderbeest.net, Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regulator: Add uapi header
Message-ID: <813261e9-71d8-4fb6-aab0-474915662598@sirena.org.uk>
References: <20230831121412.2359239-1-Naresh.Solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="USLdL0WA7M+Hr251"
Content-Disposition: inline
In-Reply-To: <20230831121412.2359239-1-Naresh.Solanki@9elements.com>
Precedence: bulk


--USLdL0WA7M+Hr251
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Aug 31, 2023 at 02:14:08PM +0200, Naresh Solanki wrote:

> +#define REGULATOR_EVENT_UNDER_VOLTAGE		0x01
> +#define REGULATOR_EVENT_OVER_CURRENT		0x02
> +#define REGULATOR_EVENT_REGULATION_OUT		0x04
> +#define REGULATOR_EVENT_FAIL			0x08
> +#define REGULATOR_EVENT_OVER_TEMP		0x10
> +#define REGULATOR_EVENT_FORCE_DISABLE		0x20
> +#define REGULATOR_EVENT_VOLTAGE_CHANGE		0x40
> +#define REGULATOR_EVENT_DISABLE			0x80
> +#define REGULATOR_EVENT_PRE_VOLTAGE_CHANGE	0x100
> +#define REGULATOR_EVENT_ABORT_VOLTAGE_CHANGE	0x200
> +#define REGULATOR_EVENT_PRE_DISABLE		0x400
> +#define REGULATOR_EVENT_ABORT_DISABLE		0x800
> +#define REGULATOR_EVENT_ENABLE			0x1000

I'm not sure embedded the raw numbers in the UAPI like this for just one
driver is ideal - it might be better to do something string based,
though that would result in us ending up with a file per event which is
a bit noisy.

--USLdL0WA7M+Hr251
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTwiSIACgkQJNaLcl1U
h9B63AgAgiEcXKsVY1ELYCVzWS57lp/pKdjjCMYFrSkqNGTu1lwPcX3+2SGUTUra
MG7D4fPkR5bAU4jcL7lLVTuRBW92Jhe7XTrdvxYEpV4EjdkBMU8yho9s0d+xsFcH
gX5ralz/SW0ltpkXkm+TtRtZt6tEPt6WjMWkMNIIN2iic/N2WFaeXObqlgDHC5Ee
zv1aDFUMqrIH+huHmHcmsAjAm4lwC11MxOtpcPfxttgWLtWEksSb/gjyY5Re9myG
MdvubGo3B8joTNusNI6tCVldpmg18j9qdIAQMeNa1oNYkHOgmyuH3La07W15EGPb
t53qxGxs5FphgFNCDvqDPMtkvAJa5w==
=tS+Y
-----END PGP SIGNATURE-----

--USLdL0WA7M+Hr251--