Received: by 2002:a05:7412:3210:b0:e2:908c:2ebd with SMTP id eu16csp1013986rdb; Fri, 1 Sep 2023 10:07:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA9cvrUKcfUl2VFLAQbch0PrShSEOlq9hBDdnKkhm8JF06f3jZpgxUliQUShaZWtad998L X-Received: by 2002:a05:6a21:788e:b0:14c:c393:6af with SMTP id bf14-20020a056a21788e00b0014cc39306afmr4331839pzc.0.1693588043048; Fri, 01 Sep 2023 10:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693588043; cv=none; d=google.com; s=arc-20160816; b=wlhr+pNYrdTSshsIE+9Cz+yG+oLJXio3XP7IUbaeX90KOx9kgaHN8F9lSwqTgWVTwC rOdaDH70YjHvs9mz0W6r3N8NIqNPSQqJx7PqFSbdBZNIDRDXGidTZ5GkCssfq72QFmUp UN8/GICXAOFwDIzrmZCB2sc1eg3PpPnB5xO0/oHoFnqr5d3CekpLmS2D5yHCWUe5vL3D EZGgiaMPug2bB9xkv/66onA1W9bA9dHVh9CA+W+HMN8ftnFmcZtbytcS8fXZbxWRbmxF nZJYNX+5Dzlqfv42bBzAMoJBYx5hUNaR9kD4aNF1CklDzonhjgI5RlLsjZx4MUOspk5+ 9HgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8mBm/AaCjDuqbQVkzZnZqUxyQHMK/Avjk1VOZqOONP4=; fh=pM10WnAVvYqBN+jy48aBK9JS3PEiIy4ZJgAUKgI2Iik=; b=isy7PkjiJOrZr6rXKXbtLXHtVsVMuL57TJeqKdR74NufV/+0aJJHa+wkr1TtSmj79E hSGUlu4O81VSA/3o+cMQ59HVXCK5dFvDLkABHZcm4clXeWGCaUcjsnxHnNfD2VUWk8Az HwLtQ2BuAwwzCaf19QJxR8IBlYSo+zMvI1MJOoX8jScJMiEgyH/6SD2HB5hBGgF0/q4M 75S2jTQEyBKBIMcimW05zQ8h3GOu9D0rZr2ZSD6oqPP+QykLmoiR8qbOAaE/2KJ++9H4 dIbRk1gP3ITzXywsMKCxNqvM9z2XSFHnNlEMnaXu4K+d0JzjWIts/KXRQ7rqdLZDq1Yi pz1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r36-20020a635164000000b0056fbf85c743si3118517pgl.790.2023.09.01.10.07.06; Fri, 01 Sep 2023 10:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344325AbjIAN6P (ORCPT + 99 others); Fri, 1 Sep 2023 09:58:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbjIAN6O (ORCPT ); Fri, 1 Sep 2023 09:58:14 -0400 Received: from us-smtp-delivery-44.mimecast.com (unknown [207.211.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779E210EC for ; Fri, 1 Sep 2023 06:58:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-8dNE5ybnMmCyUz33TI3oRA-1; Fri, 01 Sep 2023 09:57:52 -0400 X-MC-Unique: 8dNE5ybnMmCyUz33TI3oRA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 010F91817903; Fri, 1 Sep 2023 13:57:47 +0000 (UTC) Received: from hog (unknown [10.45.224.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E15671460FF3; Fri, 1 Sep 2023 13:57:43 +0000 (UTC) Date: Fri, 1 Sep 2023 15:57:42 +0200 From: Sabrina Dubroca To: "Radu Pirea (OSS)" Cc: Radu Pirea , "atenart@kernel.org" , "andrew@lunn.ch" , "linux@armlinux.org.uk" , "hkallweit1@gmail.com" , "davem@davemloft.net" , Sebastian Tobuschat , "linux-kernel@vger.kernel.org" , "pabeni@redhat.com" , "richardcochran@gmail.com" , "edumazet@google.com" , "kuba@kernel.org" , "netdev@vger.kernel.org" Subject: Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag Message-ID: References: <20230824091615.191379-1-radu-nicolae.pirea@oss.nxp.com> <20230824091615.191379-6-radu-nicolae.pirea@oss.nxp.com> <5d42d6c9-2f0c-8913-49ec-50a25860c49f@oss.nxp.com> <518c11e9000f895fddb5b3dc4d5b2bf445cf320f.camel@nxp.com> <831bc700-a9a2-7eda-e97b-e1d54dc806f9@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <831bc700-a9a2-7eda-e97b-e1d54dc806f9@oss.nxp.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_RPBL,RDNS_NONE,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-09-01, 14:58:12 +0300, Radu Pirea (OSS) wrote: > On 01.09.2023 13:07, Sabrina Dubroca wrote: > > > (the interface was up before) > > > [root@alarm ~]# ip link add link end0 macsec0 type macsec encrypt on > > > offload phy > > > [root@alarm ~]# ip link set end0 down > > > [root@alarm ~]# ip macsec add macsec0 rx port 1 address > > > 00:01:be:be:ef:33 > > > RTNETLINK answers: Operation not supported > > > > Where does that EOPNOTSUPP come from? nxp_c45_mdo_add_rxsc from this > > version of the code can't return that, and macsec_add_rxsc also > > shouldn't at this point. > > This is the source of -EOPNOTSUPP > https://elixir.bootlin.com/linux/latest/source/drivers/net/macsec.c#L1928 Could you check which part of macsec_get_ops is failing? Since macsec_newlink with "offload phy" worked, macsec_check_offload shouldn't fail, so why does macsec_get_ops return NULL? real_dev->phydev was NULL'ed? -- Sabrina