Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141AbXKEQXj (ORCPT ); Mon, 5 Nov 2007 11:23:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752239AbXKEQXb (ORCPT ); Mon, 5 Nov 2007 11:23:31 -0500 Received: from moutng.kundenserver.de ([212.227.126.188]:57173 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbXKEQXa (ORCPT ); Mon, 5 Nov 2007 11:23:30 -0500 Subject: Re: [PATCH 34/54] Driver Core: add kobj_attribute handling From: Kay Sievers To: Cornelia Huck Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org In-Reply-To: <20071105134203.1c078136@gondolin.boeblingen.de.ibm.com> References: <20071102235758.GA9803@kroah.com> <1194047972-9850-34-git-send-email-gregkh@suse.de> <20071105134203.1c078136@gondolin.boeblingen.de.ibm.com> Content-Type: text/plain Date: Mon, 05 Nov 2007 17:23:32 +0100 Message-Id: <1194279812.6771.11.camel@lov.site> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/B+ZY4myOXbIA3m0hAaMOj8kifuIS/MZFrnk1 5A9F1If6Gfpfo4QP9X+xS8mgLQte0JmZRO5oSCZYp6GZHsOWuC SHYDl5xrH2UpZ3UKZFWouGdyxOm5J4q Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1685 Lines: 45 On Mon, 2007-11-05 at 13:42 +0100, Cornelia Huck wrote: > On Fri, 2 Nov 2007 16:59:12 -0700, > Greg Kroah-Hartman wrote: > > > From: Kay Sievers > > > > Add kobj_sysfs_ops to replace subsys_sysfs_ops. There is no > > need for special kset operations, we want to be able to use > > simple attribute operations at any kobject, not only ksets. > > > > The whole concept of any default sysfs attribute operations > > will go away with the upcoming removal of subsys_sysfs_ops. > > > > Signed-off-by: Kay Sievers > > Signed-off-by: Greg Kroah-Hartman > > --- > > include/linux/kobject.h | 10 ++++++++++ > > lib/kobject.c | 29 +++++++++++++++++++++++++++++ > > 2 files changed, 39 insertions(+), 0 deletions(-) > > How about adding some simple wrappers around the new kobj_attribute > structure? This makes the layering clearer. > +#define KOBJ_ATTR(_name,_mode,_show,_store) \ > + struct kobj_attribute kobj_attr_##_name = \ > + __ATTR(_name,_mode,_show,_store) That sounds fine. > +extern int __must_check kobject_create_file(struct kobject *, > > struct kobj_attribute *); > +extern void kobject_remove_file(struct kobject *,struct kobj_attribute *); That should usually be done by default attributes assigned to the ktype. Do you have a good use case, where people need to create such attributes individually instead? Kay - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/