Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp697246rdb; Sun, 3 Sep 2023 06:40:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFet6icyWbZVSECd0Mj0gt2yy/5zC/D0J0rAT5c1SIlsfJOHwQbdV1ZmiBFf6vRbsSr+fye X-Received: by 2002:a50:fc09:0:b0:523:3e5d:8aa2 with SMTP id i9-20020a50fc09000000b005233e5d8aa2mr5406894edr.14.1693748443129; Sun, 03 Sep 2023 06:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693748443; cv=none; d=google.com; s=arc-20160816; b=ohgrH4M01GpyzB7fRyqyGrNfAHT6U2pQqumwsBO1fs8y3CDvBzalQ4uR/QYZpHzHj+ gRMUv+1GrWNEWUUQMhn5V72TlCFtjfX5zhFP2AwtcnMNSG2tqJWonWC7UkjT6t3A6RNa 14C0pnN4DYBpYZ2Sh05fIPkX6gpOvMkfeUlAfpJqFsb8t2WVbvMehifr58hKNzPIg5Fc laYciAj89601yDxzpBFOk11VknU0qs4Qoa2Lq3RNWO+K3YvKW32K8Qaedhsn0dKUibLn /ekxz5wRO0s0q48+NGbADVEQT4SnQrjr8pKUq+SHrUKZGosEcBc7ECR4NcZBzpHqthNb WHeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=8OvwslTdct92vq6sqbYXAWCf6jJ8ftmJ4fOuPuRSaIY=; fh=BbWOEq5WfLqtMTYbZMjIEr+Nffa8jh/h0GbU7YBC3Z4=; b=pseie4ZWDNqrxc5+p90ycY02tISo3nypQZgUA5VGqdkttmKDQJ1AzfhwVXqVh6o3AY 997xL+p9GpP2IAfRxXfI+txPB4f10dCnJ3Ct3u96bHPyf5i8LyIi8oqtHSLOIjJnzB3G X7vI8ThhVl/3OARPikvCcZLcd0GxQwdw/UNZXSkrS3zA+F3Rqc7k11WfOcu/EfIkN/jg 2nFWhLjCGWfWcYPN58rjujwF/pFdBmhYQZojU4yt+mGEM86HfSW3LTizZGPcVuph47uX b37nls59HEcZfhE5JfXJRUOIlp5GLAut0D7Nhnmcn+Bk7w6fx7SBxEygHttHAfqKMjbw lk0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020aa7cd0b000000b0052596c88933si5211314edw.129.2023.09.03.06.40.17; Sun, 03 Sep 2023 06:40:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349770AbjIANhn (ORCPT + 99 others); Fri, 1 Sep 2023 09:37:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbjIANhl (ORCPT ); Fri, 1 Sep 2023 09:37:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5E5A6E77; Fri, 1 Sep 2023 06:37:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 920D3FEC; Fri, 1 Sep 2023 06:38:15 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ABB273F844; Fri, 1 Sep 2023 06:37:35 -0700 (PDT) From: James Clark To: linux-perf-users@vger.kernel.org Cc: James Clark , John Garry , Will Deacon , Mike Leach , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present Date: Fri, 1 Sep 2023 14:37:15 +0100 Message-Id: <20230901133716.677499-1-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit d927ef5004ef ("perf cs-etm: Add exception level consistency check"), the exception that was added to Perf will be triggered unless the following bugfix from OpenCSD is present: - _Version 1.2.1_: - __Bugfix__: ETM4x / ETE - output of context elements to client can in some circumstances be delayed until after subsequent atoms have been processed leading to incorrect memory decode access via the client callbacks. Fixed to flush context elements immediately they are committed. Rather than remove the assert and silently fail, just increase the minimum version requirement to avoid hard to debug issues and regressions. Signed-off-by: James Clark --- tools/build/feature/test-libopencsd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c index eb6303ff446e..4cfcef9da3e4 100644 --- a/tools/build/feature/test-libopencsd.c +++ b/tools/build/feature/test-libopencsd.c @@ -4,9 +4,9 @@ /* * Check OpenCSD library version is sufficient to provide required features */ -#define OCSD_MIN_VER ((1 << 16) | (1 << 8) | (1)) +#define OCSD_MIN_VER ((1 << 16) | (2 << 8) | (1)) #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER) -#error "OpenCSD >= 1.1.1 is required" +#error "OpenCSD >= 1.2.1 is required" #endif int main(void) -- 2.34.1