Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 13:48:02 -0700
From:   Zaid Alali <zaidal@os.amperecomputing.com>
To:     "Luck, Tony" <tony.luck@intel.com>
Cc:     Piyush Malgujar <pmalgujar@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
        "benjamin.cheatham@amd.com" <benjamin.cheatham@amd.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "jannadurai@marvell.com" <jannadurai@marvell.com>,
        "cchavva@marvell.com" <cchavva@marvell.com>
Subject: Re: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Message-ID: <ZPD8ggCD794f54VR@zaid-VirtualBox>
References: <20230504133224.2669-1-pmalgujar@marvell.com>
 <SJ1PR11MB6083A266C4A869FC9AAA5A9AFC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <SJ1PR11MB608326A6AC3FFE42699DDB40FC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SJ1PR11MB608326A6AC3FFE42699DDB40FC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nTJ1y+t1VmJSo4N7moXaYeo/zrKKLZnTd7o4NSutVSinn9fV+Pa4r3OimZnq?=
 =?us-ascii?Q?3agtbK04x9PN0Gsh44cMsJCrsekQjrcf1h2JhO4MUZdJeeIwoWZMOEdltuCL?=
 =?us-ascii?Q?p5FayQJ8ahmUCL0vNS43J9m/XluOb4wgM4UH28X0Wrrvlu3tnKBDL2AyCGt2?=
 =?us-ascii?Q?mspSy0+baUlgfik84MSaEqaf9u6vWcAkYMdKl1HmMOUUjULawE1xg7sSudgA?=
 =?us-ascii?Q?pA/x/69vy1PsKejfB2p0dv0JNVPel1NZCJVIl0+APM6I4bEgAJ2TG5Em6lhi?=
 =?us-ascii?Q?is3o2ed+xOwI7hXmrmjX5xFFSywSUnCb3BQEQrIOsmObKJhhBqarH23fZ5Km?=
 =?us-ascii?Q?3LsyMsMcZPqIH96XtvY8Kik6htrtD0YuAb9UxtuWMUnU4hEG/8s/01cKTbIh?=
 =?us-ascii?Q?FeFZ6ssbAQv21BwdUzcCbHvO/z8gmRu3EDM6g7evQhXlMGzAGK/zbfFdNuj/?=
 =?us-ascii?Q?50ACyUmzUdzmevAYDxlltZRAIGubgHMJpVD5/kmoUHWM/hbUxhbiU/RwO6Fn?=
 =?us-ascii?Q?vXYOIuHhMaQz90dmmQsRb3ovJuALNqeaAC6YX7K9NvX5Ms3Coy0gE1fPrA4w?=
 =?us-ascii?Q?WWrshnxsjPqUZenePpxpbdeimNcwIqNcbP1WLg6HLYeszkXZouN1BeiI3u9m?=
 =?us-ascii?Q?TYUjJneBBPUmuH33Ecd23bDV2eg6GlQO1jAmDv5YbusvkbX2FDxjlrQmXrdE?=
 =?us-ascii?Q?4k2Y4JPD3I30m56c5CDbzgLkv519Dqyt7W1ckuiLiTOjrf/tkA8rqJiv0dH4?=
 =?us-ascii?Q?7uIlmXDAcyl6lf1Vlz9WScyT9ddJjesuwB8qZN7HnXVsdRlLFL7QdYngfwMp?=
 =?us-ascii?Q?qFszqkFQ8eLcrJVEyxT7S43Q2LQ59mGUhQHFx8j4n8LlGV1+ROnrpKgdq0SR?=
 =?us-ascii?Q?ltbtIawWOfOtySzj9x3xwavYoLhB6Tsx8zbQ08r+O+xDuZWw+0jUFAYiAU6/?=
 =?us-ascii?Q?osyNvhcKD74RbMiFBI+U5Nr1KN3jNpWHqHAP2luqltIzJ69NR4pqn/CdfyAJ?=
 =?us-ascii?Q?znmdc7EGa8SbJYDLDKAEZh7WLRh5IQkuIe0kys5qTNPp1A0JlgwExfw7VtnG?=
 =?us-ascii?Q?tHP7gFgR9qLejTib5kqzM2aeVFqQ9eHdvD5IXZ1zJawIFcLE2ZsZjBGqxBew?=
 =?us-ascii?Q?bFdRiCaB0VqS/R444DVYbTm6hrFo/8un/X5XqVVkaiGWFFVz6qPKDGxkI9hH?=
 =?us-ascii?Q?3srSAxBalglqSK4uBMwWZOZZTjUL0S9P9P+vRhA5KSnvIbWPvt5suZGa3LYm?=
 =?us-ascii?Q?WDxy3wyleldgoYEbasCHoX7VGtAHPQD5ONRHs+FqZ7vzMucGsF3DFyYDF9k0?=
 =?us-ascii?Q?RwEWfog0mQ5Fgef0XBjIwlCSGcjBuZx0x/I/wAo7pG7667Lq+RkrXDKjX1Mu?=
 =?us-ascii?Q?oyMI3rhCqv6kc7nhkeHbk5BRHEpiOzs+OmlNxVaWfL+SKH+7q4/OXI2Wvq2b?=
 =?us-ascii?Q?h4ilsvfQh7p8o1QCMtvwoBLtpC3KpKvfpg3opRaJAmlHHmSZ1FV2Hg4JpdOr?=
 =?us-ascii?Q?KY0J+EME2eXRupxaAjxdqp8635RWd/VJo8pk1nDmKXnqelHEc/D3h/8x88J+?=
 =?us-ascii?Q?qGW91+GlVeZP4EBN083kZRNRZnxlIzfBUF6RNFpAEvxN2Lkfa3uB2xe4obnT?=
 =?us-ascii?Q?7lxR39mPY4HaCAetUiCbqcc=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b58b2d1-6d8e-48be-f9b4-08dbaa6393af
X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB5026.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 20:48:06.3065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xZ9iMJY3gB0npcqjqQEgqi/dIy0pHCDKb4oftsQ++vZZhbWk2vzzlBV9HBU/uHyNu+H8Rqj+PbuPZmt1f51cNG0pI35ENfrlRqufhsW5CfLG5ROt1mi+Q8FVDNJv4+TN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB7328
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 04, 2023 at 09:00:51PM +0000, Luck, Tony wrote:
> > +An error injection example::
> > +
> > +  # cd /sys/kernel/debug/apei/einj
> > +  # cat available_error_type         # See which errors can be injected
> > +  0x00000001 EINJV2 Processor Error
> > +  0x00000002 EINJV2 Memory Error
> > +  0x00000004 EINJV2 PCI Express Error
> > +  # echo 0x2 > error_type
> > +  # echo 0x5 > flags
> > +  # echo 0x12345000 > param1
> > +  # echo 0x2 > param5
> > +  # echo 1 > error_inject
> >
> > Is the expectation that platforms that implement EINJV2 will not include legacy
> > EINJ support?
> 
> I spoke to some BIOS folks here. They said that the ACPI 6.5 change is an
> extension to the action table with new opcodes for GET/SET when EINJV2
> is supported. The legacy actions are not deprecated. So platform firmware could
> support both old and new injection formats.
> 
> So I'm going to double down on this:
> 
> > Maybe it would be better to change the top-level directory to:
> >
> >	/sys/kernel/debug/apei/einjv2
I also think this is the best way to go to have EINJ and EINJv2 supported.
Is anyone working on implementing this? or should I give it a shot and try to
send a patch that separates the parent directory for EINJv2?
> 
> and say this isn't a "maybe". The EINJV2 interface files should go
> in a new directory. The old files should continue to work (assuming
> firmware still enumerates the old available types).
> 
> Simplifying the interface for EINJV2 in the new directory is an option.
> I think we should take it ... the "paramN" files that mean different
> things for different injection types were an evolution rather than a design.
> 
> -Tony
> 
> 
> 
>