Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1081247rdb; Mon, 4 Sep 2023 02:20:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7j9JRHt6NCvEBsfCnQ+n1rir71WxbGWb4atVUa63SzP0NhkAn+WeO9xz+JNtC42smleJV X-Received: by 2002:a05:6a00:234c:b0:68b:c1a2:abca with SMTP id j12-20020a056a00234c00b0068bc1a2abcamr7612111pfj.14.1693819212507; Mon, 04 Sep 2023 02:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693819212; cv=none; d=google.com; s=arc-20160816; b=BiMsP20P5PYIrX2/hOURhcW2tZq7D0dWGdglivGnADpt3Mjg3VYYoXu8gCBYfB9h+G FqtBAOLP0CxLfqouzdrhVrpjQOdSBrS/1j3qHPaAmxzKTe6VIcwXHSjOAGGw/IRxV1lK iDKMurZ5INOu+JIlbpLu4HIRLLmc95o7GMeWmlZi/OyUHloK2kKTb4la8X/ginaPzIxJ csXSSbuv4PEf3DmfLomLGnjXFQVx3gmbWgx0rdWMWuTZ8oNthrc2YWBapi1pLN06hi4b 6kz1dFEVpniTem3LU/qJdTMbNdwNoejUgDf0L+HOSyQk+xeTJTIOCjMjKvp8eUWV/scm EZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=tX20SMwtmkeuMgKZy1pEEIiYyOdUDOxjagl5qsmbdNw=; fh=JH2AOShRq2xSkvFkvb8ZjqpH0CgA8vHd2iLUollhS/g=; b=KttG3EWGThxscxnAMDI1ykwsb0UeOHKQeSjbeKTDBv0o2Mcc4MNZ0fGqcMBmUXoV9g zwZLWRm3R/LlXy3hGMvbplBrvrb6o2Ozeqmmb8eBxdQQJcjVD/GB3jAYDg4lFpVu75M7 NM6j5sPmv6qmiX/0cQ07BJDT/hs8LB+BuPW0rRLbCaI4Hv0RvpwXq32fZt2CfldK5j46 xxfK0y8lpd3Ac3vXA4cNoguQqrnsc8JoatQGdM9lJ+68+SUjjjBqIKxHC9tV5BwGNPmR OEdv5EEzFS66VbcQHwpNcn7IQNBM9udft3v+fFI84T0gi9ikxsGqCFPx/0Fi5WMJSDUB e7Qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z126-20020a633384000000b0056fed6cf408si7485610pgz.602.2023.09.04.02.19.56; Mon, 04 Sep 2023 02:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352310AbjIDHNA (ORCPT + 99 others); Mon, 4 Sep 2023 03:13:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbjIDHM6 (ORCPT ); Mon, 4 Sep 2023 03:12:58 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A55A0; Mon, 4 Sep 2023 00:12:55 -0700 (PDT) Received: from dggpemm500012.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RfKXW4dffzTlT1; Mon, 4 Sep 2023 15:10:19 +0800 (CST) Received: from [10.67.120.108] (10.67.120.108) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 4 Sep 2023 15:12:53 +0800 Message-ID: <8b8f4005-3058-d41b-2f40-18584c69e2fd@huawei.com> Date: Mon, 4 Sep 2023 15:12:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v4 0/5] Introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Content-Language: en-CA To: Andy Shevchenko CC: Luo Jiaxing , , , , , , , , , , , , , , References: <1605164864-58944-1-git-send-email-luojiaxing@huawei.com> <14010198-c128-4960-0d56-5ee28f4da53f@huawei.com> From: yangxingui In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.108] X-ClientProxiedBy: dggpemm500006.china.huawei.com (7.185.36.236) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/9/1 16:54, Andy Shevchenko wrote: > On Fri, Sep 01, 2023 at 03:11:38PM +0800, yangxingui wrote: >> On 2023/9/1 2:19, Andy Shevchenko wrote: >>> On Thu, Nov 12, 2020 at 03:07:38PM +0800, Luo Jiaxing wrote: >>>> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute >>>> for read-only file, but we found many of drivers also want a helper macro >>>> for read-write file too. >>>> >>>> So we add this macro to help decrease code duplication. >>> >>> Are you going to pursue this one? >> Hi Andy >> >> Jiaxing has left his job, and his email is invalid. > > OK! Anybody else to continue this to be finished? I'll continue to do this for him. Thank you for your attention and advice. We'll apply it only to the scsi subsystem first. Thanks. Xingui >