Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Sep 2023 13:16:44 +0200
From:   Jean Delvare <jdelvare@suse.de>
To:     Ilpo =?UTF-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/14] I2C: sis5595: Do PCI error checks on own line
Message-ID: <20230901131644.7337daf8@endymion.delvare>
In-Reply-To: <20230824132832.78705-10-ilpo.jarvinen@linux.intel.com>
References: <20230824132832.78705-1-ilpo.jarvinen@linux.intel.com>
        <20230824132832.78705-10-ilpo.jarvinen@linux.intel.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 24 Aug 2023 16:28:27 +0300, Ilpo J=C3=A4rvinen wrote:
> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>=20
> No functional changes intended.
>=20
> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/i2c/busses/i2c-sis5595.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-sis5595.c b/drivers/i2c/busses/i2c-si=
s5595.c
> index c793a5c14cda..486f1e9dfb74 100644
> --- a/drivers/i2c/busses/i2c-sis5595.c
> +++ b/drivers/i2c/busses/i2c-sis5595.c
> @@ -175,11 +175,11 @@ static int sis5595_setup(struct pci_dev *SIS5595_de=
v)
> =20
>  	if (force_addr) {
>  		dev_info(&SIS5595_dev->dev, "forcing ISA address 0x%04X\n", sis5595_ba=
se);
> -		if (pci_write_config_word(SIS5595_dev, ACPI_BASE, sis5595_base)
> -		    !=3D PCIBIOS_SUCCESSFUL)
> +		retval =3D pci_write_config_word(SIS5595_dev, ACPI_BASE, sis5595_base);
> +		if (retval !=3D PCIBIOS_SUCCESSFUL)
>  			goto error;
> -		if (pci_read_config_word(SIS5595_dev, ACPI_BASE, &a)
> -		    !=3D PCIBIOS_SUCCESSFUL)
> +		retval =3D pci_read_config_word(SIS5595_dev, ACPI_BASE, &a);
> +		if (retval !=3D PCIBIOS_SUCCESSFUL)
>  			goto error;
>  		if ((a & ~(SIS5595_EXTENT - 1)) !=3D sis5595_base) {
>  			/* doesn't work for some chips! */
> @@ -188,16 +188,16 @@ static int sis5595_setup(struct pci_dev *SIS5595_de=
v)
>  		}
>  	}
> =20
> -	if (pci_read_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, &val)
> -	    !=3D PCIBIOS_SUCCESSFUL)
> +	retval =3D pci_read_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, &val);
> +	if (retval !=3D PCIBIOS_SUCCESSFUL)
>  		goto error;
>  	if ((val & 0x80) =3D=3D 0) {
>  		dev_info(&SIS5595_dev->dev, "enabling ACPI\n");
> -		if (pci_write_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, val | 0x80)
> -		    !=3D PCIBIOS_SUCCESSFUL)
> +		retval =3D pci_write_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, val =
| 0x80);
> +		if (retval !=3D PCIBIOS_SUCCESSFUL)
>  			goto error;
> -		if (pci_read_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, &val)
> -		    !=3D PCIBIOS_SUCCESSFUL)
> +		retval =3D pci_read_config_byte(SIS5595_dev, SIS5595_ENABLE_REG, &val);
> +		if (retval !=3D PCIBIOS_SUCCESSFUL)
>  			goto error;
>  		if ((val & 0x80) =3D=3D 0) {
>  			/* doesn't work for some chips? */

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
--=20
Jean Delvare
SUSE L3 Support