Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 2 Sep 2023 18:38:11 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     linux-kernel@vger.kernel.org,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Shuah Khan <shuah@kernel.org>, rcu@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] rcu/torture: Improve badness extraction from console logs
Message-ID: <8f55aa64-dfea-4a1a-a7d4-a2335ec07150@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20230831012257.1189964-1-joel@joelfernandes.org>
 <b292cca4-d451-4371-ae2e-9417e0079e84@paulmck-laptop>
 <CAEXW_YRa0Gd2Gt8LagAyOp_8VwT+ra3N4+DBquUNn_Xmo8o7eg@mail.gmail.com>
 <7bd77573-ded1-432e-8008-4c1cbe1b9eb9@paulmck-laptop>
 <CAEXW_YTzP90zs8z4UFC52fd_KMkpBba6ujBNnDM5Z6exskJ6tg@mail.gmail.com>
 <e0977773-de90-42bb-a67d-dc16d24764a3@paulmck-laptop>
 <CAEXW_YSukJ_SSvy731iF9WZ5N9cycHsfzdz+8MKA4Va+1+FW4A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEXW_YSukJ_SSvy731iF9WZ5N9cycHsfzdz+8MKA4Va+1+FW4A@mail.gmail.com>
Precedence: bulk

On Sat, Sep 02, 2023 at 08:10:13PM -0400, Joel Fernandes wrote:
> On Sat, Sep 2, 2023 at 3:24 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> [...]
> > > > Either way, what I don't want is many megabytes of splats from console.log
> > > > duplicated into console.log.diags, especially in those (admittedly sad)
> > > > cases where the console.log file is the largest file in the results
> > > > directory.  Are you really going to be reading carefully after (say)
> > > > the fifth splat?  ;-)
> > >
> > > I could limit it to just the first 5, with the existing unlimited
> > > summary at the top.
> >
> > How about limiting the existing summary to (say) 10 lines?  I do not
> > recall every caring about more than that.  The only reason that I did
> > not ever limit it myself is that the summary is unlikely to be more than
> > a few percent of the full console.log.
> >
> > > Let me know if that works or does not work for you. :-)
> >
> > I do believe that we might be converging.  ;-)
> 
> Ok, so 10 lines of summary (similar to existing), and 10 detailed
> splats below that :-).  If that's not Ok, let me know. Otherwise I
> will send the new patch soon. Thanks!

That works!

						Thanx, Paul