Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1401574rdb; Mon, 4 Sep 2023 12:37:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGpo7/RtpM0Oh4L5JEAjCwaG5rxt1uIAvR0xI1EOF1FS6sZk/zEIxr3NpTXaCdXqih0VS6 X-Received: by 2002:a17:906:314e:b0:9a2:5bf:8b14 with SMTP id e14-20020a170906314e00b009a205bf8b14mr7056766eje.22.1693856277910; Mon, 04 Sep 2023 12:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693856277; cv=none; d=google.com; s=arc-20160816; b=YKnXohUPzRkYF7cJk4CEiYjhI7OSdZyMXTT+jd2UXTwJzQHlshQNTnLGND/jIA/Xil KgGxCq+85k5SZE/OAQr8edZHIEW9kWACzvOG1s2NWRtHciRC2059J0ege5/Q8qo7Nr6J 6BB8lewdaItt3XTfRBuKFIDFXcGcFshPju7ALZ9LM1QnBCkGQoSfrKYC3OFmnCsQHbtk qeyrwilPuzuU//dX5fMCN2qhyTQ8Oe4H3UyzOCSsMM6l4MLKE7FIZVAfDJt40g1TAVw1 9gPg1/ixKvUFGGP+x1vWY88vcoxCiVhpL7XWyRr2lZvxu2NZfNkNBBjVzKI43ZyfL93i CcXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YlKP/GeVa3SmFQKNMgY7h2SBsYTPP28/9AknJq2JUvk=; fh=+YlS+3bgiBAEkNSyYLZDuKHkrOncfg8Vu7nMjlZe7ig=; b=eJLy/ayqthy2gEjSUXS9D/04XMRa3LId5LsbPW3JYgh3fh1Waj1/hHT8pFJQHjfFdU wlGkS/dK+o7rPYjLDn+Xdv9tfhtWATLku62s3SazbDi4aYscKSPnc3llf7oDhpoaVDcP YT/bujAKi4+kMF8ume+OzSDF0AYgREFM80sKP7IdzLU2Wk/IWlRPdotvacK7TFtE/0fI 47RBIOAphcOzATLl7ffdtg1vCO2Xl28r4iFoWvPha2Wxf6a7MQWqodHf6Np/EiagdCL9 ycRhxx7O57U9kTWwLmnUxS2D7I+hugedYPKryRjVNH2v9ptvBMykyVdo/ZNimvq/Mivb /niA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id se22-20020a170906ce5600b009a5d14bea7csi6592873ejb.599.2023.09.04.12.37.29; Mon, 04 Sep 2023 12:37:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235103AbjICIRm (ORCPT + 99 others); Sun, 3 Sep 2023 04:17:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233751AbjICIRm (ORCPT ); Sun, 3 Sep 2023 04:17:42 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9163A189 for ; Sun, 3 Sep 2023 01:17:35 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3838H9TT027927; Sun, 3 Sep 2023 10:17:09 +0200 Date: Sun, 3 Sep 2023 10:17:09 +0200 From: Willy Tarreau To: Ammar Faizi Cc: Alviro Iskandar Setiawan , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , David Laight , Nicholas Rosenberg , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()` Message-ID: References: <20230902133505.2176434-1-ammarfaizi2@gnuweeb.org> <20230902133505.2176434-3-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, T_SPF_HELO_TEMPERROR,T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote: > On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote: > > nit: Be consistent. Use \n\t for the memset too. > > Good catch, I'll fix that in v4 revision. Ammar, I'm overall fine with your series. I can as well add the missing \t to your patch while merging it, or wait for your v4, just let me know. Thanks, Willy