Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 4 Sep 2023 15:31:49 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc:     lee@kernel.org, alexandre.torgue@foss.st.com,
        linux-iio@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] counter: fix, improvements and stm32 timer events
 support
Message-ID: <ZPYwpdQUWp0V43FU@ishi>
References: <20230829134029.2402868-1-fabrice.gasnier@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CVt1obDrKjorrKCm"
Content-Disposition: inline
In-Reply-To: <20230829134029.2402868-1-fabrice.gasnier@foss.st.com>
Precedence: bulk


--CVt1obDrKjorrKCm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 29, 2023 at 03:40:21PM +0200, Fabrice Gasnier wrote:
> This series combines some fix and improvements to the counter interface,
> found while stm32 timer counter driver developements.
> It also introduces a new tool that can be used for testing.
>=20
> Then, it improves the stm32 timer counter driver by introducing new signa=
ls,
> e.g. counting frequency, and missing channels.
> It also adds support for interrupt based events using the chrdev interfac=
e.
> Two event types are added in this series: overflows and capture.
>=20
> Up to now, stm32 timer counter driver focused mainly on quadrature
> encoder feature. With this series, all timer instances can be enabled
> for simple counting (with overflow and capture events).
>=20
> Fabrice Gasnier (8):
>   counter: chrdev: fix getting array extensions
>   counter: chrdev: remove a typo in header file comment
>   tools/counter: add a flexible watch events tool
>   mfd: stm32-timers: add support for interrupts
>   counter: stm32-timer-cnt: rename quadrature signal
>   counter: stm32-timer-cnt: introduce clock signal
>   counter: stm32-timer-cnt: populate capture channels and check encoder
>   counter: stm32-timer-cnt: add support for events
>=20
>  drivers/counter/counter-chrdev.c     |   4 +-
>  drivers/counter/stm32-timer-cnt.c    | 585 ++++++++++++++++++++++++++-
>  drivers/mfd/stm32-timers.c           |  46 +++
>  include/linux/mfd/stm32-timers.h     |  26 ++
>  include/uapi/linux/counter.h         |   2 +-
>  tools/counter/Build                  |   1 +
>  tools/counter/Makefile               |   8 +-
>  tools/counter/counter_watch_events.c | 348 ++++++++++++++++
>  8 files changed, 998 insertions(+), 22 deletions(-)
>  create mode 100644 tools/counter/counter_watch_events.c
>=20
> --=20
> 2.25.1
>=20

Hi Fabrice,

There are a number of precursor changes in this series that are somewhat
independent, so I'll be taking some patches separately to simplify
things and review this patchset a little at a time.

Thanks,

William Breathitt Gray

--CVt1obDrKjorrKCm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZPYwpQAKCRC1SFbKvhIj
K3XrAQCnJXaTzbk3S1ZQotXMnidjHAeezrMw2IP6V2HkdsTgeQD+IwiZkXrVD0n/
fcBlRITVdLaPEwU4OA/RUVBqbs83ZQw=
=/BPa
-----END PGP SIGNATURE-----

--CVt1obDrKjorrKCm--