Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 04 Sep 2023 08:24:51 +0100
Message-ID: <86sf7ue6yk.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Fang Xiang <fangxiang3@xiaomi.com>
Cc:     <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: Mark GIC as non-shareable by OF property
In-Reply-To: <20230904020431.27057-1-fangxiang3@xiaomi.com>
References: <20230904020431.27057-1-fangxiang3@xiaomi.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 04 Sep 2023 03:04:31 +0100,
Fang Xiang <fangxiang3@xiaomi.com> wrote:
>=20
> GIC600/GIC700 integration in some platforms does not support the
> sharability feature. Commit a8707f553884 ("irqchip/gic-v3: Add
> Rockchip 3588001 erratum workaround") added flags to indicate the
> integration design error, but the quirk is just applied with
> RK3588/RK3588S and GIC600.
>=20
> The property are named "force-non-shareable" to be vendor agnostic,
> since apparently similar integration design errors exist in other
> platforms and they can reuse the same property in their GIC ITS
> device-node.

No. If this is a problem, this must be dealt with in the following
manner:

- a standard property, which is documented in the ITS binding
- an equivalent ACPI property, equally documented
- separate instances of the property for the core GIC and the ITS
  (because the RDs are *not* defined at the ITS level)

>=20
> Signed-off-by: Fang Xiang <fangxiang3@xiaomi.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>=20
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v=
3-its.c
> index e0c2b10d154d..2e92eac1e5f3 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -5055,6 +5055,16 @@ static int __init its_compute_its_list_map(struct =
resource *res,
>         return its_number;
>  }
>=20
> +static void its_of_update_shareability(struct its_node *its)
> +{
> +       if (!fwnode_property_present(its->fwnode_handle,
> +                               "force-non-shareable"))
> +               return;
> +
> +       its->flags |=3D ITS_FLAGS_FORCE_NON_SHAREABLE;
> +       gic_rdists->flags |=3D RDIST_FLAGS_FORCE_NON_SHAREABLE;

There is no reason why we should conflate the two, other than your
implementation being monolithic.

> +}
> +
>  static int __init its_probe_one(struct resource *res,
>                                 struct fwnode_handle *handle, int numa_no=
de)
>  {
> @@ -5130,6 +5140,7 @@ static int __init its_probe_one(struct resource *re=
s,
>         its->msi_domain_flags =3D IRQ_DOMAIN_FLAG_ISOLATED_MSI;
>=20
>         its_enable_quirks(its);
> +       its_of_update_shareability(its);

As mentioned above, we need a mechanism that works across firmware implemen=
tations.

>=20
>         err =3D its_alloc_tables(its);
>         if (err)
> --
> 2.34.1
>=20
> #/******=C2=B1=C2=BE=C3=93=C3=8A=C2=BC=C3=BE=C2=BC=C2=B0=C3=86=C3=A4=C2=
=B8=C2=BD=C2=BC=C3=BE=C2=BA=C2=AC=C3=93=C3=90=C3=90=C2=A1=C3=83=C3=97=C2=B9=
=C2=AB=C3=8B=C2=BE=C2=B5=C3=84=C2=B1=C2=A3=C3=83=C3=9C=C3=90=C3=85=C3=8F=C2=
=A2=C2=A3=C2=AC=C2=BD=C3=B6=C3=8F=C3=9E=C3=93=C3=9A=C2=B7=C2=A2=C3=8B=C3=8D=
=C2=B8=C3=B8=C3=89=C3=8F=C3=83=C3=A6=C2=B5=C3=98=C3=96=C2=B7=C3=96=C3=90=C3=
=81=C3=90=C2=B3=C3=B6=C2=B5=C3=84=C2=B8=C3=B6=C3=88=C3=8B=C2=BB=C3=B2=C3=88=
=C2=BA=C3=97=C3=A9=C2=A1=C2=A3=C2=BD=C3=BB=C3=96=C2=B9=C3=88=C3=8E=C2=BA=C3=
=8E=C3=86=C3=A4=C3=8B=C3=BB=C3=88=C3=8B=C3=92=C3=94=C3=88=C3=8E=C2=BA=C3=8E=
=C3=90=C3=8E=C3=8A=C2=BD=C3=8A=C2=B9=C3=93=C3=83=C2=A3=C2=A8=C2=B0=C3=BC=C3=
=80=C2=A8=C2=B5=C2=AB=C2=B2=C2=BB=C3=8F=C3=9E=C3=93=C3=9A=C3=88=C2=AB=C2=B2=
=C2=BF=C2=BB=C3=B2=C2=B2=C2=BF=C2=B7=C3=96=C2=B5=C3=98=C3=90=C2=B9=C3=82=C2=
=B6=C2=A1=C2=A2=C2=B8=C2=B4=C3=96=C3=86=C2=A1=C2=A2=C2=BB=C3=B2=C3=89=C2=A2=
=C2=B7=C2=A2=C2=A3=C2=A9=C2=B1=C2=BE=C3=93=C3=8A=C2=BC=C3=BE=C3=96=C3=90=C2=
=B5=C3=84=C3=90=C3=85=C3=8F=C2=A2=C2=A1=C2=A3=C3=88=C3=A7=C2=B9=C3=BB=C3=84=
=C3=BA=C2=B4=C3=AD=C3=8A=C3=95=C3=81=C3=8B=C2=B1=C2=BE=C3=93=C3=8A=C2=BC=C3=
=BE=C2=A3=C2=AC=C3=87=C3=AB=C3=84=C3=BA=C3=81=C2=A2=C2=BC=C2=B4=C2=B5=C3=A7=
=C2=BB=C2=B0=C2=BB=C3=B2=C3=93=C3=8A=C2=BC=C3=BE=C3=8D=C2=A8=C3=96=C2=AA=C2=
=B7=C2=A2=C2=BC=C3=BE=C3=88=C3=8B=C2=B2=C2=A2=C3=89=C2=BE=C2=B3=C3=BD=C2=B1=
=C2=BE=C3=93=C3=8A=C2=BC=C3=BE=C2=A3=C2=A1 This e-mail and its attachments =
contain confidential information from XIAOMI, which is intended only for th=
e person or entity whose address is listed above. Any use of the informatio=
n contained herein in any way (including, but not limited to, total or part=
ial disclosure, reproduction, or dissemination) by persons other than the i=
ntended recipient(s) is prohibited. If you receive this e-mail in error, pl=
ease notify the sender by phone or email immediately and delete it!******/#
\

Please fix your email setup.

	M.

--=20
Without deviation from the norm, progress is not possible.