Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91dc19a5-ea7f-1abf-1c35-5a9582036b83@kernel.org>
Date:   Sat, 2 Sep 2023 11:54:32 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
To:     Pawel Zmarzly <pzmarzly@meta.com>, Niklas.Cassel@wdc.com
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <ZPIyxg+iSWa+W93Q@x1-carbon>
 <20230901200220.3891806-1-pzmarzly@meta.com>
Content-Language: en-US
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20230901200220.3891806-1-pzmarzly@meta.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/2/23 05:02, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> 
> Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>

This does not apply cleanly on the fo-6.6 branch. Can you rebase your patch
please and make sure it applies to libata tree for-6.6 branch ?

> ---
> V1 -> V2: Fixed formatting.
> V2 -> V3: Added missing Signed off line. Sorry, this is my
> first time upstreaming.
> 
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 175b2a9dc000..116f5fd6e3f7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
> +	{ "Micron_1100_*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
> +						ATA_HORKAGE_ZERO_AFTER_TRIM, },
> 
>  	/* devices that don't properly handle TRIM commands */
>  	{ "SuperSSpeed S238*",		NULL,	ATA_HORKAGE_NOTRIM, },
> --
> 2.39.3

-- 
Damien Le Moal
Western Digital Research