Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761166AbXKERVt (ORCPT ); Mon, 5 Nov 2007 12:21:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758929AbXKERMr (ORCPT ); Mon, 5 Nov 2007 12:12:47 -0500 Received: from mail.suse.de ([195.135.220.2]:48123 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758924AbXKERMq (ORCPT ); Mon, 5 Nov 2007 12:12:46 -0500 Date: Mon, 5 Nov 2007 09:05:41 -0800 From: Greg KH To: Cornelia Huck Cc: linux-kernel@vger.kernel.org, Kay Sievers , Michael Holzheu , Heiko Carstens , Volker Sameske Subject: Re: [PATCH 46/54] kset: convert s390 ipl.c to use kset_create Message-ID: <20071105170541.GB12843@suse.de> References: <20071102235758.GA9803@kroah.com> <1194047972-9850-46-git-send-email-gregkh@suse.de> <20071105112731.288a8334@gondolin.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071105112731.288a8334@gondolin.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 42 On Mon, Nov 05, 2007 at 11:27:31AM +0100, Cornelia Huck wrote: > On Fri, 2 Nov 2007 16:59:24 -0700, > Greg Kroah-Hartman wrote: > > > Dynamically create the kset instead of declaring it statically. > > This makes the kobject attributes now work properly that I broke in the > > previous patch. > > > > Cc: Kay Sievers > > Cc: Michael Holzheu > > Cc: Heiko Carstens > > Cc: Volker Sameske > > Cc: Cornelia Huck > > Signed-off-by: Greg Kroah-Hartman > > --- > > arch/s390/kernel/ipl.c | 75 +++++++++++++++++++++++++----------------------- > > 1 files changed, 39 insertions(+), 36 deletions(-) > > It seems you also need this (not yet booted): > > Fix the following warnings: > > arch/s390/kernel/ipl.c: In function 'reipl_init': > arch/s390/kernel/ipl.c:981: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type > arch/s390/kernel/ipl.c: In function 'dump_init': > arch/s390/kernel/ipl.c:1070: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type > arch/s390/kernel/ipl.c: In function 'shutdown_actions_init': > arch/s390/kernel/ipl.c:1094: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type > > Signed-off-by: Cornelia Huck Thanks, but this should go with the previous kobject_attribute cleanup patch, not the kset patch. I've merged it in now. thanks for the review and patch. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/