Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 4 Sep 2023 16:36:35 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc:     lee@kernel.org, alexandre.torgue@foss.st.com,
        linux-iio@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] counter: chrdev: fix getting array extensions
Message-ID: <ZPY/033Z0dDi5zJB@ishi>
References: <20230829134029.2402868-1-fabrice.gasnier@foss.st.com>
 <20230829134029.2402868-2-fabrice.gasnier@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+/TWu6qhPiWTQHjU"
Content-Disposition: inline
In-Reply-To: <20230829134029.2402868-2-fabrice.gasnier@foss.st.com>
Precedence: bulk


--+/TWu6qhPiWTQHjU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 29, 2023 at 03:40:22PM +0200, Fabrice Gasnier wrote:
> When trying to watch a component array extension, and the array isn't the
> first extended element, it fails as the type comparison is always done on
> the 1st element. Fix it by indexing the 'ext' array.
>=20
> Example on a dummy struct counter_comp:
> static struct counter_comp dummy[] =3D {
> 	COUNTER_COMP_DIRECTION(..),
> 	...,
> 	COUNTER_COMP_ARRAY_CAPTURE(...),
> };
> static struct counter_count dummy_cnt =3D {
> 	...
> 	.ext =3D dummy,
> 	.num_ext =3D ARRAY_SIZE(dummy),
> }
>=20
> Currently, counter_get_ext() returns -EINVAL when trying to add a watch
> event on one of the capture array element in such example.
>=20
> Fixes: d2011be1e22f ("counter: Introduce the COUNTER_COMP_ARRAY component=
 type")
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Applied to counter-fixes as commit 3170256d7bc1.

Thanks,

William Breathitt Gray

--+/TWu6qhPiWTQHjU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZPY/0wAKCRC1SFbKvhIj
K9hLAQDqPhZP1YNYM6y5RMNfkbjoeJho9SeB13EQIOIjwx/59gEAlFxHbZqubcku
dRYQXe4YDx4kLA6cbnrZfx8lg4Phugk=
=RCOJ
-----END PGP SIGNATURE-----

--+/TWu6qhPiWTQHjU--