Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "pmalani@chromium.org" <pmalani@chromium.org>,
        "chrome-platform@lists.linux.dev" <chrome-platform@lists.linux.dev>
CC:     "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "bleung@chromium.org" <bleung@chromium.org>
Subject: RE: [PATCH v2 4/5] platform/chrome: cros_ec_typec: Add Displayport
 Alternatemode 2.1 Support
Thread-Topic: [PATCH v2 4/5] platform/chrome: cros_ec_typec: Add Displayport
 Alternatemode 2.1 Support
Thread-Index: AQHZ25LloUpSuUlFqEqhUDSvXhP6krAEhr0g
Date:   Thu, 31 Aug 2023 15:24:34 +0000
Message-ID: <MWHPR11MB0048D87555CACAC4DC7DF1DFA9E5A@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20230830223950.1360865-1-utkarsh.h.patel@intel.com>
 <20230830223950.1360865-5-utkarsh.h.patel@intel.com>
In-Reply-To: <20230830223950.1360865-5-utkarsh.h.patel@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MFagmfKylMI7nW7eeZyM3Tv0wr5M049lSKjWU31F9jvwzuK/gPMuEAFxXNSu?=
 =?us-ascii?Q?5jLxF2tAMNCsr4wYFeyCBi5fRY9aKVZ7rFmSK2MSgdl0bvrkFMwVE5nx71XA?=
 =?us-ascii?Q?SbhV8IC7Wp8sFGmztelDk8x2z8SZBhXprZjeWovHd1SZHQUW7Sg5iskNp6ZA?=
 =?us-ascii?Q?vQJWV1Q29gx1PyDzyBkf28ErwZF7a+WZgO5iLhTcvNKSgZEGCepWnS84q9jT?=
 =?us-ascii?Q?BEPMyFfVZ8TIzWlyAbg/Iqd536Vj0zH1Ekahz+pavxWZiZp12+FSSFDtznDJ?=
 =?us-ascii?Q?gkh8eu6ofCxKpNeDVRV2xPlBofOqWkGQkrojggownesz9EOGDHR/bvJDfiAX?=
 =?us-ascii?Q?h6r3e/lJkLgBH2t9xTJj89B0xxR6r2jpn1rhuuEVBF93HygZDvdKU4fU3d1g?=
 =?us-ascii?Q?ap6VMZxkAFIf+akyc/0pUaMYiqRLBUmUq/9oN7mT3UtQ/ksP0saJpAcFyalq?=
 =?us-ascii?Q?P5zai5sr1IiyeuswllsXpewFhKfVgwkN4uQ0JmskATiijfg2quaEI5YFFTlH?=
 =?us-ascii?Q?7NsVPKlpzTy1aRlX/wRimWWyy1/cMh2rk0e0EkEgyRWOXXTZ3JSBPAc1tRaE?=
 =?us-ascii?Q?4zBS6skiwlWUgqqk+jOzk/fmmPc1tNro2ofRzT2sX2ex3YDf9IbQvfKFPkrT?=
 =?us-ascii?Q?bn7coZ/lCjJc+Bq3Ux004TKKFEULZgLB8S1NxI1N9ASL8xIGfV/ew2oPGdDX?=
 =?us-ascii?Q?UzV5fynz6JoYWRtF6JCrAhBaSe9yHAQE93sWicAkwfKuU4rUpJoauWkXuVzB?=
 =?us-ascii?Q?w1m2C595xMcSqGQlZ/XXiV5f1aWM7+BWA8eNMVT5KNyML5n7DdpTP5iwvPsQ?=
 =?us-ascii?Q?7GRodw2J008RexdaSQEuskca6BI0opRNxUl2DUCo7QL0qji4fd0OkHuEkRx1?=
 =?us-ascii?Q?9CKPw4ZkpYtgjQDmisLnqwk6aIsae/Mh26gQ5ochzvQfY69cJ1U8AV3FoN2U?=
 =?us-ascii?Q?0g5phzExpfqivS2aeKWAA3jVIUrzwcdChrChSUoAbA9YrAViWNFoWMYeKuRH?=
 =?us-ascii?Q?fDRuJK5OPpeJGwEg6DrnwpDS//jYYY5fj6GJQgTUgOptOBhQBRGixCpMQ9vD?=
 =?us-ascii?Q?DLqtqpqzBEXysW1NgxuhWEIPLXxbtaLcFg37xNQVEq4C5AjI6ZeDPzv7BMLt?=
 =?us-ascii?Q?wXbCJoXZLrHoxywYBnmne3m2nkAw3YdkVQFYbVBZuvgo0KMNz6euZMKvlvBD?=
 =?us-ascii?Q?9Ut6Iq+OmhHQrC7Hf3Hj7vr8p3OnW3gp+waSz8HVlLY4sxVEbgdAQdJ5qKyM?=
 =?us-ascii?Q?QkFsFU97uq/RarwCkxgxzZ4Ms+QwOt5dz3PSBvZ8/XWn197XO1gifQMxgM21?=
 =?us-ascii?Q?REwkRW7od7kLzAKKEJx9KZRWbuvmm3PCnv6O7HQWMQdahJQIH/6GoDLco9mZ?=
 =?us-ascii?Q?ENJQAT2zvDkIgSzCos52ZhFefdgYw0PgNOjvBpItEiwPKoc8C/SLqzs+wM0X?=
 =?us-ascii?Q?mJoo9yuUgGECQTeVmFEv5xU7Oksu5G63C0lvgtlIZQMi8UnPt7M1L90lLqYj?=
 =?us-ascii?Q?y37zAWbNbAJrbAcU0SqierAZ2bjaihaXDI5SZLDNcCHbq7lm1C4MNHWBOr8Z?=
 =?us-ascii?Q?oRRWgNyI6+tJbxH52sDNh8kOLN9Y2J1mlqNheg8C?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0048.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c6ff42d-f7e3-4584-a7e2-08dbaa366194
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2023 15:24:34.4662
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g8C4UikZENvfCVE6hDJS93MX+nnUCrA0Xp49pQh9lC6Fi1JTvF2/I9QZg2M61m5DOwewxjLJ1jZdYL6TPYdeR+vXg4MPrFU1Nf9sr8WEPIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5517
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

>  drivers/platform/chrome/cros_ec_typec.c | 31
> +++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>=20
> diff --git a/drivers/platform/chrome/cros_ec_typec.c
> b/drivers/platform/chrome/cros_ec_typec.c
> index d0b4d3fc40ed..8372f13052a8 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -492,6 +492,8 @@ static int cros_typec_enable_dp(struct
> cros_typec_data *typec,  {
>  	struct cros_typec_port *port =3D typec->ports[port_num];
>  	struct typec_displayport_data dp_data;
> +	u32 cable_tbt_vdo;
> +	u32 cable_dp_vdo;
>  	int ret;
>=20
>  	if (typec->pd_ctrl_ver < 2) {
> @@ -524,6 +526,35 @@ static int cros_typec_enable_dp(struct
> cros_typec_data *typec,
>  	port->state.data =3D &dp_data;
>  	port->state.mode =3D TYPEC_MODAL_STATE(ffs(pd_ctrl->dp_mode));
>=20
> +	/* Get cable VDO for cables with DPSID to check DPAM2.1 is
> supported */
> +	cable_dp_vdo =3D cros_typec_get_cable_vdo(port,
> USB_TYPEC_DP_SID);
> +
> +	/**
> +	 * Get cable VDO for thunderbolt cables and cables with DPSID but
> does not
> +	 * support DPAM2.1.
> +	 */
> +	cable_tbt_vdo =3D cros_typec_get_cable_vdo(port,
> USB_TYPEC_TBT_SID);
> +
> +	if (cable_dp_vdo & DP_CAP_DPAM_VERSION) {
> +		dp_data.conf |=3D cable_dp_vdo;
> +	} else if (cable_tbt_vdo) {
> +		u8 cable_speed =3D TBT_CABLE_SPEED(cable_tbt_vdo);
> +
> +		dp_data.conf |=3D cable_speed <<
> DP_CONF_SIGNALLING_SHIFT;
> +
> +		/* Cable Type */
> +		if (cable_tbt_vdo & TBT_CABLE_OPTICAL)
> +			dp_data.conf |=3D DP_CONF_CABLE_TYPE_OPTICAL <<
> DP_CONF_CABLE_TYPE_SHIFT;
> +		else if (cable_tbt_vdo & TBT_CABLE_RETIMER)
> +			dp_data.conf |=3D DP_CONF_CABLE_TYPE_RE_TIMER <<
> DP_CONF_CABLE_TYPE_SHIFT;
> +		else if (cable_tbt_vdo & TBT_CABLE_ACTIVE_PASSIVE)
> +			dp_data.conf |=3D DP_CONF_CABLE_TYPE_RE_DRIVER
> << DP_CONF_CABLE_TYPE_SHIFT;
> +	} else if (PD_IDH_PTYPE(port->c_identity.id_header) =3D=3D
> IDH_PTYPE_PCABLE) {
> +		u8 cable_speed =3D VDO_CABLE_SPEED(port-
> >c_identity.vdo[0]);

I have wrong macro name here, will correct it in next version.
It should be VDO_TYPEC_CABLE_SPEED.=20

Sincerely,
Utkarsh Patel.=20