Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1928807rdb; Tue, 5 Sep 2023 09:04:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5mI41NIsBuy3f+jb3NRB/3bp9mBSS4xwtkRVswF4LBzsP85s4iW5QfDHOjvqVUATYCogL X-Received: by 2002:a17:906:8a62:b0:9a1:e994:3440 with SMTP id hy2-20020a1709068a6200b009a1e9943440mr228233ejc.4.1693929885462; Tue, 05 Sep 2023 09:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693929885; cv=none; d=google.com; s=arc-20160816; b=xsX+CyJImb++XHUn/8hqtMy7FQPFy02Lf7JN9PDZVeWTpe2N2xgcDmKQDUZZMtmESz b0iA/GjyUEm9Jgi2ulGN785ZkZyfhJfLG2OJaB2nWAjb+zah0z/HROojyR14Yo8w0QE/ +uBHRSGdch0KRdCTDxks5s84XReAHrP9QqjsxcpVjbhvTEo4kPcMbF3hK2WfitOTpxii b/ixdfAzWGfSHQKDf3w5EaJKxSJOwOBhk419iwaJmwwoTJzES1jU9YdaM5k8n64/cf++ gn3bHCKJ9rlIdqcvZ2YkiJO1ipJnIHt5HclDrO5RtprQIYAprO7pLIZ+6YPJFvIkRGEM a6VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=13ISOQmjx05VjbB4/LjvOfUXEICpUD8DNbWrqKbJ0yo=; fh=qQD0FstLZEu714gLZz0jHLosuxV5VO/S/y8yR6P5H/c=; b=F6CKHhzviNlLhMkJ+hdZH/8Y58iYD771hkq5W6nzK1sn+sauhYn3WoK4D25tgSgSCb EDRBHNHiJAKc+ILBklZukKVnV8jrjt3iFWe1C50b5qXsU1Cwi8P2CDZZwBLJd69vGbYi Q/kByaC/euibZeKTaLOZwLDUCXqTvfSamkXIRG9jbIhOv77qubABcYyJc4BSCyqnUUJe 06DR5evFyLUAcH/CvVaQV22SGA2DP/xQYyyQHIxQ4ohj8v2lcv2VqGBfSENabXLZp3xV cIXD7lQbtbvgGyhmQjG+pM1Ibh6GlE1squvRXjJ7kU8033WWvxJsE1pq/AzGR1FBQYLg XZ7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id le18-20020a170906ae1200b0099a1f78de48si7671528ejb.638.2023.09.05.09.04.41; Tue, 05 Sep 2023 09:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbjIDUBc (ORCPT + 15 others); Mon, 4 Sep 2023 16:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233265AbjIDUB1 (ORCPT ); Mon, 4 Sep 2023 16:01:27 -0400 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E438ACFD for ; Mon, 4 Sep 2023 13:01:15 -0700 (PDT) X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.2.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 50758200054; Mon, 4 Sep 2023 20:01:14 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id 32BAF21DC6; Mon, 4 Sep 2023 21:59:43 +0200 (CEST) Date: Mon, 4 Sep 2023 21:59:43 +0200 From: Dominik Brodowski To: lizhe Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/tcic.c : remove the "&" of the second parameter Message-ID: References: <20221221063749.82666-1-sensor1010@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221063749.82666-1-sensor1010@163.com> X-TUID: byX+ZeQzSWX1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Tue, Dec 20, 2022 at 10:37:49PM -0800 schrieb lizhe: > The second parameter is the entry address of the function, > Not required& > > Signed-off-by: lizhe > --- > drivers/pcmcia/tcic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pcmcia/tcic.c b/drivers/pcmcia/tcic.c > index 1a0e3f098759..5ef888688e23 100644 > --- a/drivers/pcmcia/tcic.c > +++ b/drivers/pcmcia/tcic.c > @@ -435,7 +435,7 @@ static int __init init_tcic(void) > } > > /* Set up polling */ > - timer_setup(&poll_timer, &tcic_timer, 0); > + timer_setup(&poll_timer, tcic_timer, 0); > > /* Build interrupt mask */ > printk(KERN_CONT ", %d sockets\n", sockets); > -- > 2.17.1 > Applied to pcmcia-next, thanks! Dominik