Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230831043228.1194256-1-jmattson@google.com> <c71199d1-93b3-ff51-f571-34d60cd36c1c@intel.com>
In-Reply-To: <c71199d1-93b3-ff51-f571-34d60cd36c1c@intel.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Thu, 31 Aug 2023 12:28:27 -0700
Message-ID: <CALMp9eRT3+amVEFvX1vzeqDoVP7Fz6a_xUorKYK63+QeyaO4kA@mail.gmail.com>
Subject: Re: [PATCH] x86/fpu/xstate: Fix PKRU covert channel
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Tavis Ormandy <taviso@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Kyle Huey <me@kylehuey.com>,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Feng Tang <feng.tang@intel.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 31, 2023 at 12:12=E2=80=AFPM Dave Hansen <dave.hansen@intel.com=
> wrote:
>
> On 8/30/23 21:32, Jim Mattson wrote:
> > When XCR0[9] is set, PKRU can be read and written from userspace with
> > XSAVE and XRSTOR, even when CR4.PKE is clear.
> >
> > Clear XCR0[9] when protection keys are disabled.
> >
> > Reported-by: Tavis Ormandy <taviso@google.com>
> > Signed-off-by: Jim Mattson <jmattson@google.com>
>
> Is there any way to trigger this other than "nopku" on the command-line?

Or by configuration option:

CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS=3Dn

> I'm not sure how scary this particular covert channel is, but it does
> make sense to do this even if it's only to avoid wasting XSAVE space on
> a feature that nobody can use (for things other than covert channels).
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>