Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87cd3ac9-7ade-1d57-bd78-da78ce0d2cdd@intel.com>
Date:   Fri, 1 Sep 2023 16:46:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v8 6/8] x86/resctrl: Move default group file creation to
 mount
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <paulmck@kernel.org>, <akpm@linux-foundation.org>,
        <quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
        <damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
        <peterz@infradead.org>, <jpoimboe@kernel.org>,
        <pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
        <pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
        <daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
        <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>,
        <christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>
References: <20230821233048.434531-1-babu.moger@amd.com>
 <20230821233048.434531-7-babu.moger@amd.com>
 <d6af932b-4e1b-103f-77f0-d91c2f3fd75a@intel.com>
 <f33d96b1-ef46-f1fd-94e3-52baab2fd29f@intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <f33d96b1-ef46-f1fd-94e3-52baab2fd29f@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHIvSFJtd0xnNVlEeVlIcnRXeFMvMFVKamtrbkRhT1E4QWw0RWdVSzlOUFdL?=
 =?utf-8?B?Sm1hbC81TXg5ekNqdkZwU1VBRXlhenAwczk3MERYT0FaYUtUdmcvUUcrbEVB?=
 =?utf-8?B?MVUyWllTS3V0VzVhRllzTjl5eCtmWXo4OEpwaTEvRVoyTkVDZlVMYTRBaXNx?=
 =?utf-8?B?KzJuVkpSZHJsZ3lCWUt1UUVocGNyLzlRT3JjWjZtZmxSKy9HZWlxb04wckh1?=
 =?utf-8?B?Y3dmWEJ5emRBSHB4R0NnU0kzYXNYWVlFTG5pM09ZZ0ZjUXBkSERtdERFT1FN?=
 =?utf-8?B?eEdTSDRyM0RweG1PRWxWM1YyS3h0SWtlWTZCU2t6eHA2NDl5dDBqbmF3Qm4v?=
 =?utf-8?B?bTBJR2NkSGw4MVlUekhCVUJ5ejcyY1JZeWNRRUl4RklibHcwUi9wVGptdEhh?=
 =?utf-8?B?aGFFdkVTNCtiZTBGM2ludTRBZkNnVkxxcGg2QWZhRGN3U3E2T1d4ZG42RUtK?=
 =?utf-8?B?WVJ1bTY0Y1JEWVdOQWdHTzd3QXUxbUg5a0Mzd0ZsMHQxMWN6c0VYZktNZHVu?=
 =?utf-8?B?S2pGV2FlbHVNd1dPMVlDeDdnSXRyL0JFNUNFQzR1NTZzbWIwUStOc0VpTUdC?=
 =?utf-8?B?SVdRSnBvNmlwQ3dCbzR4R0tpQnNEV1hpNnhjemlWMzI4WG5pVFBJR3lxOWc0?=
 =?utf-8?B?VEU3SzZzV3BCT281NTcyd0ZMbGIwUERYWTdJcFlXRDVsSkxRakJNdnhFR0hP?=
 =?utf-8?B?S2NvQmtQSElpejRqNlhqbSsyVEQ3T0p3UG9NTDdIbis1dWxqUVJNV3FFZEFr?=
 =?utf-8?B?THZ3ZklEM1MyVE9jeXZzZXVGa3ZZaU1HakVZdFVQcUkvTVhjVlQvTmpUL1kx?=
 =?utf-8?B?cEx6Y2YxWC9KbGhyNWVkbW9Gb29DRmdYU1h3cnRQbGxYTHkyQ2lpcEVNMDhT?=
 =?utf-8?B?RmpDZ01iV2NNaGU3SWVINmdPdXlCZE03NXRKNzNqeXU0L2F2d0xJZzBLdkcw?=
 =?utf-8?B?U0hrUlB2SW8xNmNnbTE3VWJHNEFpQTFEMHh4Uk9sMDloVDgwZHM4K0xtTXht?=
 =?utf-8?B?VU1ESlBBdklOTGZSYWpJcW1nL0FVMElNUG93WkEycGJnK2g4cmNDQXVsL0Jm?=
 =?utf-8?B?UGI3V1d0MWl6K3RQVWs4Z1AyY3loY3ZBSUx5dFdtQTZYSWxsMmhZaTlYdXI2?=
 =?utf-8?B?NGdtd0RGM2t0SGl3STJhT2cyai9hb2R4U1VTaUs3QWl4NkM4ekFZajZ1dXVT?=
 =?utf-8?B?dDAyOWhGaXJqWVFYb04wMGk4VkNoQ0NNSDU5SCtaWUtyQ1dISHZyMjNjQml5?=
 =?utf-8?B?N0JPWWRtRlBzNFVZMmZyYXVmV29welBiUE9xdk81NnJIL25ETW1wSmNIQkdp?=
 =?utf-8?B?aHZlUlpIT3FMbXlqZVJzMDU0Z2txUnl6NDVET1R5RnpDU3djVFU2Um5XeVZU?=
 =?utf-8?B?OWtXWldHUTZUb3BjSDBuNkMwS2x6UG1kR0NSYlZGRHdTdkMySHJGRmFqVFhh?=
 =?utf-8?B?TjVTZVB0dDFMWjljYkl1VVVuUWhlUXZ4K3pMMTRlL05hU2xTbnZTL1djUEtM?=
 =?utf-8?B?YTl5WHIrMlZwci9LWlVNcnh0VDFONFc0R2VFZEh2WDVWQ0ZUZGxQODd5dDA5?=
 =?utf-8?B?TmpZeVQ4c1drakJiaEFUVXN3bTRZVERkcHB5QXpiRTBZTHFWZWwrb2lkYUdF?=
 =?utf-8?B?NXY0NEk4Y252b21lMStDK0lCOTM4SWwxVGMxWDFOQUM0aXg3NjVEMVA3T09q?=
 =?utf-8?B?OGFvU2dBZ0RoRXNXQVNlc2c1aFdmMFhMWllrRFIvSHlIVXJXd1NVTkhYa1BQ?=
 =?utf-8?B?UnJ6TjVTeTdFN0R5WVZlYUpDVXBrdUJDMkpYWmdaSHRLaXV0aG9rcWF0Tmo3?=
 =?utf-8?B?dWlmODc1YXVhamZQMFB1L3M1K0JMM01NVkg3ZW1kR3V6YW8rQndRZDB0Ym1k?=
 =?utf-8?B?Sm5NM3VxUTVIMkN3QUN6N2xScDdNVUE5UkdpOVNKNk4vRnhsY29xaElKM2NW?=
 =?utf-8?B?TDQvSGpMYjFUa0k1U0s1Szd2ZHhNakZndFhrSGwwZmlWQWVGUFlQSjFObFM4?=
 =?utf-8?B?bVY2U0RMQ05EQWdtb2FSSkdVRVBBTmVmb2lZeURjc29pNWhUUk9zTWR1VFRr?=
 =?utf-8?B?VUJUTTNGc1RSSmpsejVHd1lnNW42Z0h1Rk5uZ1FwbFAvNU9aS3Y5eVUySHl0?=
 =?utf-8?Q?FLJYdoHgnBd27AghHNi2NAxSf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 844da112-42d2-440b-eef5-08dbab459808
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 23:45:59.6645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QPlYPd8s7CQG04kswqdT7Po2uC4R6h4j5b/lTtpstpyFfV/JMu87DW9HUAsnAqwSxrgofE3q2RlFdza4rcnTGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Reinette,

On 9/1/23 16:36, Reinette Chatre wrote:
> Hi Fenghua,
> 
> On 9/1/2023 4:21 PM, Fenghua Yu wrote:
>> On 8/21/23 16:30, Babu Moger wrote:
>>> The default resource group and its files are created during kernel
>>> init time. Upcoming changes will make some resctrl files optional
>>> based on a mount parameter. If optional files are to be added to the
>>> default group based on the mount option, then each new file needs to
>>> be created separately and call kernfs_activate() again.
>>>
>>> Create all files of the default resource group during resctrl
>>> mount, destroyed during unmount, to avoid scattering resctrl
>>> file addition across two separate code flows.
>>>
>>> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
>>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>>> ---
>>>    arch/x86/kernel/cpu/resctrl/internal.h |  2 +
>>>    arch/x86/kernel/cpu/resctrl/rdtgroup.c | 55 +++++++++++++++-----------
>>>    2 files changed, 33 insertions(+), 24 deletions(-)
>>>
>>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
>>> index b09e7abd1299..44ad98f8c7af 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>>> @@ -611,5 +611,7 @@ void rdt_domain_reconfigure_cdp(struct rdt_resource *r);
>>>    void __init thread_throttle_mode_init(void);
>>>    void __init mbm_config_rftype_init(const char *config);
>>>    void rdt_staged_configs_clear(void);
>>> +int rdtgroup_setup_root(struct rdt_fs_context *ctx);
>>> +void rdtgroup_destroy_root(void);
>>
>> These two functions are called only in rdtgroup.c. Why are they exposed here?
>>
> 
> Could you please take a look at the email thread [1] that
> discusses this? We reached a compromise but would appreciate
> if you have any guidance on the right solution.

Yes, putting the static declarations earlier in rdtgroup.c is right AFAICT.

> 
> Reinette
> 
> [1] https://lore.kernel.org/lkml/972db626-1d74-679d-72f2-3e122f95c314@intel.com/
> 

Thanks.

-Fenghua