Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1930613rdb; Tue, 5 Sep 2023 09:06:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9ckPgQ7QcXiuFJPu5pWaXrt1MSpDA98O9a+iv5zf6oPwRkPMjrtJn8Rrlg+TKusHSUzw4 X-Received: by 2002:a17:907:7784:b0:9a1:ec69:23ec with SMTP id ky4-20020a170907778400b009a1ec6923ecmr213691ejc.17.1693929994691; Tue, 05 Sep 2023 09:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693929994; cv=none; d=google.com; s=arc-20160816; b=IzMGkkM5ktuET35ZK3ddYFhASJU6e0GRmY6akeeNtI6gQ8tn6l/9uHWL7s0YDr11TJ M9EPl44Ttl0vs667s/KjnV2bMZhA5dsyLecay9JzcrhNbNPtLp3an98NqI4XomtHL1sA mNlu6FnxpPy6ixs1W865WQdutQTd+S7+leNqmqT3vD8ILu2l5uC5aRMHi97sQOCuaID0 Aqqw6BngDQkKbDBrjP2isL7Qcl31ND2rhvOSrV0l5zRfV/0J8cphJId8j3rtcv9ntHOs gagpwrI1vOtA7LasAvacWM/Q5SRXaayfKxjHGi2cPGvGa8csxwJfikCOHQyWSg5Gk5vp AmTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GasDrvc6W3jC0nPuH+NLVlgYduZUFueUAVu7PupFXWg=; fh=2IA/b0Eh1SwIjPNRLgdMPwZ/Q9hLzZIwIAQ7ypua1pI=; b=P26ErqfDkh51httYhd86T4eZB0ne5DRa8lLlU8bbJHd4Yp/gPv1Vu6Xh0N3n98EIU6 z599aT/JFwvgJcZ8xVaHgLiFQGiJ8BoMp7I/U/9oM1He4oaEYy9ZLpO05K8MYFUgN5gV zS5++Ectrm1WZWgK1Fxc92wWwGqDEE3pu2KDx+bev4uWOqvhnSRdJA4s8VvyL6gwzuBg GiBMhMSVUnPCCRRpRhCIXPKIUC7RLPQQTd7Dj1mc8qKTpiYHJnt2zrq7Zak5VwWYkn29 iiAr4+pXVJN71+VqX6lEVQ7RPsofqbApg/BKGRb0WFysTTvopKJrMrHcbr8N1LA0wkNK 3fMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="uWkk4/92"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g24-20020a170906395800b009a5ce391397si7195570eje.367.2023.09.05.09.06.30; Tue, 05 Sep 2023 09:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="uWkk4/92"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235187AbjIBW66 (ORCPT + 12 others); Sat, 2 Sep 2023 18:58:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjIBW65 (ORCPT ); Sat, 2 Sep 2023 18:58:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD66ACF6; Sat, 2 Sep 2023 15:58:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 861BCB808BB; Sat, 2 Sep 2023 22:58:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD5DBC433C7; Sat, 2 Sep 2023 22:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1693695532; bh=Pc7GpWIHklekXAoIIEgvXTBTXk0POLNq+rx6i3iVkpk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uWkk4/925oGsoUT/g2nfGusbL8Se07i/a4cb8oypyPMgWKTz1VKBLf34/LqJCxEM2 eQf44uz/MUwsaZPVMCDL3/y/oCeZePc/HgtNCGU8tQlQQEt2fWNZ3jdhQQSueCyhV/ VL+4t/bm5/BaCWpPLvOwKFrMUeTkTvA3O85omhwg= Date: Sat, 2 Sep 2023 15:58:50 -0700 From: Andrew Morton To: Damian Tometzki Cc: Aleksa Sarai , Shuah Khan , Jeff Xu , Kees Cook , Daniel Verkamp , Christian Brauner , Dominique Martinet , stable@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 3/5] memfd: improve userspace warnings for missing exec-related flags Message-Id: <20230902155850.ca1d32c16862cbe54ebd36ef@linux-foundation.org> In-Reply-To: References: <20230814-memfd-vm-noexec-uapi-fixes-v2-0-7ff9e3e10ba6@cyphar.com> <20230814-memfd-vm-noexec-uapi-fixes-v2-3-7ff9e3e10ba6@cyphar.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Sep 2023 07:13:45 +0200 Damian Tometzki wrote: > > if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) { > > - pr_warn_once( > > + pr_info_ratelimited( > > "%s[%d]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set\n", > > current->comm, task_pid_nr(current)); > > } > > > > -- > > 2.41.0 > > > Hello Sarai, > > i got a lot of messages in dmesg with this. DMESG is unuseable with > this. > [ 1390.349462] __do_sys_memfd_create: 5 callbacks suppressed > [ 1390.349468] pipewire-pulse[2930]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set > [ 1390.350106] pipewire[2712]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set OK, thanks, I'll revert this. Spamming everyone even harder isn't a good way to get developers to fix their stuff.