Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <CY5PR12MB64558C413B3D8A60AA5C202DC6E4A@CY5PR12MB6455.namprd12.prod.outlook.com>
Date:   Fri, 1 Sep 2023 23:33:06 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] powerpc/powernv: use appropiate error code
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Immad Mir <mirimmad17@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" 
        <linuxppc-dev@lists.ozlabs.org>,
        open list <linux-kernel@vger.kernel.org>
References: <CY5PR12MB64550ACC0B90FDD120D21E47C6E4A@CY5PR12MB6455.namprd12.prod.outlook.com>
 <fdb8d83d-84ce-76d6-db9a-bb232492170c@csgroup.eu>
From:   Immad Mir <mirimmad@outlook.com>
In-Reply-To: <fdb8d83d-84ce-76d6-db9a-bb232492170c@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY5PR12MB6455:EE_|SN7PR12MB6957:EE_
X-MS-Office365-Filtering-Correlation-Id: 7b6e0aad-2ab5-4ad9-cbe3-08dbab15b882
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vD9Nb4stEFRZ4r64IHCzwIuk0R4lBL/GWKGMqH9iWi2j7CVgrKWrXjXo9y2XImi1b07MFzb5oLJW3iXeGBmDhHnLCdWQvB30U4T/KNwLGBJVLHygYmyzwvGFAnxx3Ioy3xYokoFuzjWmr4EL3aUgaCwtGXk5SmVF0KEyZKLimB7UF13JXlf1PraRHbRmZHYMCugWjxapoU3aqZrpE9uw4uxxFG3pUQA0bDBSNxTdcF1jB5gZomAea6MIaqV/WjSqXOACea1yfDrho0Q/LGQXj1VNp+aLV2tjIuPSByLKoQBj71bvyPMnD1Kowp++iyCbk/6aguJMYr37dG8BcToyzrU7OS1plm3o7RjkD2tEPUZeBR9TjsyNBPdln603v/YrcivWxqUlIDGZxSPBOhEJdPvx2Q72DJ3ykGwHps8m2bu2KGgAMruIDzm28KqbdTnvMfqVOWoFEaaKwjG6vKLnIuSumRNfFm6dEmKH1x+5VitkNCrBvWu5btbK00wMVfQP4oYd4hJ06TxgppjhANHMZ9wPBSvd7bX7Ng43GpPNB6Y+USFefWtAv6rshErYR37o
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0F0dWdBOHBrelNCUHFDSEZpQzJFR2NBdXk5UlZCSWtaS0h4azNiRHpvMTk2?=
 =?utf-8?B?Q1lxVFVCQmg3VDdYVlBudFQzQi9zN0NJOERTb0lBSk0xWmF4aURubHM0dWNx?=
 =?utf-8?B?R052ZnhqTXMzOG00QnZJK1VCODkvQ0llaUhTbnl5Umw5Uy9HZjNwTEpGOWZZ?=
 =?utf-8?B?cElWYWpPQUYwbFUvejQ1TXZHZStBM2EreGFoMmN2SWJ5WGJqQ2N3UktBanlV?=
 =?utf-8?B?OFhNM3VUTEVvQm9ra1phVk1TQnp3OEdid3dVa3lUUGtwZHppZHpXOVk1YVVN?=
 =?utf-8?B?Y29oZlk0VXBFSmR0Y05hVTNnWU5ocHpKSjEzMmw4T0dUWEE4cHJOeE04L3la?=
 =?utf-8?B?SUUyOUJLWHlMYzFmZytZbndBdEJLT3M1VjQraERYMGFDWlplTm5oNUVQdDdh?=
 =?utf-8?B?c0czQ3hwMWllTUUvd1lPamdwUGJyc1U2aExjRTZJOHR1M2tRUVlPY3hQZXNh?=
 =?utf-8?B?VzNnUHVUckJ2cGtDSWQ1UWVFbU5BTlJkaEZ0NkxKQy9CZVBtU01INzNUNXhy?=
 =?utf-8?B?WGFGYko1YnBIa3FwMWNJa3hXSlZ5UXdoam9FaW1tV0JPeFpaV3Y1U1k2ZmQv?=
 =?utf-8?B?dlZXTE5ycm5CeVVha2dVK1VSWCthRGR2MVh3RWpKSTZPOWNmTTNKZTJ0TFZG?=
 =?utf-8?B?QnZIZy9kcGVwRHZHZ1J2Y3RIVzRqcmwzSHIvRWk1UDNVVkdnV0pMSjVkT2RM?=
 =?utf-8?B?ZXpESEwxM2FSSVQ0eWt5d3NSbkdxdGhGcXF4bXViekRrL2xUbTZibTYxQUhI?=
 =?utf-8?B?YWxOclRnM1JwaERBZTkvUzc0N21Uemc1Y04wei8rejZwcmlueFVYWTk4d09M?=
 =?utf-8?B?d0xsT2ZDWVVJRUl1QUVJMytBcWMxWENvOTEyQXpYSVJDSTZnZFk4VmViSjFl?=
 =?utf-8?B?QVppK2tWOU11UjIrdGtzNE5YRHZtN0p2RmRYdUFCMjBFTVRIT0RlSjFhekR4?=
 =?utf-8?B?MHRUemFldEQ4UUQrdWVVZVpwcHNMOVlLN2lkdEYvNXNWRDRnWndQN2MzYnZP?=
 =?utf-8?B?ZlRvUDNoRTZjREhhdXFLblhsKzc3QmkvWElCeDNBNVNwbnlVWlM2MklORkFU?=
 =?utf-8?B?dXJhTmwrazJBeGFWZWpnOXFRaGU2eW5KQlVyOEtxU3hrajZGM2ZuRnEyTHgx?=
 =?utf-8?B?SVJhOWZKejVGaWZoZ3dWa0JWc0wyWVV2bEZqRVpJeEtmZlZyUWxkQlgwVDFI?=
 =?utf-8?B?NUEvY0dCa2NTaEVQUHdMaGJyblN2dVYwN0E0MWc0QkhCT1lvWkVOUW5xcm5a?=
 =?utf-8?B?VkdnZURhZEo5TzJ4UmZkRlNUUm84c2ttR01tMEE1aEMrQURDNXY2S1daNWJ2?=
 =?utf-8?B?cFNHU2MxUS9pbHUyRTVKcFNBR3dyWDEwRlNDWmRLUlRZRDUwOWJJeGoxSlFl?=
 =?utf-8?B?NCtITmZQdWUxamNPRUlCSVVMbjZkeXZETXBMWm4xa1JYSmhaamF1MmRyejVB?=
 =?utf-8?B?STdEUlh3YUpBWFh5NU1nZEhla2NITkJBbWVGR1ZKbXIxMFlWWnZuUkVaN21P?=
 =?utf-8?B?dHMvdFE4TGlqS1hkNEFmZ0JOWW1mRS9yQlBLVjIrMnBwdlplaGRJTEllQzdW?=
 =?utf-8?B?c0UvQWRDZy9GZmUxcTRLSFJXTUQvVHZadEhWVC9HR2ZaWk9uODcyTWFlRGxL?=
 =?utf-8?B?dHpucndjN1NDRkFVY1h6d1JtQ0tRU3BjL3BBcis3Rm1YM3R6TEQwellUWDBp?=
 =?utf-8?B?djloSVVEMzc3ancvOWloT0FITU1OQUVMWVNPRlRvVUJzN016bEhHcHBBPT0=?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b6e0aad-2ab5-4ad9-cbe3-08dbab15b882
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6455.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 18:03:18.3581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6957
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_MUA_MOZILLA,
        FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01/09/23 11:10 pm, Christophe Leroy wrote:
>
> Le 01/09/2023 à 19:19, mirimmad@outlook.com a écrit :
>> [Vous ne recevez pas souvent de courriers de mirimmad@outlook.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> From: Immad Mir <mirimmad17@gmail.com>
>>
>> -1 is not a valid error code. This patch replaces it with -EPERM.
> Can you explain how it will work ?
> In scom_debug_init() rc is built by oring the value returned by
> scom_debug_init_one().
> What will be the result when oring some valid values with -EPERM ?
> It was working well with -1 because when you or -1 with anything you get
> -1 as result. But with your change I don't think it will work.


if EPERM is not always necessarily equal to 1, we can put a check in 
scom_debug_init before returning rc. If it is less than 1 (because AFAIK 
or-ring with negative number results back into the same negative number) 
we set rc equal to -1.

Immad.

>
> Christophe
>
>> Signed-off-by: Immad Mir <mirimmad17@gmail.com>
>> ---
>>    arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c
>> index 262cd6fac..ce4b089dd 100644
>> --- a/arch/powerpc/platforms/powernv/opal-xscom.c
>> +++ b/arch/powerpc/platforms/powernv/opal-xscom.c
>> @@ -171,7 +171,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn,
>>           if (IS_ERR(dir)) {
>>                   kfree(ent->path.data);
>>                   kfree(ent);
>> -               return -1;
>> +               return -EPERM;
>>           }
>>
>>           debugfs_create_blob("devspec", 0400, dir, &ent->path);
>> @@ -191,7 +191,7 @@ static int scom_debug_init(void)
>>
>>           root = debugfs_create_dir("scom", arch_debugfs_dir);
>>           if (IS_ERR(root))
>> -               return -1;
>> +               return -EPERM;
>>
>>           rc = 0;
>>           for_each_node_with_property(dn, "scom-controller") {
>> --
>> 2.40.0
>>