Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c2affcc9-468f-bf4c-a080-65b31e05a83f@linux.intel.com>
Date:   Thu, 31 Aug 2023 14:28:00 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v1 0/3] perf list/debug output fixes
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Rob Herring <robh@kernel.org>,
        James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230831071421.2201358-1-irogers@google.com>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20230831071421.2201358-1-irogers@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-08-31 3:14 a.m., Ian Rogers wrote:
> Fix a long standing parse_events_term cloning bug so that the bad
> display of terms can be fixed and the code somewhat more intuitive:
> https://lore.kernel.org/lkml/20230830070753.1821629-2-irogers@google.com/
> 

Tested-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

> Fix a bug caused by the rename of 'cpu' to 'default_core' in perf list.
> 
> Add more documentation, increase type safety and fix some related bugs
> where terms weren't initialized properly.
> 
> Ian Rogers (3):
>   perf list: Don't print Unit for default_core
>   perf parse-events: Name the two term enums
>   perf parse-events: Fix propagation of term's no_value when cloning
> 
>  tools/perf/builtin-list.c      |   2 +-
>  tools/perf/util/parse-events.c | 203 +++++++++++++++++++++++----------
>  tools/perf/util/parse-events.h |  60 +++++++---
>  tools/perf/util/parse-events.l |   2 +-
>  tools/perf/util/parse-events.y |  27 +++--
>  tools/perf/util/pmu.c          |   2 +-
>  6 files changed, 207 insertions(+), 89 deletions(-)
>