Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 10:51:00 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-fbdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
        Rob Clark <robdclark@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: Update fbdev source file paths
Message-ID: <ZPBUdJwZzvYYrNei@phenom.ffwll.local>
Mail-Followup-To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        linux-fbdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
        Rob Clark <robdclark@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230829200253.1473891-1-j.neuschaefer@gmx.net>
 <d9a02d20-8b59-cbdd-d054-eac14f9771d2@suse.de>
 <ZPA26xdbTRdfuveS@probook>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZPA26xdbTRdfuveS@probook>
Precedence: bulk

On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neusch?fer wrote:
> On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote:
> > Hi
> > 
> > Am 29.08.23 um 22:02 schrieb Jonathan Neusch?fer:
> > > The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and
> > > fbcmap.c were moved to drivers/video/fbdev, and subsequently to
> > > drivers/video/fbdev/core, in the commits listed below.
> > > 
> > > Reported by kalekale in #kernel (Libera IRC).
> > > 
> > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
> > > Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory")
> > > Signed-off-by: Jonathan Neusch?fer <j.neuschaefer@gmx.net>
> > 
> > IMHO these comments might just be removed.
> 
> I think it's nice to have some sort of visual separation between groups
> of functions in fb.h, which these comments provide at the moment.
> Therefore I'm currently leaning towards my patch as it is, but I'm
> willing to have my mind changed and do a v2 which just removes the
> comments.

Just the filename without the full path maybe? That's enough to find the
right file, and it's also better at highlighting the actual important part
of the comment since the path is very redundant.
-Sima

> 
> 
> Thanks
> 
> > 
> > Best regards
> > Thomas
> > 
> > > ---
> > >   include/linux/fb.h | 12 ++++++------
> > >   1 file changed, 6 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/include/linux/fb.h b/include/linux/fb.h
> > > index ce7d588edc3e6..3cda5b9f2469b 100644
> > > --- a/include/linux/fb.h
> > > +++ b/include/linux/fb.h
> > > @@ -592,7 +592,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
> > >   	__FB_DEFAULT_SYS_OPS_DRAW, \
> > >   	__FB_DEFAULT_SYS_OPS_MMAP
> > > 
> > > -/* drivers/video/fbmem.c */
> > > +/* drivers/video/fbdev/core/fbmem.c */
> > >   extern int register_framebuffer(struct fb_info *fb_info);
> > >   extern void unregister_framebuffer(struct fb_info *fb_info);
> > >   extern int fb_prepare_logo(struct fb_info *fb_info, int rotate);


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch