Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230830140103.311752-1-dii@itb.spb.ru> <3ba3a7da-77d7-4a13-899c-e7a1f5b68a42@amd.com>
In-Reply-To: <3ba3a7da-77d7-4a13-899c-e7a1f5b68a42@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 31 Aug 2023 15:36:15 -0400
Message-ID: <CADnq5_NvD3CC=awhR4jqSb3GNYQfdFZDk3XX7pVyJfeU06kqiQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     Dembskiy Igor <dii@itb.spb.ru>,
        Alex Deucher <alexander.deucher@amd.com>,
        lvc-project@linuxtesting.org, Leo Li <sunpeng.li@amd.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        hersen wu <hersenxs.wu@amd.com>, amd-gfx@lists.freedesktop.org,
        Alexey Khoroshilov <khoroshilov@ispras.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Aug 31, 2023 at 2:48=E2=80=AFPM Harry Wentland <harry.wentland@amd.=
com> wrote:
>
> On 2023-08-30 10:01, Dembskiy Igor wrote:
> > It does not make sense to compare a pointer to array element with NULL.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while =
enable fbc")
> > Signed-off-by: Dembskiy Igor <dii@itb.spb.ru>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.=
c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > index 6966420dfbac..e87cf54ec658 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > @@ -1992,9 +1992,6 @@ static bool should_enable_fbc(struct dc *dc,
> >
> >                       pipe_ctx =3D &res_ctx->pipe_ctx[i];
> >
> > -                     if (!pipe_ctx)
> > -                             continue;
> > -
> >                       /* fbc not applicable on underlay pipe */
> >                       if (pipe_ctx->pipe_idx !=3D underlay_idx) {
> >                               *pipe_idx =3D i;
>