Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   mirimmad@outlook.com
Cc:     gregkh@linuxfoundation.org, Immad Mir <mirimmad17@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND
        64-BIT)), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] powerpc/powernv: use appropiate error code
Date:   Fri,  1 Sep 2023 22:49:12 +0530
Message-ID: <CY5PR12MB64550ACC0B90FDD120D21E47C6E4A@CY5PR12MB6455.namprd12.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY5PR12MB6455:EE_|CH3PR12MB8934:EE_
X-MS-Office365-Filtering-Correlation-Id: 34083b1d-c169-40b0-de9e-08dbab0fa6db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +e93XboYK1MPesvocZmqXgCukVgaXEr+C/PMOQ+C0gqK8luYhlxWF62UOw5v9Esr5g8t8S7NUy/0xEPbZVgxH6PwgTRBVZAuDzSurJ9uQCcLKp32eByNhyzc3o7cvgbfAJGvAt25Hga0k9MWXupD8T2m8PwJrUkYJCCBi3vepAZtpcvYkTC78sFS20msOlTSKAqE0z4QeN2RCL8Fm949LsCp9FhLDolIcm/z6NqOUi9TuP7B+4nOgwJcFj2P+ZE5dP0Ae+txAeYrjUvEV7I+519CwFo1PoHNylgbm8S65hgn0zw+vcm16Ah6KiXS9cjamUEYaEZ9vnTx+DZTU4DE+RF8hszuU6KJ+OYgowUrE3xSaSNMIwxTb/HfP8BLvQTS7nqSwDLF8rk5vaELTM166jzSReFDVnV0/Nrd4roG/OUHELIdtfUVFrpF/3zeNOe3rJ7mFR7+uPjsdTndaniL1aaifEf1Y06Uzmtck3Hun8QboeuUhJvL9YukAQcv6vityQEpgvKxiDI6xR92R6lBogujptrX4mTKZk6PQcu01s/4aYPFH7agNNQm3x9ZggcA
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FfU8SiBREa3goMgyNnpSsu264lD8AGuUeoaFppgjLw3MfD+Zw066DsEVqeR3?=
 =?us-ascii?Q?u4pl9wHzBggFFIWU8wlpJ7IFabevvg7Q4TpxK64RNpofoi7xtPlCQG1G+Un6?=
 =?us-ascii?Q?Inod4FR5WNKBa+RMu/pPcU8yQNhhjc8o81X5pN5LT+wh7t9HWbbhCO0Waqsq?=
 =?us-ascii?Q?krGt6ljtW10ICRbMxia1qRIFBC+XdXPFV/4JQRJAwO+xwHpabvZWySVBY9m0?=
 =?us-ascii?Q?jd7fRb3ahyoU0aCF9BVhvjiJA2TcLTLoW81mVtEIyrUiEHELbcpuaUHuIND0?=
 =?us-ascii?Q?mmRddYmdsyDpPAZj4bt4GXfmhH+FEuyQwxjvbsS+kgdsBLEkTpRbi0dSYeQc?=
 =?us-ascii?Q?q86q74OMpHHn9kYrZQ11mKYDnrCkWc9mtMeZxD/voEK+r/Q2np0Hm/kMscC9?=
 =?us-ascii?Q?DsnlgltCTE2hm8ElGbfMZ+yymtNHSbnSDFNX/qle1g4AXuwE8hnsDP2Z3YQz?=
 =?us-ascii?Q?7baiBolkcqD/HSL6KJSq83+13kVr/LP/7BlsbNd7MbyrdEckQ8xdo0xusYFi?=
 =?us-ascii?Q?Nz11023mjIaMSthtmSyZ+6wLHbSXgBgLfUVH2Ow34KuQovtVQ9+BB58UfsSd?=
 =?us-ascii?Q?+QkuS/lU+9USYgVizui5Nz3cCc4fcgeBPLc0vFlQwqA4a99TxAYVvQgn5jv/?=
 =?us-ascii?Q?GGyrMWbnye+tGJlOZ4sGcfxvdgTb2VnevbWJHQ/+YN6FuwAQZhuU+LBswzt1?=
 =?us-ascii?Q?CUgtcNxIX1Hpkt69i4a6IQxRtNsqNgas268VNApuxYzVmgeFysiYIX349CHt?=
 =?us-ascii?Q?RdywjMNjJ0drUSHI0k2bHHMZYvk0ZPqWjO1PBJUuVg1WRKJM6rlFnLMGAtbL?=
 =?us-ascii?Q?q4Qb5fxtlevFU7qUqkVLLgGLgKzW7v6a9ELApYzadwWoSpx+qn82DTCNnRzw?=
 =?us-ascii?Q?ZFb+TuuWDuKMbE5rLl4PxCN6lL9Ejtk0CT0fCExn/ctAPhYyCsrX3zgceLr8?=
 =?us-ascii?Q?jdQgEc91Bbe01+/bimMQo06YyYjJaj9tAILhsvdEoQ5DSJXF3wnSt++WNsEo?=
 =?us-ascii?Q?Oow7WZoCH2JU3gZuMAKkAwfjOtv9HuGat8v9Vmz4HGFGlJYMDtyXuPepz1+T?=
 =?us-ascii?Q?3rbwHbmZQnsXBNkcZJRKmm4VL7g4dlPR57vG4DRzJfX7YDgSaBsbf+udXeg0?=
 =?us-ascii?Q?aEo0jCTAcy9qMWi/DhIPBihFx1ZeTm7h0rg4hRx+ad0uevWKylW/en2oU4RT?=
 =?us-ascii?Q?vRk0MhI+3f9jyxGXy/B2tnaBdORtkJ5z9pf0xvJe7hb+VhHVlfnKm48qTUFH?=
 =?us-ascii?Q?4mI9PA7U+plwVyaJYc/zH17a2Hp3TpjrZsGyMJVKow=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34083b1d-c169-40b0-de9e-08dbab0fa6db
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6455.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 17:19:52.0736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8934
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Immad Mir <mirimmad17@gmail.com>

-1 is not a valid error code. This patch replaces it with -EPERM.

Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
 arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c
index 262cd6fac..ce4b089dd 100644
--- a/arch/powerpc/platforms/powernv/opal-xscom.c
+++ b/arch/powerpc/platforms/powernv/opal-xscom.c
@@ -171,7 +171,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn,
 	if (IS_ERR(dir)) {
 		kfree(ent->path.data);
 		kfree(ent);
-		return -1;
+		return -EPERM;
 	}

 	debugfs_create_blob("devspec", 0400, dir, &ent->path);
@@ -191,7 +191,7 @@ static int scom_debug_init(void)

 	root = debugfs_create_dir("scom", arch_debugfs_dir);
 	if (IS_ERR(root))
-		return -1;
+		return -EPERM;

 	rc = 0;
 	for_each_node_with_property(dn, "scom-controller") {
--
2.40.0