Subject: Re: [PATCH 34/54] Driver Core: add kobj_attribute handling
From: Kay Sievers <kay.sievers@vrfy.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
In-Reply-To: <20071105184350.0a1cd957@gondolin.boeblingen.de.ibm.com>
References: <20071102235758.GA9803@kroah.com>
	 <1194047972-9850-34-git-send-email-gregkh@suse.de>
	 <20071105134203.1c078136@gondolin.boeblingen.de.ibm.com>
	 <1194279812.6771.11.camel@lov.site> <20071105171133.GD12843@suse.de>
	 <1194283540.2174.8.camel@lov.site>
	 <20071105184350.0a1cd957@gondolin.boeblingen.de.ibm.com>
Content-Type: text/plain
Date: Mon, 05 Nov 2007 19:07:50 +0100
Message-Id: <1194286070.2174.14.camel@lov.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1400
Lines: 34

On Mon, 2007-11-05 at 18:43 +0100, Cornelia Huck wrote:
> On Mon, 05 Nov 2007 18:25:40 +0100,
> Kay Sievers <kay.sievers@vrfy.org> wrote:
> 
> > > > That should usually be done by default attributes assigned to the ktype.
> > > > Do you have a good use case, where people need to create such attributes
> > > > individually instead?
> > > 
> > > The s390 code that was converted to use kobj_attributes :)
> > > 
> > > These look very useful, I'll go add them to the series unless Kay really
> > > objects.
> > 
> > I just want to hear a good reason to create attributes individually. :)
> > Especially in conjunction with kobject_register(), these attributes are
> > not available at uevent time, which is really really bad.
> > 
> > Default attributes just work fine, and have the proper error handling
> > built-in. Offering special functions for it, may just encourage people
> > to continue this "broken" way of creating attributes.
> 
> But where should I specify those default attributes?
> kset_create_and_register() sets the ktype to kset_ktype...

Do you need to create attributes at a kset itself, not the kobjects that
belong to the kset?

Kay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/