Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Sep 2023 07:25:47 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Alexandru Ardelean <alex@shruggie.ro>
CC:     Andrei Coardos <aboutphysycs@gmail.com>,
        <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>, <herbert@gondor.apana.org.au>,
        <olivia@selenic.com>, <daire.mcnamara@microchip.com>
Subject: Re: [PATCH] char: hw_random: mpfs-rng: removed unneeded call to
 platform_set_drvdata()
Message-ID: <20230901-upper-reenter-9c2fa8bf7a47@wendy>
References: <20230828101757.9724-1-aboutphysycs@gmail.com>
 <20230828-citable-superjet-d235f036be99@wendy>
 <CAH3L5QreWNPgwogL7bCYZgKSuz_HfZuKLtRVqz+UyRtJ1TB-SA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rbkSUiqy942IY70F"
Content-Disposition: inline
In-Reply-To: <CAH3L5QreWNPgwogL7bCYZgKSuz_HfZuKLtRVqz+UyRtJ1TB-SA@mail.gmail.com>
Precedence: bulk

--rbkSUiqy942IY70F
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 01, 2023 at 09:07:56AM +0300, Alexandru Ardelean wrote:
> On Mon, Aug 28, 2023 at 2:06=E2=80=AFPM Conor Dooley <conor.dooley@microc=
hip.com> wrote:
> >
> > On Mon, Aug 28, 2023 at 01:17:57PM +0300, Andrei Coardos wrote:
> > > This function call was found to be unnecessary as there is no equival=
ent
> > > platform_get_drvdata() call to access the private data of the driver.=
 Also,
> > > the private data is defined in this driver, so there is no risk of it=
 being
> > > accessed outside of this driver file.
> >
> > I think Greg previously pointed out to you that is it not sufficient to
> > check for platform_get_drvdata() alone, because the information could be
> > accessed without going through that helper. That's not the case here,
> > but it could be true elsewhere.
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > Thanks,
> > Conor.
> >
> > >
> > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> > > ---
> > >  drivers/char/hw_random/mpfs-rng.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/char/hw_random/mpfs-rng.c b/drivers/char/hw_rand=
om/mpfs-rng.c
> > > index c6972734ae62..0994024daa70 100644
> > > --- a/drivers/char/hw_random/mpfs-rng.c
> > > +++ b/drivers/char/hw_random/mpfs-rng.c
> > > @@ -79,8 +79,6 @@ static int mpfs_rng_probe(struct platform_device *p=
dev)
> > >       rng_priv->rng.read =3D mpfs_rng_read;
> > >       rng_priv->rng.name =3D pdev->name;
> > >
> > > -     platform_set_drvdata(pdev, rng_priv);
> > > -
> > >       ret =3D devm_hwrng_register(&pdev->dev, &rng_priv->rng);
>=20
> A question would be if there is a desire to keep the prints below, or
> would this be sufficient?
>=20
>           return devm_hwrng_register(&pdev->dev, &rng_priv->rng);
>=20
> If there is the desire to keep the prints, then:

Yeah, I'd like to keep a print in the failing case, thanks.

>=20
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
>=20
> > >       if (ret)
> > >               return dev_err_probe(&pdev->dev, ret, "Failed to regist=
er MPFS hwrng\n");
> > > --
> > > 2.34.1
> > >

--rbkSUiqy942IY70F
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZPGD6wAKCRB4tDGHoIJi
0qUTAQD0ZDiVMxcLtPt0mgxplAh+moC7mid0YSGHBG9Ni1um5QEA/E2z+UWdQSGw
Yw88TOcd4HWPZN8oMlkVEjAmi8MA4gs=
=3NaB
-----END PGP SIGNATURE-----

--rbkSUiqy942IY70F--