Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1941013rdb; Tue, 5 Sep 2023 09:21:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrlBgaoN8/6BwBQhnzOb9fcM23ngKFnIHA30SW2oI3TeBDbSP2tzBYlw3JYLP+VAFMaLBl X-Received: by 2002:a17:906:ef8b:b0:9a5:8269:2c94 with SMTP id ze11-20020a170906ef8b00b009a582692c94mr209216ejb.57.1693930911287; Tue, 05 Sep 2023 09:21:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693930911; cv=none; d=google.com; s=arc-20160816; b=FBqxA6vkUvVVN5kE2rdevCowC/ODOeyDGCKNMYmokb3IBiRz43zM3+R8GEG4xZuvf5 PbgRGuoXIbGh9xyMb2fQb+hJjbfAgm9E+MtGE3+R8QD71OpAjfvRMWEpgOt7iR3QwKhr OhUcX1WN5TuaACF2whxeZFkVNojNoF1Yass/7yx57f1SuS3KvctNPfRG656gBBK/AmZu A8JKSPjZfoOguHuom4wgiNOzDZs4BBpZCCuy/ke5QN2vwrpyRgbe6gk6QSKk4tIs91xF +PmE9r8Y/oWFnLFxe2m8LJ3Et8MuXoomC2enGm5d9IuoAWRMx0n08LEGCVNenZ0B0rTv DmWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=2z5gw3ytBuygGDs1dY8jzo0OCP4TrdhZNJj6EowZE3E=; fh=a6XR+IsNAwxEUMGy8h8nq0R03DVOlk8zlClfXmUFat4=; b=Ax99qU8n2wFcx54MOz1WUQaz0b18K0O8EyVVR5OiPSN2+2L/keC5hG+VaD3APh/k1i puiBnyULhL7eXmxNvJRCr0Rm+Rmck+1r6Vxfgx+rR1UeLzxA84oPigwSXnMCNVCwdwxq fwBtPlaU0WbBp94fHKBP6x1UsvVEMeqgN37gmHhW+fjhtgh1tJ3uXOeQo8BZqOAUeLP3 g+yCf/kBGFEQABZB+hx10mx8/2MLCe5eH9be0xkswcqwel3EKzwyCFliwz5DgAOIjroH fceqnItVSrUz5QuX2F9MCFhm/Q2aZ4e5kDa2iOuiSkkVwSNHkQ5FQP4TJ4UoLGrPxo8F Tcxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=AZm1eK9g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s25-20020a1709064d9900b0098cf3eaee4esi7612686eju.57.2023.09.05.09.21.48; Tue, 05 Sep 2023 09:21:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=AZm1eK9g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242116AbjHaHPK (ORCPT + 7 others); Thu, 31 Aug 2023 03:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344186AbjHaHPI (ORCPT ); Thu, 31 Aug 2023 03:15:08 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 76A49E59; Thu, 31 Aug 2023 00:14:59 -0700 (PDT) Received: from pwmachine.localnet (85-170-34-233.rev.numericable.fr [85.170.34.233]) by linux.microsoft.com (Postfix) with ESMTPSA id 7F3DC212A771; Thu, 31 Aug 2023 00:14:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7F3DC212A771 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1693466098; bh=2z5gw3ytBuygGDs1dY8jzo0OCP4TrdhZNJj6EowZE3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZm1eK9g/CO1f+Nj64/Mb8FxIWAcYIY/W/zXKZq6EucXXKe5qic90Uv9ycz1sE4Et R6aMtCLmOek4H1r+d1vcgqhwKU0b3EIDErNJ36O2fz6FRs77FCVKz2mqJjNDBlK7lb WoDDl6LaKl1M4VUSD0tYezTlaWRqQAWzYm44pi9c= From: Francis Laniel To: "Masami Hiramatsu (Google)" , Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Date: Thu, 31 Aug 2023 09:14:55 +0200 Message-ID: <2696412.mvXUDI8C0e@pwmachine> In-Reply-To: <20230829195719.0eaf9035@rorschach.local.home> References: <20230824160859.66113-1-flaniel@linux.microsoft.com> <20230825221321.faaa33e03afc48abc345c24f@kernel.org> <20230829195719.0eaf9035@rorschach.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Spam-Status: No, score=-17.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. Le mercredi 30 ao=FBt 2023, 01:57:19 CEST Steven Rostedt a =E9crit : > On Fri, 25 Aug 2023 22:13:21 +0900 >=20 > Masami Hiramatsu (Google) wrote: > > > Excellent catch! Thank you, I will apply this patch and send v4 right > > > after. Regarding test, do you think I can add a test for the > > > EADDRNOTAVAIL case?>=20 > > Hmm, in that case, you need to change something in tracefs/README so th= at > > we can identify the kernel has different behavior. Or we have to change > > this is a "Fix" for backporting. >=20 > I prefer this to be a Fix and backported. This makes sense, I will send v5 to stable mailing list too! =20 > Thanks, >=20 > -- Steve Best regards.