Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
CC:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        "Babu Moger" <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled
Thread-Topic: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled
Thread-Index: AQHZ2tLQzZViQZuDwEGXIVxBB0yNB7AC0IKAgAAi0cCAAQYZgIAAqlXQ
Date:   Thu, 31 Aug 2023 17:04:31 +0000
Message-ID: <SJ1PR11MB608325D10C22A7EAE1C31C42FCE5A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-9-tony.luck@intel.com>
 <frfa3olxop3xjnouvvv7y2s36varmto5qwhmkitvslmiawzwkd@zh2jhob4o5qe>
 <SJ1PR11MB60838CA98A341F59260BDE18FCE6A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <zulbpqdmui664qflvo3fcw3wnuailsiwkjtfu4xr37kutdoagy@54z7s6hud2vf>
In-Reply-To: <zulbpqdmui664qflvo3fcw3wnuailsiwkjtfu4xr37kutdoagy@54z7s6hud2vf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vxtRESb/vgHgVT9a538ckQwCyajWbGJJJBbeG4Rbmvjd+b3YxGEXvLd2pFGT?=
 =?us-ascii?Q?A91RR7M3m4G0U5nnEuogg1AY/WIPyNW2d2xetIF28QHa3d0jK/BvcOxS/bJo?=
 =?us-ascii?Q?Lk1x1y1soJL7vIsxn5x+/0Oo/PIK10P1MvLw2OoCjpF6/r+q0p81EaGoGxrj?=
 =?us-ascii?Q?0Ujbqh9hXQ/Ks/ECDHWFcNp8OocbE7ioo/ygxVE8zqssOibKa0OE4tTMJIqx?=
 =?us-ascii?Q?9MTeRfkFP/a5ziDmQJG74ekEVQuJzqZMv+bLHCEpKSvnm/LW0uxeZQjlnGJk?=
 =?us-ascii?Q?udnEqf3ROeNs3dU6jn877Dhm/C+vk+GdP0Pa2N/HS8FBpdl+INGu2mpQHDmD?=
 =?us-ascii?Q?i9lTZPo2ykrvabgNQSYzViJ0BXRZ9z488LoeZSJBiD4E7toxnbq9NC+Hqm0K?=
 =?us-ascii?Q?HidDPvKKUSxukjszs7SmKEzwCPJoUqJ2OVT8yTgCUBi7cIy20z9tM/syWI1Y?=
 =?us-ascii?Q?2myUQrGMtt++OlU8RfO/U1zCLGZ79wgU+e1Zj7b4HoMtqJ7JhfHRXj2SHqEC?=
 =?us-ascii?Q?4TcjBHAbwJrEfcIeevsDP+ydRhQOz0UgwKmahoRBbwy6f8Yer/JxaDXunhEE?=
 =?us-ascii?Q?oUZYyAzozAVZUbeWn6yi6gwFTYiJAC7Q7U17x9zx0lCRe13P9DabxGp806jZ?=
 =?us-ascii?Q?KcrNkfVaHw6F2z99STZxr8tG7YAApE/b4grSA4g5QRyiYRcqqFwqWBZ1jjdU?=
 =?us-ascii?Q?A1fl7I8AVHRl9EoIqNHKqvsbVjrJFf1UipDpe+Mhvq2YBGInk4s0owZby3ZQ?=
 =?us-ascii?Q?Sn5ZiiisFrEK2poTO8O1/KE3UADnqqzwQphnpn6FqdtSS/9LcrZYvhEmXcuc?=
 =?us-ascii?Q?f0aJpCLaZxDsCxwL2UIgWmIV74fEQM4q32Kx1aJGATEwNAdt6YCS8o8Q43je?=
 =?us-ascii?Q?14ojn+QsRlNc55V/xw9OEltzkj3+rIW7zWX/sj8l18IDyWoCfEtDznugtt9E?=
 =?us-ascii?Q?ffWFbczD5sEdfTLpl8veQFO/yB6zohwQboZN33ZUGMLyTYyNeHT1GoIQL1fk?=
 =?us-ascii?Q?Lj8B/R2HVVf1/srXXYltGWDW9jXU3dTVoULy2weh0gVqGKTXEoUe1Q38uVrV?=
 =?us-ascii?Q?hZo2PQPUNAnsLwBHQBfj1IdbucorwlXzKiNfTF5hmhTPIqjIVBFY9pbRzADg?=
 =?us-ascii?Q?ElM+Y74JBNd+pEZAY80QQYQy8dgCnOhXMFgbebFhTYckF++yFsw0kySr/JFF?=
 =?us-ascii?Q?Ye2lW8L8pVOjuwwSSmHh2lVmgbr0vhS4Q2SaC19OdLsNEYO8pf0eVqJ2ox+7?=
 =?us-ascii?Q?pwEzIPrtu2FyLmG/GRifzJrkTyeTtzAYm/K8R8Cmx4edkWyjx5d1Bks+D/7J?=
 =?us-ascii?Q?sN7gcjT0C9VDUTbnIQ8kGvN3XfoD3LV6EEeLKfkLno9NbvnRILa3GKZEoOlz?=
 =?us-ascii?Q?WiJ0DgmsiXVPZW3tqqcG6BONBdNFE76gMdFwFqW+v9Vdvb2oeiUdlufmwsF5?=
 =?us-ascii?Q?eMAyVDmBGPJGfePzMzRkssTtbRBjSSaBxbOtEPUMXLJiwm72XzXF4OtY6vCn?=
 =?us-ascii?Q?7L7/wbvUdVYFtiKqTG/WCuEbIqc3xQ/PQUIx/t9hQ63m8OAuUNozuoiAF6tr?=
 =?us-ascii?Q?DYzXWoZcLo4UPF1LiIA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d00be8b-ab10-43d2-f7fc-08dbaa445824
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2023 17:04:31.6268
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5M1H4GTIRCS/R4eKHLiASz20+SVJCtzcUhcA3Wnd3/ffzm3kQ4EnQWqVuaW56a0klo8T1KACfPdkeDpTip4N7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7859
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> So it would look like this:
>
>       while ((fscanf(fp, "%x", c)) !=3D EOF ) {
>           if (c > 0xF)
>                   continue;
>           count =3D __builtin_popcount(c);
>       }
>
> Are there some problems with an approach like that?

I think I'd prefer something that does more checking on the input
(e.g. the hex numbers are separated by "," and terminated with
a '\n').

If Shuah Khan doesn't like my original patch I can re-write
to use fscanf() et. al.

-Tony