Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Sep 2023 22:51:45 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Kuniyuki Iwashima <kuniyu@amazon.com>
Cc:     aleksandr.mikhalitsyn@canonical.com, arnd@arndb.de,
        bluca@debian.org, brauner@kernel.org, davem@davemloft.net,
        dsahern@kernel.org, edumazet@google.com, keescook@chromium.org,
        kuba@kernel.org, ldv@strace.io, leon@kernel.org,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        mzxreary@0pointer.de, netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v7 1/4] scm: add SO_PASSPIDFD and SCM_PIDFD
Message-ID: <20230901205145.10640-A-hca@linux.ibm.com>
References: <20230901200517.8742-A-hca@linux.ibm.com>
 <20230901203322.56399-1-kuniyu@amazon.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230901203322.56399-1-kuniyu@amazon.com>
MIME-Version: 1.0
Precedence: bulk

On Fri, Sep 01, 2023 at 01:33:22PM -0700, Kuniyuki Iwashima wrote:
> From: Heiko Carstens <hca@linux.ibm.com>
> Date: Fri, 1 Sep 2023 22:05:17 +0200
> > On Thu, Jun 08, 2023 at 10:26:25PM +0200, Alexander Mikhalitsyn wrote:
> > > +	if ((msg->msg_controllen <= sizeof(struct cmsghdr)) ||
> > > +	    (msg->msg_controllen - sizeof(struct cmsghdr)) < sizeof(int)) {
> > > +		msg->msg_flags |= MSG_CTRUNC;
> > > +		return;
> > > +	}
> > 
> > This does not work for compat tasks since the size of struct cmsghdr (aka
> > struct compat_cmsghdr) is differently. If the check from put_cmsg() is
> > open-coded here, then also a different check for compat tasks needs to be
> > added.
> > 
> > Discovered this because I was wondering why strace compat tests fail; it
> > seems because of this.
> > 
> > See https://github.com/strace/strace/blob/master/tests/scm_pidfd.c
> > 
> > For compat tasks recvmsg() returns with msg_flags=MSG_CTRUNC since the
> > above code expects a larger buffer than is necessary.
> 
> Can you test this ?

Works for me.

Tested-by: Heiko Carstens <hca@linux.ibm.com>