Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <73b4d9d0-76a8-3b60-6d7a-2c115b220868@intel.com>
Date:   Thu, 31 Aug 2023 14:26:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.14.0
Subject: Re: [PATCH v4 8/8] selftests/resctrl: Cleanup benchmark argument
 parsing
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Babu Moger <babu.moger@amd.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230831110843.26719-1-ilpo.jarvinen@linux.intel.com>
 <20230831110843.26719-9-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230831110843.26719-9-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjlkWUMwMkZUeXgzb3FtMTc4VlJ2czZCWm9XRDFvaWJqVjFiZG5MTVkxbm1T?=
 =?utf-8?B?REJ1N0ZWOGR4alFrVHYyb29TblR4Q1h4eXU1S25YQVFJRFZ0d1RpNTNDZys1?=
 =?utf-8?B?N294bm5qQmdHa1pmU2tYcm1oZGIxRDY0Z08yR1JNSjRXdHVWTTVyOE50eWVH?=
 =?utf-8?B?bURPS1hIdkNxOE1iQ3NiekZjMUZ6SlZ5dWszNzlZVTVkVk53OWQ0akxXZE1p?=
 =?utf-8?B?WlE3akZ0dEhFU2pFWmc3T24vdVhZUHhpT0dhR3VZTk03QkxuOTZXVG5Mc3lq?=
 =?utf-8?B?K2ZkY1Y4dnlTMVUxZWZSQXliYisyK0JIaXgvQlljZGFlaXhTWmxJd2NiZVlq?=
 =?utf-8?B?ejEvWEREcS9Qa3BEVk04K0NnQWtwTU55OEQrZm9vME93L2dtMUUvZWQzcmx0?=
 =?utf-8?B?R1lGT2JDVEdJeGQ2Nms3TTVYOUdLRENhQktIbnNldFNhUzBPbHBsby9OVHlR?=
 =?utf-8?B?Uk02RVhNTFRIT0VHZVU3WERrQnl6d1h3V05TSi91eGJqd1V4VS9hWE9lcXV4?=
 =?utf-8?B?c2VGMXRPakhmNjNGVW41VXhoNE5NRkdTMUJtUzdqbUZwMjVqTGJ0TDVpWVZW?=
 =?utf-8?B?aVFsK05GaTFObUk3VVhsWnV2T2tHSGMzTlNwTDFteGdBTlZTUTZjeDJGZDFO?=
 =?utf-8?B?NVljZXJBSlI1MFIzQVN0cGxQcFpmbEk2UmxaVFJDVlh3V2ZyMVRGMUR6U0M1?=
 =?utf-8?B?YWNDUWF5SjN5UG55Y2UvZ0lHRERPUzFYV0xWdUdaT0lxN055UFRzbUxsR2hB?=
 =?utf-8?B?TE94b0Ryai9SZzdxTTdFbWdhbFdYdEdXYmZkRDhIYkpub2V1dWE5U1kybjFk?=
 =?utf-8?B?aW0xM0E4T2paempNYnc1MXgyeVc3akFldXFMa2Q5R2cxNlA0ZEJycDZqcmpR?=
 =?utf-8?B?a0VhOEJSZC9yckt4NmNHMmtya1hYU3BQK2J2YVFSZnNlMlI0amoxaDd1WWFO?=
 =?utf-8?B?bE9iamg1Mks4MXJnSWh2NytUQzBQRmozU0JLK1ZZZmlQb3FibzhwcGo5UXRo?=
 =?utf-8?B?Z3NqZ3Y3aVFOTkRRNHlBRXhnbitvUGZOYWtyY0VqbFp2b1J0cC91Rm9WL2dD?=
 =?utf-8?B?MU1tdFFLQ00vYXRKN05oRURaQ2Y1d3I2Z2lKVFZTMWJoOThBTmRyM2lqbDlj?=
 =?utf-8?B?WWVaRXhWOHZqS3VDTWh6OWJ2TmxuWXVNZWoyYVZ1c1kzdHg0WElxSHNFdEFK?=
 =?utf-8?B?SGJ5L3ZYUWJ0ckgvZkVPaDUzdkJUQUJFZ2E2SDhVK09SS3paNUw0TDE5eS80?=
 =?utf-8?B?WXFmeTJ4MUs1bjBHR1RQM0lYOGJmNUN5eHo5VHBlbGNYeFo5WFNySjZIaGZ3?=
 =?utf-8?B?ZnpETHR2Ty9MS1ZLYndWZm9NcTh6dlFLR3hCeFNERmw4SWhhdnpjbXdROWlR?=
 =?utf-8?B?QXVkRXp5dW81YmxQUTZjZi84WDZVZUtuMHpRK2RkS1JCK1JMNDVKazc3UHl5?=
 =?utf-8?B?cTl3RE5oSzBXUjZ1aytwT0RRMTd2MGR5dTZ5YkVOQ3lFM1ZGTklzM0tiUjFJ?=
 =?utf-8?B?SmtJS3dlbHUwK2htRGc0UVB1c0lUY05HM0JvL3RWZllsSUp0aks0UlZSVDlY?=
 =?utf-8?B?TzhLSkh2ZTFOQ1BOenNLazQwSUs2R3FhelJ0QytiRmJMVi9PUkZkM3Evc21h?=
 =?utf-8?B?RXR4QlM0cVZzZlRIWXV5ZkJHdWdqMllzem9lcEtkRU14T2tuZHZxRU5Fckdx?=
 =?utf-8?B?L3paRmhWMW93eWdBUDRMQnBrZzExTUxXNFIxZFZrQVQxcUNRUHgzUmcyMEls?=
 =?utf-8?B?VktZSC9jZm9sTkFJcjNoeEpYODVwU0FWTkhQeVJNcFN2MXpzdmtwblEyc0Zn?=
 =?utf-8?B?TDhNcm9CektUNmpmNlR2UHhGOEp1Tm5aclROSExVZXZGaVd1RW80WXNzbjNl?=
 =?utf-8?B?U3NyblVtaS9rQnFKUVBuWHpLcXEzWDVXQmxGT0c0VFpIbmQzalRQdWJZQlFY?=
 =?utf-8?B?WVNETllWRzNGZUlqSDB5TUs0RnozQmdzamsvdWNpSGQwcEluU1c2ZGpxeEV0?=
 =?utf-8?B?bzFiVzIyUVl5QkRsMnA4ZDdZUFFlTzJoWnZveXl4Ymo4ZkdGaStpRVo2eWhH?=
 =?utf-8?B?YWw5WXVicjVIdWdOUVZkbUM2QXVLVTFuVE1hY2pQNWUwRlZucFU1dlVoM01O?=
 =?utf-8?B?azArbE9QRUdacW9hSnhDbEJhZW9ucnYrWjJacFcxWTNjTGZNSmd3THlURjVG?=
 =?utf-8?B?REE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 39775fc6-5b5a-4eef-5ac3-08dbaa68ed1a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 21:26:23.5540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A8UQLcHJenjMeEyi8cuFB35DITO8d0pRLdElhdRisUhhDoCepRUnFD63V0rxc0UW93qG7tkrmk0hlwPqsgqccZJMOQBE+0Ju3nElFTYrZ3w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6744
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark argument is handled by custom argument parsing code which is
> more complicated than it needs to be.
> 
> Process benchmark argument within the normal getopt() handling and drop
> unnecessary ben_ind and has_ben variables. When -b is given, terminate
> the argument processing as -b consumes all remaining arguments.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  .../testing/selftests/resctrl/resctrl_tests.c | 46 +++++++++----------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 48e5afb1530c..831d50a37d78 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -169,27 +169,34 @@ static void run_cat_test(int cpu_no, int no_of_bits)
>  
>  int main(int argc, char **argv)
>  {
> -	bool has_ben = false, mbm_test = true, mba_test = true, cmt_test = true;
> -	int c, cpu_no = 1, argc_new = argc, i, no_of_bits = 0;
> -	const char *benchmark_cmd[BENCHMARK_ARGS];
> -	int ben_ind, tests = 0;
> +	bool mbm_test = true, mba_test = true, cmt_test = true;
> +	int c, cpu_no = 1, i, no_of_bits = 0;
> +	const char *benchmark_cmd[BENCHMARK_ARGS] = {};
>  	char *span_str = NULL;

Could you please keep reverse fir ordering?

Reinette