Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a975bbdb-8cd9-35b2-ce98-f711439db3a5@amd.com>
Date:   Fri, 1 Sep 2023 09:30:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20230901070240.31027-1-jiapeng.chong@linux.alibaba.com>
Content-Language: en-US
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230901070240.31027-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3Q1NGVPenlTdDNwUFFGSS93Z25rRGxJd2RrWnNGMHNVSWU3QVljTmtYYkpx?=
 =?utf-8?B?VS9zb2xhbDR5STFRbjNEN0pNVlZvd2tzOFl1ek1YMmM2TXYwcWxlTmxiSjho?=
 =?utf-8?B?d3hCSUJuVnNBeWhjb0l5T0pObnVsWGxRclFiYWRScFhuUWFPVG1BSHZmTWla?=
 =?utf-8?B?YXFzNDJ1NXVNMHMrVXdDWTdXVWsxMjcvbldSUmpoQzhTMDlNZmdXZVFuZWFl?=
 =?utf-8?B?Ums5Vk0vWm5iRzdEVDljcHVSUnNjN3lNaGpySWhrRUZ4dExpcS9tdC9MdHM4?=
 =?utf-8?B?YWtJZkYwck50a3NHaTNmeFNKSnRuNTQ5V3NKWVhVVXF5YXBaalZCeVAxK0pK?=
 =?utf-8?B?WTc4WUhzN1FtQWdCSTdub0FqVVdqdDY3eWsvK0hIOE5HbkV6dWl1WGs0RHRT?=
 =?utf-8?B?L1llQXEyVDY5MGEzT3NucjZNUHdjYVNTTzlNUno5eXhmVDl1SSt6c3ZLMFFQ?=
 =?utf-8?B?eHFrRXRZSkg5WWRUOEhpR2FKY3VOa2pFYkVncTNyN1F5Wk5VcmpBUWg5cHZE?=
 =?utf-8?B?M1hjdTA3S1VueW5MblpLV1Npc3k0UlR3d0VLS1hoMXJ5NytoQ1VmR1Bia0cx?=
 =?utf-8?B?RXVMbWQwZ2hDTXMvZnVQYzVZVi9xZWhkY1NCSjNUUE51c0E3YnFZcjVjK0tS?=
 =?utf-8?B?d1F3NVY5VkowZ2NyQmh4ZW1JWEtrQzB5VEYzQnBNYkF2K0RWUkJBQnliM2Rt?=
 =?utf-8?B?bVBaR3dYa2lhVzk2bm12cFllMC9hS25SYXprRDZOYjhDNklLbWxFRWNvcW1i?=
 =?utf-8?B?b051Q3d0MGxRbk5OMktxRHFySUExeldsK2xWT2NHZkpwS1g3czBXdGQ5N1VN?=
 =?utf-8?B?YnB6RWtqd2lnRVp0TWd2dWVseVpkZ3Rpa2VMQm92SGZucXQvVTJNWklmaHRl?=
 =?utf-8?B?ZVAwY2xOcS9uTjBKMEh6NkJlbDVKUjFLYUg4YkljYnFmcGJuUDNNcDJJMnNi?=
 =?utf-8?B?T05TM3JtQU1GVWNva0w3TDUvckRRL3pmL21FWjhnemhpN3lSK1dFZHdCcVVO?=
 =?utf-8?B?TXQweXlDcnQ0SkNDV2pmSklneHlRRVk2T0ZMSzBWM3d3dEdyc281cjRaelBs?=
 =?utf-8?B?RzVFeGE5a0FCZlBZZFQzNEVZWVo5NWo5S0VVbW5HNGRuUFBVNVBVRDhQTkdC?=
 =?utf-8?B?L2N6OGQ0cEptRWpEWXdrRUtTZ0tDU1M4MHNDcS8zSFlNN0pqZ0lQbTlMem1E?=
 =?utf-8?B?L2JRNVJLaVBPWjB5UXRrN1c3U3F4TEpiVW9BWUFFVDNGdFB5aVhtZnY1N3Zk?=
 =?utf-8?B?SjNGcTREQ3p4TS95T2lsU0Z2TXM5OGR2NkVDKzVLdUdLcjl0cVNPWWhsa3BT?=
 =?utf-8?B?QzJOMGdEME1QOW9vRkJwcGlPOS9iTjVmS00yWWxjbnF6ZjFpem5rZGpNMHRa?=
 =?utf-8?B?ZndoODZlNlo1b2JGZjZhOGlSQlhMUDVSM21yY0xjQ2Zrck9HdU9xK2VQZnBj?=
 =?utf-8?B?Q0dzNFgzTnY5clJ3TkE2QXdZbitUbVdQNUlLTTV6anRqUGt2U2dkQVJVTXFO?=
 =?utf-8?B?Smthc3pOeEhTeDVxc2p3LzhqUUVMMGhDQkRBZi9iTi9tWUtWYVgvYjNYZk5L?=
 =?utf-8?B?eFBpZ3J1NENyazNwRWNBeElDYXFoOEpMQkNxY28wUWhQZy80TUJ2c3FGNkgz?=
 =?utf-8?B?NkxyK01aSkI3elJQMXNDd3ZXcDFTNEtKaTRmNzA1ZFVBUzlLZmtSZ2tGSzhj?=
 =?utf-8?B?R2MrUHBpZmFHc3VYVTVYeGx0NWpvVlJZTUFOVk8zSk5JSXdKQ0JoTTRHLzE1?=
 =?utf-8?B?YlpPMHphUVJrc09yc1ZENnJpUWNEWlZNVmRIampPbE85QVVNKy96Tm1uQy9J?=
 =?utf-8?B?R2RGK1VhTFE5RXBSWnUxeGIrVEs2eGdmdlVqODR6dER2TVIzdjYxZVlwM085?=
 =?utf-8?B?RldKNXFkVzFwYUhXSVNqWTU2MkNkdmVDK1lySXdXaUxzNHdwUGo2Q0Ztb3J5?=
 =?utf-8?B?U3hFU2pIbDh3NVRXSGdZN2VySkdLdzJBQlNyM0JpVWoxUmZQQkVzRHYvQVhM?=
 =?utf-8?B?aGRHK0pXTTdidzFIa1B6Rkh6YzI3a3JTN3FXb3QwRDhBckM1RWpXanZ5Sll3?=
 =?utf-8?B?UVlJRHZ2dDU1TEpnZTREOWtiS3U1cGwzVTFiNUxxSTNjZ2daUys5SXdaL3hR?=
 =?utf-8?Q?bgR9dJz77UbvvgLbzUwX3bgPU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9885ec11-6362-4a82-6d4a-08dbaabd5b20
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 07:30:46.0079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 32WC0RBkC4KevIlb1Ps7wwPRWzboZO1WDad5ATGRVAv/Pkub1et7hdlT36n9LrAI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6198
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 01.09.23 um 09:02 schrieb Jiapeng Chong:
> No functional modification involved.
>
> drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting.


We should probably not have a printk here in the first place.

Christian.

>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> index 7c08e5f95e97..76e21357dd4d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
> @@ -31,10 +31,9 @@
>   static u32 nbio_v7_11_get_rev_id(struct amdgpu_device *adev)
>   {
>   	u32 tmp;
> -         printk("%s, getid\n",__func__);
> -
> -		tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0);
>   
> +	printk("%s, getid\n", __func__);
> +	tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0);
>   	tmp &= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0_MASK;
>   	tmp >>= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0__SHIFT;
>