Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Sep 2023 15:55:00 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
        Thomas Gleixner <tglx@linutronix.de>,
        Joel Fernandes <joel@joelfernandes.org>,
        Vineeth Pillai <vineeth@bitbyteword.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v4 7/7] sched/fair: Fair server interface
Message-ID: <20230905135500.GB20703@noisy.programming.kicks-ass.net>
References: <cover.1693510979.git.bristot@kernel.org>
 <db775d65b18ddac4a75faad6761c6c2abf3efb78.1693510979.git.bristot@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <db775d65b18ddac4a75faad6761c6c2abf3efb78.1693510979.git.bristot@kernel.org>
Precedence: bulk

On Thu, Aug 31, 2023 at 10:28:58PM +0200, Daniel Bristot de Oliveira wrote:
> +static ssize_t
> +sched_fair_server_runtime_write(struct file *filp, const char __user *ubuf,
> +				size_t cnt, loff_t *ppos)
> +{
> +	long cpu = (long) ((struct seq_file *) filp->private_data)->private;
> +	struct rq *rq = cpu_rq(cpu);
> +	unsigned long flags;
> +	u64 runtime;
> +	int err;
> +
> +	err = kstrtoull_from_user(ubuf, cnt, 10, &runtime);
> +	if (err)
> +		return err;
> +
> +	raw_spin_rq_lock_irqsave(rq, flags);
> +	if (runtime > rq->fair_server.dl_period)
> +		err = -EINVAL;
> +	else
> +		rq->fair_server.dl_runtime = runtime;
> +	raw_spin_rq_unlock_irqrestore(rq, flags);
> +
> +	if (err)
> +		return err;
> +
> +	*ppos += cnt;
> +	return cnt;
> +}

> +static ssize_t
> +sched_fair_server_period_write(struct file *filp, const char __user *ubuf,
> +			       size_t cnt, loff_t *ppos)
> +{
> +	long cpu = (long) ((struct seq_file *) filp->private_data)->private;
> +	struct rq *rq = cpu_rq(cpu);
> +	unsigned long flags;
> +	u64 period;
> +	int err;
> +
> +	err = kstrtoull_from_user(ubuf, cnt, 10, &period);
> +	if (err)
> +		return err;
> +
> +	if (period < fair_server_period_min || period > fair_server_period_max)
> +		return -EINVAL;
> +
> +	raw_spin_rq_lock_irqsave(rq, flags);
> +	if (period < rq->fair_server.dl_runtime)
> +		err = -EINVAL;
> +	else
> +		rq->fair_server.dl_period = period;
> +	raw_spin_rq_unlock_irqrestore(rq, flags);
> +
> +	if (err)
> +		return err;
> +
> +	*ppos += cnt;
> +	return cnt;
> +}

> +static ssize_t
> +sched_fair_server_defer_write(struct file *filp, const char __user *ubuf,
> +			      size_t cnt, loff_t *ppos)
> +{
> +	long cpu = (long) ((struct seq_file *) filp->private_data)->private;
> +	struct rq *rq = cpu_rq(cpu);
> +	unsigned long flags;
> +	u64 defer;
> +	int err;
> +
> +	err = kstrtoull_from_user(ubuf, cnt, 10, &defer);
> +	if (err)
> +		return err;
> +
> +	if (defer < 0 || defer > 1)
> +		return -EINVAL;
> +
> +	raw_spin_rq_lock_irqsave(rq, flags);
> +	rq->fair_server_defer = defer;
> +	raw_spin_rq_unlock_irqrestore(rq, flags);
> +
> +	*ppos += cnt;
> +	return cnt;
> +}

Surely we can write a single function that does all of that with less
duplication?

Additionally, should not the deadline parameters be vetted by access
control before being accepted ?

Perhaps something like so:

static ssize_t
sched_fair_server_write(struct file *filp, const char __user *ubuf, size_t cnt, loff_t *ppos, enum dl_param param)
{
	long cpu = (long) ((struct seq_file *) filp->private_data)->private;
	struct rq *rq = cpu_rq(cpu);
	u64 value;

	err = kstrtoull_from_user(ubuf, cnt, 10, &value);
	if (err)
		return err;

	scoped_guard (rq_lock_irqsave, rq) {

		u64 runtime, deadline, period;

		runtime  = rq->fair_server.dl_runtime;
		deadline = rq->fair_server.dl_deadline;
		period   = rq->fair_server.dl_period;

		switch (param) {
			case dl_runtime:  runtime  = value; break;
			case dl_deadline: deadline = value; break;
			case dl_period:   period   = value; break;
		}

		if (runtime > deadline ||
		    deadline > period ||
		    /* more stuff like access controll */)
			return -EINVAL;

		rq->fair_server.dl_runtime  = runtime;
		rq->fair_server.dl_deadline = deadline;
		rq->fair_server.dl_period   = period;
	}

	*ppos += cnt;
	return cnt;
}