Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230831044431.250338-1-aford173@gmail.com> <20230831044431.250338-2-aford173@gmail.com>
 <4d700304-3e10-a19b-d3f0-d0a1aec11580@denx.de>
In-Reply-To: <4d700304-3e10-a19b-d3f0-d0a1aec11580@denx.de>
From:   Adam Ford <aford173@gmail.com>
Date:   Fri, 1 Sep 2023 06:06:56 -0500
Message-ID: <CAHCN7xJpug+ap4koX_3w_YTvHF9NC8-2S0f69SsDNY_6T+rcPQ@mail.gmail.com>
Subject: Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node
To:     Marek Vasut <marex@denx.de>
Cc:     linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 31, 2023 at 4:53=E2=80=AFPM Marek Vasut <marex@denx.de> wrote:
>
> On 8/31/23 06:44, Adam Ford wrote:
> > The i.MX8MP has a micfil controller which is used for interfacing
> > with a pulse density microphone. Add the node and mark it as
> > disabled by default.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > V3:  The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is
> >       called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out.
> >
> > V2:  No change
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boo=
t/dts/freescale/imx8mp.dtsi
> > index 3167706d81e1..341fd0369ce9 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1479,6 +1479,27 @@ easrc: easrc@30c90000 {
> >                                       fsl,asrc-format =3D <2>;
> >                                       status =3D "disabled";
> >                               };
> > +
> > +                             micfil: audio-controller@30ca0000 {
> > +                                     compatible =3D "fsl,imx8mp-micfil=
";
> > +                                     reg =3D <0x30ca0000 0x10000>;
> > +                                     #sound-dai-cells =3D <0>;
> > +                                     interrupts =3D <GIC_SPI 109 IRQ_T=
YPE_LEVEL_HIGH>,
> > +                                                  <GIC_SPI 110 IRQ_TYP=
E_LEVEL_HIGH>,
> > +                                                  <GIC_SPI 44 IRQ_TYPE=
_LEVEL_HIGH>,
> > +                                                  <GIC_SPI 45 IRQ_TYPE=
_LEVEL_HIGH>;
> > +                                     clocks =3D <&audio_blk_ctrl IMX8M=
P_CLK_AUDIOMIX_PDM_IPG>,
> > +                                              <&audio_blk_ctrl IMX8MP_=
CLK_AUDIOMIX_PDM_SEL>,
> > +                                              <&clk IMX8MP_AUDIO_PLL1_=
OUT>,
> > +                                              <&clk IMX8MP_AUDIO_PLL2_=
OUT>,
> > +                                              <&clk IMX8MP_CLK_EXT3>;
> > +                                     clock-names =3D "ipg_clk", "ipg_c=
lk_app",
> > +                                                   "pll8k", "pll11k", =
"clkext3";
> > +                                     dmas =3D <&sdma2 24 25 0x80000000=
>;
> > +                                     dma-names =3D "rx";
>
> Is dma-names really required if there is only a single DMA channel in DT =
?

I would normally agree with you, the DT binding file shows it's
required, and the driver looks like it's searching for a channel name
called 'rx'

adam