Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp2016003rdb; Tue, 5 Sep 2023 11:37:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFV5JSnbZjFDHp4bwpwO5Ma6tyHHUyqasQCwrVqVgVjx7HH7XHpdrMpVaIi+LdrcQ/0geAV X-Received: by 2002:a17:902:d707:b0:1bd:bbc3:c87b with SMTP id w7-20020a170902d70700b001bdbbc3c87bmr11702020ply.41.1693939059487; Tue, 05 Sep 2023 11:37:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693939059; cv=none; d=google.com; s=arc-20160816; b=vUwTsH3dA0S2mZtC3wnHDsV5I/RaZJqsxfWGY7fzyOQjFPA4XFm6EW6bhNSJBKqoQ6 GlyxSoWV49HTn3jtju9+zwcDXdOAzqymNPUpcL86+zGy0ogjHqvPh4+Cos6ehCcOnz6F NKRcCpQOMmbH85ktNfT6kBEL3AARtHZE6CpU5Dtdzdj6DQ2Crn1mWGnJ67sbXTJ5NnyP 8k/DV1XH+FQYHMaj7PcB5LeLuWCyJ7E5T4Gh0/rX942r36hb1vrtRcF7dCnWPH6c+K2U nU0GwRU5jit/XBqO8sEkbkNYMosx0rk9bLgXujTBCwed6jcDVdfh/LwYI6gRhP+0OiU4 ffKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BBtEKSWrHX7oRi7nDuVmg9+2L2x4e71Ci9OtLRXKd2c=; fh=jVBQddgLF+jems1TWsxdlRSlHlJp9BhLAEhytbJmGd0=; b=w7zMEagMlTf1H0kp4v312uu9Ff8aQbPXGXGpp59GZO9bKljpx3/CO7t0d/jycDU0rE 5URBBwKUJpmGLsXRz4EaTr9ITH6k4YhsGBLXKQtj9BmSG41H7lmA27k2oQCvHH/HUwhh QN6dN0XxRecPvG4tGP1rPhXxf++V1xlxJGfF/qBRo2cwIVBVlc2R9gXH7xdv4DqMRJpx qu/lYXavzI+4RlnDYGw+nEi1gH/UGw4dEJkBGDEcRcOh52V22v98NtEiMPcgeH7sa+OS /3Pbyt6jxDUu5hDYdV4B3c79sU56psfsULgs0XFVS1O+o1A1atpOMaFgTMlZQ8VoF8P9 8SiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a1709027e8100b001bf223b6595si119024pla.484.2023.09.05.11.37.13; Tue, 05 Sep 2023 11:37:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344137AbjIERCW (ORCPT + 99 others); Tue, 5 Sep 2023 13:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353586AbjIEGsx (ORCPT ); Tue, 5 Sep 2023 02:48:53 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49A06CC2 for ; Mon, 4 Sep 2023 23:48:50 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 82C3B68AFE; Tue, 5 Sep 2023 08:48:46 +0200 (CEST) Date: Tue, 5 Sep 2023 08:48:46 +0200 From: Christoph Hellwig To: Daniel Wagner Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Sagi Grimberg , Jason Gunthorpe , James Smart , Chaitanya Kulkarni , Christoph Hellwig Subject: Re: [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early Message-ID: <20230905064846.GA19701@lst.de> References: <20230829091350.16156-1-dwagner@suse.de> <20230829091350.16156-2-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829091350.16156-2-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline u16 nvmet_req_to_ctrl_id(struct nvmet_req *req) > { > - return req->sq->ctrl; > + if (!req->sq || !req->sq->ctrl) > + return 0; > + return req->sq->ctrl->cntlid; Can you add a comment here why we have this check?