Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230830103620.3611761-1-Naresh.Solanki@9elements.com>
 <20230830-waving-stinky-d510fefbbf82@spud> <CABqG17hvSYbsnYYGOQxVsiXsqLXFnovXvkhgc=pYR9osgF0-1g@mail.gmail.com>
 <20230831-defrost-rebalance-5efda5e5ff5c@spud>
In-Reply-To: <20230831-defrost-rebalance-5efda5e5ff5c@spud>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Fri, 1 Sep 2023 00:11:49 +0530
Message-ID: <CABqG17hxe+mn_qiXQ8ikPcU32KrU__FqkVaq_Aam=w_yF7qTkg@mail.gmail.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: hwmon: Add Infineon TDA38640
To:     Conor Dooley <conor@kernel.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        krzysztof.kozlowski+dt@linaro.org,
        Rob Herring <robh+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-hwmon@vger.kernel.org,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi

On Thu, 31 Aug 2023 at 21:24, Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote:
> > Hi
> >
> > On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote:
> > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote:
>
> > > > +      Indicates that the chip ENABLE pin is at fixed level or left
> > > > +      unconnected(has internal pull-down).
> > >
> > > Maybe you've already been over this, but if the pin is called "enable"
> > > why not use the same wording in the property?
> > EN & ENABLE is used interchangeably in the datasheet.
>
> Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for
> 2.
Ack.
Will go for EN as that's what is mentioned as pin name in datasheet.
>
> > Just to keep property name short I use EN.
>
> Consistency & readability trump brevity. Please pick one term, or point
> out that this is called two things in the datasheet.
Sure will pick one. i.e., EN. EN is pin name & description as mentioned in
datasheet is 'Enable pin to turn on and off the IC'

Regards,
Naresh

>