Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Sep 2023 09:40:16 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     James Clark <james.clark@arm.com>
Cc:     Ian Rogers <irogers@google.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v1] perf parse-events: Fix driver config term
Message-ID: <ZPchsHYId3ylN2P4@kernel.org>
References: <20230905033805.3094293-1-irogers@google.com>
 <d7bae298-9d83-1bff-15a2-4ebe433ec8af@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d7bae298-9d83-1bff-15a2-4ebe433ec8af@arm.com>
Precedence: bulk

Em Tue, Sep 05, 2023 at 09:40:30AM +0100, James Clark escreveu:
> 
> 
> On 05/09/2023 04:38, Ian Rogers wrote:
> > Inadvertently deleted in commit 30f4ade33d64 ("perf tools: Revert
> > enable indices setting syntax for BPF map").
> > 
> > Reported-by: James Clark <james.clark@arm.com>
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/util/parse-events.y | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index 4a305df61f74..21bfe7e0d944 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -839,6 +839,23 @@ PE_TERM
> >  
> >  	$$ = term;
> >  }
> > +|
> > +PE_DRV_CFG_TERM
> > +{
> > +	struct parse_events_term *term;
> > +	char *config = strdup($1);
> > +	int err;
> > +
> > +	if (!config)
> > +		YYNOMEM;
> > +	err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_DRV_CFG, config, $1, &@1, NULL);
> > +	if (err) {
> > +		free($1);
> > +		free(config);
> > +		PE_ABORT(err);
> > +	}
> > +	$$ = term;
> > +}
> >  
> >  sep_dc: ':' |
> >  
> 
> Reviewed-by: James Clark <james.clark@arm.com>


Thanks, applied.

- Arnaldo