Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Muchun Song <muchun.song@linux.dev>
Cc:     Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        linux-mips@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        "\"Mike Rapoport (IBM)\"" <rppt@kernel.org>
Subject: Re: [PATCH 2/3] use nth_page() in place of direct struct page
 manipulation.
Date:   Thu, 31 Aug 2023 11:37:24 -0400
Message-ID: <4B9F90AF-196B-4021-961E-4D08A8128272@nvidia.com>
In-Reply-To: <50EF53C6-0CE2-4256-B8AB-AE9BF290419D@linux.dev>
References: <20230830182753.55367-1-zi.yan@sent.com>
 <20230830182753.55367-3-zi.yan@sent.com>
 <50EF53C6-0CE2-4256-B8AB-AE9BF290419D@linux.dev>
Content-Type: multipart/signed;
 boundary="=_MailMate_B7756813-2B54-44AE-80AB-A93BCB54B20D_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JPZaltHP7zmvYxAQ0I4lxuFSSn8OhXXj1PaOPAwAynto1+UUcXJ0Z/BkHSKg?=
 =?us-ascii?Q?+CUfXF3gLHVfCKKtuUhsIQS1yfCIegpqe00+effe42As1t4fBwQe26eX1fox?=
 =?us-ascii?Q?11U3H9ofFUMJFpMPhtDiEbqVzQO9c/P4suqlmB6VvHdho/GXQE7hejn+Ir8c?=
 =?us-ascii?Q?YGmbynfkCP67kX0C0GhCQs6TgTPhZpHLIINefz/7romi4pacKlWjv+9mLRYR?=
 =?us-ascii?Q?baUgE7NUzgERrX22g4HVJH4zthDlp+KxgS1R1RR2MM8pbzCF4OymsMNjgoId?=
 =?us-ascii?Q?wiSZeYuWDabzoYtSUCe/2sF1ZiJAuF92VLbT6uue0+0fcbJblh0uTPtt77GV?=
 =?us-ascii?Q?dPUJ+d0GnOsrsDoV2p/kjKJYawfI+gt7OaLqvtgmAhvnLnN1O+EqmLa1Cx5z?=
 =?us-ascii?Q?50wJ/2bMrIMVyocs5HIFlk1lHXBkFZA8y/7qHlyffCZhGMN7e3MhZmxUazPx?=
 =?us-ascii?Q?/z/5BgkDrrZHF9tM39t5R5lvnM1yaLx7iHeH3n56qoh/+aNZyOgHct0q1IZD?=
 =?us-ascii?Q?ASF60FtcyIwivOzCXW3I92+5hw/tVOiG0vh6fbGmBMZV+gIkd9QX87wWU/+P?=
 =?us-ascii?Q?IUw2V9ZDrmXWLLTDYojVDhqgB9yzLucDjoH+x4nwKlGawY+uUoGow19lrsgR?=
 =?us-ascii?Q?WkQBsRbpbgLHeKN5AvL0pvpvjjurrDk5zA62eGnSdFUrp2wfq1R72bB3MdXz?=
 =?us-ascii?Q?UqcATZUV7w4CMzfQZ9jaSfpOhl2m1DORHX9uSJ7CVEZ8MDL/hNe/Y73PE9EM?=
 =?us-ascii?Q?UUlI3DfbNAtPruXiXwl2F+xbF8f+0X/KLBsJ2Hd++6x0HzT6ht+87zxnxmlN?=
 =?us-ascii?Q?+xKUfDkykem+F34lOdi4UpzxvHCbGJuYRXqadrBfFaW6zas6O6qqWlUw0/b3?=
 =?us-ascii?Q?yZVzdttzCkynEQC3AN7wvBUBw8YpSO3DjIRzA8YWsw+WfZyzpdGNWnpVnzWj?=
 =?us-ascii?Q?H1jtSrZcyAEGHhH2Q3weTeIVh3x7i12jdPpB9jc/2U7Fl8m1KL57M/qfVFzC?=
 =?us-ascii?Q?Q923/FHLdtmGlMolu8sP/G1AKo0eIeQpBCR9oyeTH6vQCmG0HGegunjX7Doa?=
 =?us-ascii?Q?kVVNmR9Mc0bw7KQUEClLHoOLKEwNDC5FhthEiqKoimTDmlfX/kOmnzlu0FJZ?=
 =?us-ascii?Q?9T/qHqM/w9dw315Vz6L+QSS7WAkkHknU4/l8ZzxZ5dDdAqO1BEHIaT3YhsEg?=
 =?us-ascii?Q?JsCq3m1hyg9hdlhsHCjO+OReT/Y0hs/l4byBwZtzBNq+7Y9byNPFNfwpSKQ6?=
 =?us-ascii?Q?3Jxk6sZ7EPZdAN95L13j2FIU3KH0m6J2xKVF1UgUi5NaOtR5M6Au2GFRo6de?=
 =?us-ascii?Q?9P6IuNSToNyM/meVx7JcrDzAoC+dTIq94YGzNdYuS28p//2F6nNWUVdXKE0T?=
 =?us-ascii?Q?o4YuGMDmxw6PwP5TS5r1/WrXDl5JNNGW1tzRV+zWLKGwH2XMjt0CG/+Ayp2S?=
 =?us-ascii?Q?IYM9zPaxJ6GrAtBfzauVoF6bdQKCY8Yd2hTWC9Ly65+ea8hOzJ+0L3VnZRcR?=
 =?us-ascii?Q?NA1hLCm08Z4eZFCgwnOZyzsU3Ob72aYWHtJuUfqlPaN5qobRbDsEEWlaOI5v?=
 =?us-ascii?Q?PdmhG1NlXvfzuBOl/eQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79fc362e-01b9-4024-f445-08dbaa382e36
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 15:37:27.4879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gCQSBzABFTvhKdAtAweqUu+/JH9KWFsWGmxRNa3AQYLrkIFgunnG9AQAb12yA/nR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6807
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_B7756813-2B54-44AE-80AB-A93BCB54B20D_=
Content-Type: text/plain

On 31 Aug 2023, at 3:17, Muchun Song wrote:

>> On Aug 31, 2023, at 02:27, Zi Yan <zi.yan@sent.com> wrote:
>>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> When dealing with hugetlb pages, struct page is not guaranteed to be
>> contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle it
>> properly.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com <mailto:ziy@nvidia.com>>
>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
>
> It's better to add a Fixes tag to the commit 38c1ddbde6.

Thanks. Will add it in the next version.

--
Best Regards,
Yan, Zi

--=_MailMate_B7756813-2B54-44AE-80AB-A93BCB54B20D_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmTws7UPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhU/2sP/iFdiEGWz260q4dzF/QC+y0/OWRYNLHP36Ka
imYAMR7K80f/RdHDTw7hwmZFjIqrNVZaoc2ymVvrmsyhsWNzxyMiOm216eLyEoI7
1CWsj6x1MPuEGR2JRW5t28eIxH/OOrg1T/OPFY5/+2/iIKF1wI507bKQGawr1n+q
eKLKA2pc3wZkkjcJtBlZ6Y/YyGVcUSciNPkphxq9p5qMAbbAXlip83+dLXjKdH+f
X7FDLD1odSfoqt3a/5u1JPF6+D/oYo4N2n9aFh4GzvOxAOcdV27x2j9HFByFYV7Z
Rtf8QTJwV+4QWDO0LRP6ViQBMtkbeus+EEMQun9A7w8+chRJXzoEW53d2EwOcEgZ
zca63AwsK+mGZFrpztfSHXYN84pPbMxIxEoI0Wezw3HSIhYmAwmh7DX49+LYjGu4
EpRAwuIIDbUKiIEVwE9niRMZyERLtGNiZkA4yzDEvClVC9z3dfuS0aIBlX8oRcj9
MWJ73OF6tGTxsORBLBBG35yaL9vuWadydJ1CRsIx3UyMNh9S9KrdcMEzk65ybdxq
c+5lp1xoeUqVV7V4DPsyoukZC69OmVcx2N5cnorR9QTQqrfIGZHTLIyAWaAupC6f
akobx8jYbkHMN6S73b+OI+SWX1ijfuARQsproyzwdnYjZPr92obr32pPkDDHcxr+
RxopIYNT
=K6lo
-----END PGP SIGNATURE-----

--=_MailMate_B7756813-2B54-44AE-80AB-A93BCB54B20D_=--