Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Pawel Zmarzly <pzmarzly@meta.com>
CC:     Damien Le Moal <dlemoal@kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives
Thread-Topic: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives
Thread-Index: AQHZ3QFxYKmpluKz2UyymccVFU2ydLAGULgA
Date:   Fri, 1 Sep 2023 18:51:52 +0000
Message-ID: <ZPIyxg+iSWa+W93Q@x1-carbon>
References: <ZPGznkRMxemW2N9E@x1-carbon>
 <20230901182317.3243660-1-pzmarzly@meta.com>
In-Reply-To: <20230901182317.3243660-1-pzmarzly@meta.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WN9Hu+ssE1HbKfwsEyR9XRlsK6ufnC4IABdy5fHJTPd+T6gZ3CkBI243hznz?=
 =?us-ascii?Q?r8VRMB4fU61TkQPCIxuINvSSVqej4d0D1AIjm6ShGDGk50YGC6QQ2rHT1a6j?=
 =?us-ascii?Q?3cSyPCGv1VPlOf5PtUSl7iciwl/QsVoIQRjmLQ7sLb8B71b/HsIny/tTZOk+?=
 =?us-ascii?Q?I3DSuwkQYeQxVDgAyrAPcd+5GnGyp4qn2fuCHuIVn6vcmEUO6AgiZtaNOEmd?=
 =?us-ascii?Q?efMpjaUXlYGKA5nObT5XMPA3nPVNw/M2e6Jz5NoJJx7hM4Tu40gTOu3nbNsS?=
 =?us-ascii?Q?xGieWImB+ynz4OdzlM601eOw6dTwF6GZo86QgT4UTYeg0Qt9CbSOPRujY5Ma?=
 =?us-ascii?Q?hV5RRyjQ9kcqbRjPMTBfhCjRqxUzCflSO32GkSTHKrvM6QGwiJ6OH+y9txrm?=
 =?us-ascii?Q?F8tZ/nx8QXGgq4djEwEBcsIe8G6d7nrfis8ZUicdmLNZiFF+jgjqR8ZIjIKO?=
 =?us-ascii?Q?if8w9w44lzj477M5nyZiI0aJ3BLVQ7HBkmDFCmhN5T0v6iOeWPCMdM5JIjKR?=
 =?us-ascii?Q?Y8JmSBGE0R4MNWzmusCY2B38utbEkLQFcJLjYMyEdld7JIdeuux1kLnnQX+m?=
 =?us-ascii?Q?M2uUABMRXUUVlNlfkCHlcGwqnl8slKHoCoKKqNeSrkauGs37g5mzXl5Mw1QD?=
 =?us-ascii?Q?ObJBJdVPdwb+DLFaFH8HNEfH5JVzUYfIgtVjvJ9I7ZY1E768xvdr/fTt4Xu9?=
 =?us-ascii?Q?r+/kvXTkL/yvHcDrzBu39o8GaCL8nccxjOKNE3sBCZc0RlDrwKkxkT1JlrYc?=
 =?us-ascii?Q?cPaRF4SSq5PgDXFyxSmaweHFduZ5D0XB1bl2ibUhgLFO+DvmPqYVX2LWU0fd?=
 =?us-ascii?Q?66WT7E3spC7tv74sLrqOO3EqPBkCgbxj4hYXMOeOTwApsCGo4aRlZ5cJ9xN3?=
 =?us-ascii?Q?5ym+9G7Crj9QFLFAegVXyJcsvkMqEn3Rzw+gojd2r2v214AEXEXcbuJtmY9l?=
 =?us-ascii?Q?lKObDA1W5ceIj9DcYbppQYntjQuyeSVRVYdAxNK6Aqy6/G6+ED/cPsRd19qG?=
 =?us-ascii?Q?aM4hl0ePvekDj3x/DEbUVv/0Yth/t3Unpu9eqRHvSzYDsFzkySTvKrpvCcfh?=
 =?us-ascii?Q?SzVenWZMsY31tq7VeMCcIo83rqb7t1z7QkrJ0U8izJnEXvxGKqq7gnOfazHq?=
 =?us-ascii?Q?umbvJlDu0HT/iknHCKJlKrP8foErDbq0+Lkb/3yE0QzQnsh05QfEPH1x5ZnN?=
 =?us-ascii?Q?3rqM49tT6Z4M4IYFXk9Ee8dPfmyH3MjjA7Ogahb7/vBqU2pSY6eh3ejptv2y?=
 =?us-ascii?Q?FYRFkKsZilA2kSK3XP96P7YI7BDHBoe4zlORxQPdZlLt6s+3bV0wRGR+jNJI?=
 =?us-ascii?Q?ll/bnwp99y3MzVPT6H6RHKb3t1VOUJz3W9pS6voBMUym/kZUqLuvJe26DBwz?=
 =?us-ascii?Q?1jju/TH2kderRfsgijJyYbLb7OjIEanWa/tVLwinzeC9sxodKYGHmH+lv3Wu?=
 =?us-ascii?Q?d3W4ke7amn9w1c64vDy2KayW6g9WwjOoD1/5qFOV1dZAcWhImvGoK+UQgvLu?=
 =?us-ascii?Q?cYoFVdFzdRjYyXS1VSS72iguqSfyy3SoLNgCIrdlvVi6b/fJftBmvxjuHNq5?=
 =?us-ascii?Q?/EHGgrr7DWiUk6WNJgMworulWhHMrBoH9hI9twGv7iwSfF1gmeAIjAtBm/9p?=
 =?us-ascii?Q?9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4D1A89A84E9C254594558CD97A78F928@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hasVPaZEChyITAjhOssIR7+DlclKYt/KW/PoAXkZfKEYK0FIowmsl1PvR9dIm/dHsFbQZCK8s1K9v168YAQpdaPZWUbS1DzwLkhDcb1282MKC7raAny74ir6Rj/A2aXaoSST3+W5LGinImUTYP+qrJkLzDNu0zuGZJVkQkWt1q9IP+KPm5M2ON/XmiGAIfo3841zCClOzwKuGJMyDAVkH5SMfCu8vRsOlobY6Md9EJ8wn6x6CtuY0tnRYQs+GyGPuUsChlPHjAiFXeGtvB7MgOaWsFfZudZHclb+PqV6vVpORD/jDzkO7jAwYNc33jaZTt4wbK0JNrqPcK5OcOpnBBvtO3W35/QrDCQBdQyxx5lVawHhCxF1ZGTBpUGLCYhkzaFevBhh3lbRdsG5HAne6Dd3Uo/dQNBxKl686+sKaD1vDa/cXmOR+kw2zCWTUplplpWIe/83DK2Byaju9b3lc3A27zLaWt+ZZTRvO4cLsd2VAHMzY3EusQq7pfO5Xh9HQ5+1FWArkgFK5UMiY49junKzmO4Uqs5g0pBow7enbHFKpBYOWw4hZtcAQRqx1HBdDMxOBjIAfb8HHBzuIJPtcXkHLQIZayhEqZMB6w12QMMBaM0pC9uFqzxdJ+bMe4WpQ4+15034K1IvPI4RrNYtYPGdVy4jMp9yswqTy12h+1rpMgRNtOn3tFseI1bI5HDjMdG+DU4VglA9ddbwmMLLlKSYsay48RzEuuoP3owBzvhfNQzmX83imoyghUReCut5aNSXNRsQOykXlJJFCr7HW39PVeXe9wVM2RDI+9py2FEnQL57vI/pdBQzpKNx0eH49L9ZKljH5uKii00FYSBQEw==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84f97338-af28-47a7-4f8f-08dbab1c8180
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2023 18:51:52.2897
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X6k8X625+Q3zHZ0OBeXOfcZC3+a33ukWfvreZV+a23WwTfisfd7shbAl723vY9lgv+nHHsGpwGoQzB674VzCgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6470
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Pawel,

On Fri, Sep 01, 2023 at 11:23:17AM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=3Dnoncqtrim.
> ---
> V1 -> V2: Fixed formatting.
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)

I think you forgot your Signed-off-by tag this time.

See:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch=
-format

E.g.

<commit message>
...
Signed-off-by: Author <author@mail>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments

path/to/file | 5+++--
...


If you run ./scripts/checkpatch.pl against your patch,
it should tell you if the Signed-off-by tag is missing.


Kind regards,
Niklas=