Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp2317125rdb; Wed, 6 Sep 2023 00:27:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFu3fbwknfeNHSyp6CUeu7ONls8l1e4QBw2wqIl3qeBiP/gmPY+tyn6N1wuzGaV81Gu+sfb X-Received: by 2002:aa7:d5c2:0:b0:521:ae63:ee63 with SMTP id d2-20020aa7d5c2000000b00521ae63ee63mr1518981eds.16.1693985261977; Wed, 06 Sep 2023 00:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693985261; cv=none; d=google.com; s=arc-20160816; b=XqLccJckbsj5VfP7maEIxYwDjgg6ldlsY2tMZQR6AmDKdnW/tFg52dCcGoErPhIq67 m3NIiLP0c8PpviAvwTTjh3/3q6GzPjFyxxzg3EUgthxQcGT5w0Vb9e8pEJ0i6S6viQa2 MPw2hm14fn36DWgTRckflgroSznheWLlfwo2vLWjYithFUHBJPbvl1/zP1kCcx47mxUZ ZrtOZ/ehpQRYO8fSAMzshbs7HvelYI9LXKhwUalPASO5lGAIHDCsv3+LhBgMAa4kwV0/ WX2M1gJ3MFGw094/7hv5H+R4gB4rIF4SfMwYw5RMhwZ9rmz2q+mBQZCxcBjazUN6bXxN 8F6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ifsZ8yi4835taTQNSc5S1qaw7m0F57MikGUO8RnhsUE=; fh=YY/47Lc5Tyfnm8LeFErUEa7HNTBPOD80ismnJYP8llQ=; b=nLmXZXNKIgWlBdMPxzeV8MuK4oBIY+P2y8ZRPboI4mf7XZupSgjz/n2grMw37x8fnG Gw+1LjxStelmCkFCgTrG7wiLTmvEavlO24ec5k9WlgEx9cF5YiC2WevQoXtbU/sdfuLA 8Ksg4L3vUTvKHLA6x+XZSD/P1gyCrFv0Xvfq9KVnx8ohy1aVU8lESr9omKRHi8/plgVE JtpY88l8TuSRmxjEVG6DLT+d2CQpNbh3wgFhub2I4Vi6Qf++QvJbfNEHIl2DeWyS28rj yOcg+O3k03Mv8bbhPpWknnhZunenZbIyP280pqKWuWcdrkhBoHHV2dPsP4MAFMM88ULo r4wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020aa7d691000000b0052a1ce53c9asi8891794edr.517.2023.09.06.00.27.13; Wed, 06 Sep 2023 00:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235534AbjIFBuI (ORCPT + 99 others); Tue, 5 Sep 2023 21:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbjIFBuI (ORCPT ); Tue, 5 Sep 2023 21:50:08 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50DD3CD2; Tue, 5 Sep 2023 18:50:01 -0700 (PDT) X-UUID: 9e3770defd2a49d09c2b421257c58c5f-20230906 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:e80f1eb1-720b-45a1-a92a-0754ddea1d50,IP:15, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-INFO: VERSION:1.1.31,REQID:e80f1eb1-720b-45a1-a92a-0754ddea1d50,IP:15,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:0 X-CID-META: VersionHash:0ad78a4,CLOUDID:61312920-33fd-4aaa-bb43-d3fd68d9d5ae,B ulkID:230906094948VYPMASHI,BulkQuantity:0,Recheck:0,SF:24|17|19|44|102,TC: nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OS I:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 9e3770defd2a49d09c2b421257c58c5f-20230906 X-User: oushixiong@kylinos.cn Received: from localhost.localdomain [(111.48.58.12)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 779420723; Wed, 06 Sep 2023 09:49:45 +0800 From: oushixiong To: Jason Gunthorpe Cc: Yishai Hadas , Shameer Kolothum , Kevin Tian , Brett Creeley , Alex Williamson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH] vfio/pds: Add missing PCI_IOV depends Date: Wed, 6 Sep 2023 09:49:42 +0800 Message-Id: <20230906014942.1658769-1-oushixiong@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shixiong Ou If PCI_ATS isn't set, then pdev->physfn is not defined. it causes a compilation issue: ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’? 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id, | ^~~~~~ So adding PCI_IOV depends to select PCI_ATS. Signed-off-by: Shixiong Ou --- drivers/vfio/pci/pds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig index 407b3fd32733..6eceef7b028a 100644 --- a/drivers/vfio/pci/pds/Kconfig +++ b/drivers/vfio/pci/pds/Kconfig @@ -3,7 +3,7 @@ config PDS_VFIO_PCI tristate "VFIO support for PDS PCI devices" - depends on PDS_CORE + depends on PDS_CORE && PCI_IOV select VFIO_PCI_CORE help This provides generic PCI support for PDS devices using the VFIO -- 2.25.1