Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] ubifs: fix possible dereference after free
To:     Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
        <richard@nod.at>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <yusongping@huawei.com>, <artem.kuzin@huawei.com>
References: <20230905101222.1725230-1-konstantin.meskhidze@huawei.com>
From:   Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <939c0385-8663-91a2-df20-920f264a2aa1@huawei.com>
Date:   Wed, 6 Sep 2023 09:42:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20230905101222.1725230-1-konstantin.meskhidze@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

?? 2023/9/5 18:12, Konstantin Meskhidze д??:
> 'old_idx' could be dereferenced after free via 'rb_link_node' function
> call.
> 
> Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed")
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---
>   fs/ubifs/tnc.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Only for static alarms??although it couldn't happen in theory.

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

> diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
> index 6b7d95b65f4b..f4728e65d1bd 100644
> --- a/fs/ubifs/tnc.c
> +++ b/fs/ubifs/tnc.c
> @@ -64,8 +64,9 @@ static void do_insert_old_idx(struct ubifs_info *c,
>   			p = &(*p)->rb_right;
>   		else {
>   			ubifs_err(c, "old idx added twice!");
>   			kfree(old_idx);
> +			return;
>   		}
>   	}
>   	rb_link_node(&old_idx->rb, parent, p);
>   	rb_insert_color(&old_idx->rb, &c->old_idx);
>