Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp3299644rdb; Thu, 7 Sep 2023 10:17:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0BKYb2vFOif864feWxTeP7sVlHWok6tUc1bnJ8oCiU4tfS9j2s/qa65ofqt3HRwU7TMwe X-Received: by 2002:a17:902:e751:b0:1c3:2af5:19f3 with SMTP id p17-20020a170902e75100b001c32af519f3mr161909plf.5.1694107069257; Thu, 07 Sep 2023 10:17:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694107069; cv=none; d=google.com; s=arc-20160816; b=TmPuDv6PPvNdVHAeBngMoAq2Rd0Rioo7JiFjXkdOEVTdZ7zr7CWutlz/Ueidn3cke+ 9CrVUdwzB4h4hHEzkQg2z4p8SZA+GkO/FSPY1QHtjW77LimN6ZKPxb8OHXtqA1nFiB+b 0zkDC4mGWuSPKKRUZx3y7gmCFu+A5C5ukDeRG5D20R+muUPauvt0tigG6DPEo90N6FXb DHKzXulde7YxRPl2CXzutw8qxQofApN+/dyPZ+lTtVe8U0FYTsJV2QfrljYOMIhYWl4e OalYT9MkF6lX0ndKylGwKc9G7rrB8h0WcuDsGx/DEXKXP/8ZqDEhsGfvvxX0fGx8fFTt ruWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8JrzSlPOHU42GkQamw58PH/veXFBL+Cm8CkXRD1KyBs=; fh=GkaHvC1hcueeMsWD1eEyL8PgTf7zKZ7NUy+EoZl0FP8=; b=hZvMzdMEtrI5x7BkmnZyq1V/n1LqF1vigf60SSQRMi0Ttrij3N+V1j+U8Iu9f43s7J m4J2u/mUjm/i8JWq6jCg8nqV2DhdfK4hoslhN2BpGGS9nFNEEfhJM8H+FMeL1CGzkd/G 1xwLgJxBZ4feABVw8D/UZgSQL+O1ffMHtkqEiiFKz5V73WniPYFfngDi+IUB9AW6MWJA jsGor4mN8/pQEL0FHiYaXvRjtovgFTLbZhYKjBEp/MUH9dx9ukbC3rAz+VqdFybHBk/b aX5cOSUZNUPgfAfnZB5pgB8S2dXAjF86sHTjAUTC2jyUmb79mkFk2h3+GWOFTDGm5cFa YWQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDRHKrZs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y17-20020a170902e19100b001b9fef6bf58si26430pla.294.2023.09.07.10.17.35; Thu, 07 Sep 2023 10:17:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDRHKrZs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239765AbjIGQgO (ORCPT + 99 others); Thu, 7 Sep 2023 12:36:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238790AbjIGQgJ (ORCPT ); Thu, 7 Sep 2023 12:36:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C82E49E6 for ; Thu, 7 Sep 2023 09:23:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76AA4C3278E; Thu, 7 Sep 2023 14:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694096168; bh=8JrzSlPOHU42GkQamw58PH/veXFBL+Cm8CkXRD1KyBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDRHKrZszzGp/6+LOcfk9eZT8hKdqPBDm5GWZU8g9kZIgK2Yjnc1ufry1hSWZgstG aK6gQnBBm6C+Wbv+9fncPONMT5VcYt0fdjp71vEZADzucV5uXCc4DFjyjg+og/Wn81 J497F5KUv2CKlV/uiYBHPga47FLQqObrIuC8gOvxfGY8b/0OuMEtxKa0e7BOetzecu 8GLFbbjjG5C/2+kg6zKONPV9itQ0dkYZS/a016VIAgAH4yHwUttlDL6mvhZzY1jjmi VhD2FnUdJQQsD+WNL8I3CyB1O4CGo08Q0V5aaaQARs9Y6+QzJAPPMD2RRXFE4ytRLj N3uP4SxNexslA== Date: Thu, 7 Sep 2023 16:16:06 +0200 From: Maxime Ripard To: Doug Anderson Cc: dri-devel@lists.freedesktop.org, Linus Walleij , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper Message-ID: <5lumjodqq4r5ycy3ch4bo476as6wzztuokounc554x55ds3j4t@olco7idlqyvv> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5nfgr3jzpbtcxkrl" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5nfgr3jzpbtcxkrl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 05, 2023 at 12:12:58PM -0700, Doug Anderson wrote: > Hi, >=20 > On Tue, Sep 5, 2023 at 9:45=E2=80=AFAM Doug Anderson wrote: > > > > As per our discussion, in V2 we will make drm_panel_remove() actually > > unprepare / disable a panel if it was left enabled. This would > > essentially fold in the drm_panel_helper_shutdown() from my RFC patch. > > This would make tdo_tl070wsh30_panel_remove() behave the same as it > > did before. Ugh, though I may have to think about this more when I get > > to implementation since I don't think there's a guarantee of the > > ordering of shutdown calls between the DRM driver and the panel. > > Anyway, something to discuss later. >=20 > Ugh, ignore the above paragraph. I managed to confuse myself and was > thinking about shutdown but talking about remove. Sigh. :( Instead, > pretend the above paragraph said: >=20 > As per our discussion, in V2 we will make drm_panel_remove() actually > unprepare / disable a panel (and print a warning) if it was left > enabled. This would essentially fold in the > drm_panel_helper_shutdown() from my RFC patch (but add a warning). > This would make tdo_tl070wsh30_panel_remove() behave the same as it > did before with the addition of a warning if someone tries to remove a > currently powered panel. Ok, that works for me :) Maxime --5nfgr3jzpbtcxkrl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZPnbJgAKCRDj7w1vZxhR xYdXAQDS1cue4E9OGS5pb/O++U6pd9L1ArAFEFEdqpxuMiBe3gEAiNmyCk2ECIUW yQIGM7RiEMhRg+3HAkhmIIFKRYuv9AI= =kxSy -----END PGP SIGNATURE----- --5nfgr3jzpbtcxkrl--