Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230907110305.2096052-1-masahiroy@kernel.org> <ZPnZHzOli8w0Lqwr@smile.fi.intel.com>
In-Reply-To: <ZPnZHzOli8w0Lqwr@smile.fi.intel.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 8 Sep 2023 22:58:04 +0900
Message-ID: <CAK7LNATK--vNGT8x67=KMeoETXdvsSZt2_x7jUgpazyaoHgr3g@mail.gmail.com>
Subject: Re: [PATCH] devres: rename the first parameter of devm_add_action_or_reset()
To:     Andy Shevchenko <andy@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        "Rafael J . Wysocki" <rafael@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 7, 2023 at 11:24=E2=80=AFPM Andy Shevchenko <andy@kernel.org> w=
rote:
>
> On Thu, Sep 07, 2023 at 08:03:05PM +0900, Masahiro Yamada wrote:
> > Fix a possible mistake in commit 410e7088e971 ("devres: Pass unique nam=
e
> > of the resource to devm_add_action_or_reset()").
> >
> > The first parameter of devm_add_action_or_reset() is the associated
> > device. The name 'release' is confusing because it is often used for
> > dr_release_t in the devres context.
> >
> > Rename it to 'dev'. No functional change intended.
>
> ...
>
> > -#define devm_add_action_or_reset(release, action, data) \
> > -     __devm_add_action_or_reset(release, action, data, #action)
> > +#define devm_add_action_or_reset(dev, action, data) \
> > +     __devm_add_action_or_reset(dev, action, data, #action)
>
> What about devm_add_action() and Co?


I will fix devm_add_action too.


Thanks.


> --
> With Best Regards,
> Andy Shevchenko
>
>


--=20
Best Regards
Masahiro Yamada