Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <542d0b86-eb5d-cca5-3c8c-857976ca5adb@intel.com>
Date:   Fri, 8 Sep 2023 10:25:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH v1] thermal: Constify the trip argument of the
 .get_trend() zone callback
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>
CC:     Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>, <linux-omap@vger.kernel.org>,
        Amit Kucheria <amitk@kernel.org>, Keerthy <j-keerthy@ti.com>
References: <5709115.DvuYhMxLoT@kreacher>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <5709115.DvuYhMxLoT@kreacher>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFllRDFIa1YyOGtkMUZGRnFuc0VZTldHUVUraUl2Z29rOXRzeTc1MHQraWgx?=
 =?utf-8?B?cEhUMWRSaE12L2xod3k5aEFBT2l6YUdPWkN1ZEF1OEFDM3o5S2lzRWd4dnlN?=
 =?utf-8?B?UUZZeDErVE5KaFBCUkdvQXlXOGltNUt4dmlzMndRdGc5aW9mYStEbXI4aXZY?=
 =?utf-8?B?UjRjbm5vY2tnb2QwdjRHWDBDM0FEREFTUFI3cGNBWkRjR2FEQ0FiNHZoaVF4?=
 =?utf-8?B?NEFubE1NcUFYZFhKZFRNdnB3clBLem93dmRwTG93dm1OeVp5NXlpc2V2dmVR?=
 =?utf-8?B?M0MwOTJtcDhIYngvbGtmdEtGMExuc3ViQjZySDVrWDR3MmVuSkk1eFp6NUpL?=
 =?utf-8?B?ejFoS1QyZE93N1BqZGEvTENGZGRNMXg1c2FXVUI1aDZLeHpFVDhtdHk5OVVE?=
 =?utf-8?B?aTlpeklLUGR1RG5HbHdQa0Yza3FET0U1KzBlWjFlM1BDSFJDMDZqZGpLZUtX?=
 =?utf-8?B?aGJsZEFaRTNFTVJvTEdMNGlENGYxdVdtcmdTNUcwRmJJUzc4Uk5lWEJReWl6?=
 =?utf-8?B?Z0hDR0thaDlCMkQ2TDVRN0RodEI2eXowLzkvQVpFWG1ZUHk5b20wek5iZVIr?=
 =?utf-8?B?RHMyVmZ0UUJRYnVpQXNvQzNDZ3M3N0FvdkdTYUI0OG5xTEF4TEE3dzNNYXhE?=
 =?utf-8?B?UE5lK0JYeVliV2pPWVRrQ1Bvc0dMNlRCMkpJUEFCQkg3cjdNb1ZOVXF2NG5J?=
 =?utf-8?B?dG9Ec3ZlT0E0QnZmZDZJaDNXMk9iZ2NTdWxUV0hCS0tTSGQwQnRsQUp4NW9U?=
 =?utf-8?B?SjhiMStGM0tsd0d4S0RlejBGbjQ2UFlJVDZhTWtVdmg3ZFZNRFJaeTNVVlc1?=
 =?utf-8?B?Q1FSSHZDRXh4Z3dBS2pHYUxuSmJXVzNWN25aYWI3NTcwbWppeHhaNEtsQkhy?=
 =?utf-8?B?T3BPSkdvM1ZzNzNVN3RoeVJwZyt0eDNKaGxPUWVaSXdSSlJFdlZDREZHMTZo?=
 =?utf-8?B?T1NGcW0rRjdVSDIzeFQ3WjNxd0RIeEV0NjU2Q2VMUWdkVkpYVE9yL3RkSlFl?=
 =?utf-8?B?K3J0ME5ZSWdHRXVnRE1mQWNwRjNsdmpwS05CcUM1YmhmU0V3UThnczBNd2hN?=
 =?utf-8?B?NnZGejhjd2dLMlF5d29DZE04Rm5vdUd0ZllyZHRaSlZXaDRWTmdYQ0xuZ2NE?=
 =?utf-8?B?cDR4aXp5Q1d5VGxqb2doTFJ2bEZCNXFBbkl0emxVL0thNklLR0lxS0Ywam5R?=
 =?utf-8?B?WmVsK1JrR0hrMkV5VDRLVk1KcWppcFNHeDRjQXVPUHhRb2U3T2RjM0l4eGYy?=
 =?utf-8?B?YkhMMTN1aXFxMSs4amVXRE55TDlDUVpoNFpIL1JsaVoxcWI1WVpJbmw3MzBE?=
 =?utf-8?B?LzhNQ0dsaUlxVTRmRFdWUGZSTVFuRUVoSnliSFpzNFJDRDc3MzRNTnZQMjhK?=
 =?utf-8?B?TEd4RDVvamtkdnI2Vk80WWdjM3dWakRZbjk3WVFZSVB3L2hnSkdiOTJ1SjBN?=
 =?utf-8?B?RjA4VUE3dCtsQ0J1NmdHdHRHYisyY0FrTWNaTlYzcFk3S3grd010VDY1VXdm?=
 =?utf-8?B?ZEQxVzlETmx3eVpPT2FjNHB5NkwrS0Z4MkpCL1FqbVBXbVg0STdEYXV2LzQw?=
 =?utf-8?B?QkhSb3hBaUdtL0VnSXlwYkYyLzdiTDQvL0hNOTlnV0IyaStGZUVvZzlhYWhE?=
 =?utf-8?B?aVhrVTlPOGJOMTdkYWxVU0ZhUGxPNGJYM1BtczJnb29zMzlYQnVpWkZzcG5z?=
 =?utf-8?B?T2NrcDQzalFhdHF5VlQ1NnJncWZ5aHBjNUMxRlBzOGxKbkRFb1dSRituVjFa?=
 =?utf-8?B?OTFIL2FXZDcvQkVVdjdZamdnREVpUUEzT0VObktkWmNXWHBYSHlvMmJxRnpj?=
 =?utf-8?B?K2xOUUNYZnBKM0h2M3J3b3IvZDZhQzAwbTlrKytubDdaMnI3bjFUMFQwbXFZ?=
 =?utf-8?B?V1U3VUxBajdmdTNCSy9PWm5UL2JBNnFhMVpuREwrb2w0ZmdZSjUxTTRXeGpx?=
 =?utf-8?B?TTZsYVZmcDJYSjFVU29MaUl4eWIrRzdSSjNRbTIwNFExRFAyM1AvQlRGWWl2?=
 =?utf-8?B?UzYwMk5PcmJNVHVCZGRLbERQd0ZaeUlqemM3UUsrck80Rm1seHRDbzZXTXRr?=
 =?utf-8?B?MXVoWGZFTVRRaUtCSkxOdW9pU1RBQ2pjR25EcjNjZGlEek1ZbytZMEtEV1lS?=
 =?utf-8?B?SUx4UUV4MFNmVkxsanduRk9GSkN3ZEp2SGVhTzVTWUFoWEJjNmMyb0NVYTRs?=
 =?utf-8?B?bGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54116634-80da-46db-a814-08dbb0452779
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2023 08:25:26.7285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iyfM7tvtI++CfeQ3lvPYxViQGZ5rW3DJshHvKoqJM5oPM9eUJf3w3ixfZ1Z42rzNEd8XChx1cuKNDLNBEuZ3C+1cMGC2u4uFylxOrHbpT8g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8098
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2023 8:18 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Add 'const' to the definition of the 'trip' argument of the
> .get_trend() thermal zone callback to indicate that the trip point
> passed to it should not be modified by it and adjust the
> callback functions implementing it, thermal_get_trend() in the
> ACPI thermal driver and __ti_thermal_get_trend(), accordingly.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/thermal.c                             |    2 +-
>  drivers/thermal/ti-soc-thermal/ti-thermal-common.c |    3 ++-
>  include/linux/thermal.h                            |    4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
>
> Index: linux-pm/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ linux-pm/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -110,7 +110,8 @@ static inline int __ti_thermal_get_temp(
>  }
>  
>  static int __ti_thermal_get_trend(struct thermal_zone_device *tz,
> -				  struct thermal_trip *trip, enum thermal_trend *trend)
> +				  const struct thermal_trip *trip,
> +				  enum thermal_trend *trend)
>  {
>  	struct ti_thermal_data *data = thermal_zone_device_priv(tz);
>  	struct ti_bandgap *bgp;
> Index: linux-pm/include/linux/thermal.h
> ===================================================================
> --- linux-pm.orig/include/linux/thermal.h
> +++ linux-pm/include/linux/thermal.h
> @@ -80,8 +80,8 @@ struct thermal_zone_device_ops {
>  	int (*set_trip_hyst) (struct thermal_zone_device *, int, int);
>  	int (*get_crit_temp) (struct thermal_zone_device *, int *);
>  	int (*set_emul_temp) (struct thermal_zone_device *, int);
> -	int (*get_trend) (struct thermal_zone_device *, struct thermal_trip *,
> -			  enum thermal_trend *);
> +	int (*get_trend) (struct thermal_zone_device *,
> +			  const struct thermal_trip *, enum thermal_trend *);
>  	void (*hot)(struct thermal_zone_device *);
>  	void (*critical)(struct thermal_zone_device *);
>  };
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -531,7 +531,7 @@ static int thermal_get_temp(struct therm
>  }
>  
>  static int thermal_get_trend(struct thermal_zone_device *thermal,
> -			     struct thermal_trip *trip,
> +			     const struct thermal_trip *trip,
>  			     enum thermal_trend *trend)
>  {
>  	struct acpi_thermal *tz = thermal_zone_device_priv(thermal);
>

Looks good to me,
Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>

>