Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45aef3e9-b6ee-ba26-32ac-ea72f41d1dcb@opensource.cirrus.com>
Date:   Fri, 8 Sep 2023 10:15:02 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.14.0
Subject: Re: [PATCH v2 04/11] ASoC: cs35l41: Fix broken shared boost
 activation
Content-Language: en-US
To:     Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
        James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        "Richard Fitzgerald" <rf@opensource.cirrus.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Vitaly Rodionov <vitalyr@opensource.cirrus.com>
CC:     <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
        <linux-kernel@vger.kernel.org>, <kernel@collabora.com>
References: <20230907171010.1447274-1-cristian.ciocaltea@collabora.com>
 <20230907171010.1447274-5-cristian.ciocaltea@collabora.com>
From:   "Rhodes, David" <drhodes@opensource.cirrus.com>
In-Reply-To: <20230907171010.1447274-5-cristian.ciocaltea@collabora.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/7/23 12:10 PM, Cristian Ciocaltea wrote:
> Enabling the active/passive shared boosts requires setting SYNC_EN, but
> *not* before receiving the PLL Lock signal.
> 

> Solve the issue by setting the SYNC_EN bit in PWR_CTRL3 register right
> after receiving the PLL Lock interrupt.
> 
> Additionally, drop the unnecessary writes to PWR_CTRL1 register, part of
> the original mdsync_up_seq, which would have toggled GLOBAL_EN with
> unwanted consequences on PLL locking behavior.
> 
> Fixes: f5030564938b ("ALSA: cs35l41: Add shared boost feature")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---

Looks good. If it's convenient to revise again, I think you could slim 
down the comment section by simply stating that 'PLL Lock requires the 
audio clocks to be active' (which is why it is not triggered until after 
snd_pcm_start).

Reviewed-by: David Rhodes <david.rhodes@cirrus.com>

Thanks,
David