Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i58a146ae:Fastmail
Date:   Sat, 9 Sep 2023 08:59:11 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     linux-m68k@lists.linux-m68k.org, Arnd Bergmann <arnd@arndb.de>,
        Michael Schmitz <schmitzmic@gmail.com>,
        Philip Blundell <philb@gnu.org>,
        Greg Ungerer <gerg@linux-m68k.org>,
        Joshua Thompson <funaho@jurai.org>,
        Sam Creasey <sammy@sammy.net>,
        Laurent Vivier <laurent@vivier.eu>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 32/52] m68k: mac: Add and use "mac.h"
In-Reply-To: <CAMuHMdV1Xejj2hmS6fO=gviRCuqL82S+9nFLtSkJjH-aALWThQ@mail.gmail.com>
Message-ID: <4a126e21-6c36-024b-9ab1-b4798ef274d4@linux-m68k.org>
References: <cover.1694093327.git.geert@linux-m68k.org> <e9f3da9b152b7d19b64d775d04e9e11b63dc35b6.1694093327.git.geert@linux-m68k.org> <1c7894fe-4cf4-1ad9-5ed2-aaab4351ff4c@linux-m68k.org>
 <CAMuHMdV1Xejj2hmS6fO=gviRCuqL82S+9nFLtSkJjH-aALWThQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="-1463811774-325678859-1694213835=:13296"
Content-ID: <dc62573c-a8e6-d248-7fd8-89db80912592@nippy.intranet>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-325678859-1694213835=:13296
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <0046fe36-494a-d0fa-fe49-88f0be5cfc9a@nippy.intranet>

On Fri, 8 Sep 2023, Geert Uytterhoeven wrote:

> On Fri, Sep 8, 2023 at 1:44=E2=80=AFAM Finn Thain <fthain@linux-m68k.org>=
 wrote:
> > On Thu, 7 Sep 2023, Geert Uytterhoeven wrote:
> > > --- /dev/null
> > > +++ b/arch/m68k/mac/mac.h
> > > @@ -0,0 +1,25 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +
> > > +struct rtc_time;
> > > +
> >
> > I don't think we need a new header file. Related function prototypes
> > already have homes in existing header files --
> >
> > > +/* baboon.c */
> > > +void baboon_init(void);
> > > +
> >
> > this could go into mac_baboon.h
> >
> > > +/* iop.c */
> > > +void iop_init(void);
> > > +
> >
> > mac_iop.h
> >
> > > +/* misc.c */
> > > +int mac_hwclk(int op, struct rtc_time *t);
> > > +
> >
> > macintosh.h
> >
> > > +/* macboing.c */
> > > +void mac_mksound(unsigned int freq, unsigned int length);
> > > +
> >
> > mac_asc.h
> >
> > > +/* oss.c */
> > > +void oss_init(void);
> > > +
> >
> > mac_oss.h
> >
> > > +/* psc.c */
> > > +void psc_init(void);
> > > +
> >
> > mac_psc.h
> >
> > > +/* via.c */
> > > +void via_init(void);
> > > +void via_init_clock(void);
> >
> > mac_via.h
>=20
> All mac*.h you suggest live under arch/m68k/include/asm/, and are thus=20
> shared with the whole tree, while only the core code under arch/m68k/=20
> needs these definitions.
>=20

I guess #include "../mac/mac.h" is expected but
#include "../../m68k/mac/mac.h" is not intended (?)
---1463811774-325678859-1694213835=:13296--