Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Sep 2023 22:10:46 +0200
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Rob Herring <robh+dt@kernel.org>,
        Frank Wunderlich <linux@fw-web.de>
CC:     linux-mediatek@lists.infradead.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v1=5D_arm64=3A_dts=3A_mt7986=3A_add_?= =?US-ASCII?Q?overlay_for_SATA_power_socket_on_BPI-R3?=
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <CAL_Jsq+f9bq5Mab9m1pzDeiw304TMeNDmJk+ofG6M8J9QD3cvQ@mail.gmail.com>
References: <20230901072730.13571-1-linux@fw-web.de> <CAL_Jsq+f9bq5Mab9m1pzDeiw304TMeNDmJk+ofG6M8J9QD3cvQ@mail.gmail.com>
Message-ID: <76060BF0-B432-4BB8-A5C8-39EFF3D628EA@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Ss/nr+jQw9E=;KQ95qghdY1pu9I5xgPu52kh2iwU
 5qVj231gP+5kSSXN4Z0SJ5EsFE2m0mpGMqEqdyxUsSFy8MIn3oCTG3z0OYRKlp7YK38y64GW2
 DHLibRH5iTfl5rjCWTuw76PdbctbUkQmJ6E/76dzmMSoKSGrsjgDE1wz6BGYOVN9wK0TbGn5H
 T05pICixPkzfU6ETBzAtcB3106/duTjXsDRdgG8cC1QTEUIKpHeBf5lYIN5Ts0dVH7hKu2OkT
 ZCgaEejYh/XXOxckIX3S6AJH6cTWPEz2H7JwNb+swKSl66QrXb6Kg99U+IsrM+D91aqnF5dQD
 N/6XMSdHuMzTjQ8BvEiqD+JxzETcvIrFKSCu6pEceRSeUaAtCRqLAjP26IL/Ap61MdmGSNynv
 LfJlVGWdD6Y+4ba65zu2qecPGJ5Ij+51rXT9eICi5upd3z3mcn+Ur2mVDYGbSAfO9NT2/+KxQ
 LMCVEGfG/fjVpE/zqVoxg1i1MZDwTSX8icHod80r5GyF265w81nz6pul4J+944YAPXtBfe7hS
 4X2hvFB7UZG8wvwPV3rBU6jYwRHb6I0faSayNUvkMn4ln0P+KVQ7spZ17tvlJB+ZkDYPmXjfX
 3nhH3+tkTnrWXQyihRESXgacVpkcfMfnSmLSudCDq8R9Lgk8eJ+m+gwvXDgVOjHERq17jF8oU
 CJX1CJD+hcmw4JD2lBHOwujuJrqpapRh3T9eHRwRaVY259Jj/wcDi0fcpYrPMdHjoE1ep/0KB
 Fjt5eI1tFaUoLFLeXyXL1cl34mAVpuNFhFqJtBcO0ngQ2311tgZX7UNm+ejJNep+3t53KucCb
 FKtRgI09Dphvz/QhN6R7fySZcgavIFgYPcJssLFRsqSGNgEnMUwkLnY3LpkAW8iy4qgOiG9YY
 N/SdjSjuMXbH76KKn5ty2cWu+zabHnhKu0Amqca77mvKJ36pwNGldiZznteKhiXTsX2lxtbBr
 lD0MtA==
Precedence: bulk

Am 11=2E September 2023 21:51:42 MESZ schrieb Rob Herring <robh+dt@kernel=
=2Eorg>:
>On Fri, Sep 1, 2023 at 2:27=E2=80=AFAM Frank Wunderlich <linux@fw-web=2Ed=
e> wrote:
>>
>> From: Frank Wunderlich <frank-w@public-files=2Ede>
>>
>> Bananapi R3 has a Power socket entended for using external SATA drives=
=2E
>> This Socket is off by default but can be switched with gpio 8=2E
>>
>> Add an overlay to activate it=2E
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files=2Ede>
>> ---
>>  arch/arm64/boot/dts/mediatek/Makefile         |  1 +
>>  =2E=2E=2E/mt7986a-bananapi-bpi-r3-sata=2Edtso         | 39 +++++++++++=
++++++++
>>  2 files changed, 40 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r=
3-sata=2Edtso
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dt=
s/mediatek/Makefile
>> index c99c3372a4b5=2E=2E822d3e36d3df 100644
>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>> @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi=
-r3-emmc=2Edtbo
>>  dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nand=2Edtbo
>>  dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nor=2Edtbo
>>  dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-sd=2Edtbo
>> +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-sata=2Edtbo
>
>The requirement for overlays is they have a target base dt in tree and
>that you apply the overlay to it=2E All these existing overlays have the
>same problem which I pointed out when you submitted them=2E Please fix
>the existing ones before adding more=2E
>
>
>Rob

Hi Rob,

i do not understand the problem as there is a target base dt=2E=2E=2Emt798=
6a-bananapi-bpi-r3=2Edtb=2E

Do you mean that overlays should be merged with basedt at compiletime?

We pack the base-dt and all overlays into one fit image and let uboot dyna=
mically select the combination to apply=2E E=2Eg=2E check if emmc is availa=
ble, if yes apply emmc overlay else the sd one,same for nand/nor=2E

Else i do not know *how* to fix as i don't see it as broken=2E

regards Frank